* [PATCH] perf: arm-cmn: remove unused macro
@ 2024-10-12 9:24 Ba Jing
2024-10-14 14:12 ` Robin Murphy
0 siblings, 1 reply; 2+ messages in thread
From: Ba Jing @ 2024-10-12 9:24 UTC (permalink / raw)
To: robin.murphy; +Cc: will, mark.rutland, linux-arm-kernel, linux-kernel, Ba Jing
By reading the code, I found the marco CMN_HNP_PMU_EVENT_SEL
is never referenced in the code. Just remove it.
Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
---
drivers/perf/arm-cmn.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c
index 397a46410f7c..37b62d0dcc06 100644
--- a/drivers/perf/arm-cmn.c
+++ b/drivers/perf/arm-cmn.c
@@ -79,7 +79,6 @@
/* Some types are designed to coexist with another device in the same node */
#define CMN_CCLA_PMU_EVENT_SEL 0x008
-#define CMN_HNP_PMU_EVENT_SEL 0x008
/* DTMs live in the PMU space of XP registers */
#define CMN_DTM_WPn(n) (0x1A0 + (n) * 0x18)
--
2.33.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] perf: arm-cmn: remove unused macro
2024-10-12 9:24 [PATCH] perf: arm-cmn: remove unused macro Ba Jing
@ 2024-10-14 14:12 ` Robin Murphy
0 siblings, 0 replies; 2+ messages in thread
From: Robin Murphy @ 2024-10-14 14:12 UTC (permalink / raw)
To: Ba Jing; +Cc: will, mark.rutland, linux-arm-kernel, linux-kernel
On 12/10/2024 10:24 am, Ba Jing wrote:
> By reading the code, I found the marco CMN_HNP_PMU_EVENT_SEL
> is never referenced in the code. Just remove it.
Hmm, perhaps I got a little carried away implementing Mark's
recommendation in 88b63a82c84e ("perf/arm-cmn: Fix CCLA register
offset"), and the HN-P/CCLA_RNI case could have been left as it was
using CMN_HNP_PMU_EVENT_SEL. Either way, I think it's beneficial to keep
both definitions next to each other, so that it's at least visible from
the code alone (without having to resort to the CMN documentation) that
the two node types do have equivalent offsets and that combined case is
still not a bug.
Thanks,
Robin.
> Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
> ---
> drivers/perf/arm-cmn.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c
> index 397a46410f7c..37b62d0dcc06 100644
> --- a/drivers/perf/arm-cmn.c
> +++ b/drivers/perf/arm-cmn.c
> @@ -79,7 +79,6 @@
>
> /* Some types are designed to coexist with another device in the same node */
> #define CMN_CCLA_PMU_EVENT_SEL 0x008
> -#define CMN_HNP_PMU_EVENT_SEL 0x008
>
> /* DTMs live in the PMU space of XP registers */
> #define CMN_DTM_WPn(n) (0x1A0 + (n) * 0x18)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-14 14:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-12 9:24 [PATCH] perf: arm-cmn: remove unused macro Ba Jing
2024-10-14 14:12 ` Robin Murphy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®