mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] usb: dwc3: gadget: remove not used field dwc3_request.sg
@ 2024-12-19 15:12 ` Renjun Wang
  2024-12-20  6:39   ` Ahmad Fatoum
  2024-12-20  9:57   ` Selvarasu Ganesan
  0 siblings, 2 replies; 3+ messages in thread
From: Renjun Wang @ 2024-12-19 15:12 UTC (permalink / raw)
  To: Thinh.Nguyen; +Cc: gregkh, linux-usb, linux-kernel, Renjun Wang

Based on commit 61440628a4ff ("usb: dwc3: gadget: Cleanup SG handling"),
the field dwc3_request.sg is no longer needed and not used in any
other files, remove it.

Signed-off-by: Renjun Wang <renjunw0@foxmail.com>
---
 drivers/usb/dwc3/core.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index ee73789326bc..3be069c4520e 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -956,7 +956,6 @@ struct dwc3_request {
 	struct usb_request	request;
 	struct list_head	list;
 	struct dwc3_ep		*dep;
-	struct scatterlist	*sg;
 	struct scatterlist	*start_sg;
 
 	unsigned int		num_pending_sgs;
-- 
2.39.5


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] usb: dwc3: gadget: remove not used field dwc3_request.sg
  2024-12-19 15:12 ` [PATCH] usb: dwc3: gadget: remove not used field dwc3_request.sg Renjun Wang
@ 2024-12-20  6:39   ` Ahmad Fatoum
  2024-12-20  9:57   ` Selvarasu Ganesan
  1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2024-12-20  6:39 UTC (permalink / raw)
  To: Renjun Wang, Thinh.Nguyen; +Cc: gregkh, linux-usb, linux-kernel

On 19.12.24 16:12, Renjun Wang wrote:
> Based on commit 61440628a4ff ("usb: dwc3: gadget: Cleanup SG handling"),
> the field dwc3_request.sg is no longer needed and not used in any
> other files, remove it.
> 
> Signed-off-by: Renjun Wang <renjunw0@foxmail.com>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  drivers/usb/dwc3/core.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index ee73789326bc..3be069c4520e 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -956,7 +956,6 @@ struct dwc3_request {
>  	struct usb_request	request;
>  	struct list_head	list;
>  	struct dwc3_ep		*dep;
> -	struct scatterlist	*sg;
>  	struct scatterlist	*start_sg;
>  
>  	unsigned int		num_pending_sgs;


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] usb: dwc3: gadget: remove not used field dwc3_request.sg
  2024-12-19 15:12 ` [PATCH] usb: dwc3: gadget: remove not used field dwc3_request.sg Renjun Wang
  2024-12-20  6:39   ` Ahmad Fatoum
@ 2024-12-20  9:57   ` Selvarasu Ganesan
  1 sibling, 0 replies; 3+ messages in thread
From: Selvarasu Ganesan @ 2024-12-20  9:57 UTC (permalink / raw)
  To: Renjun Wang, Thinh.Nguyen; +Cc: gregkh, linux-usb, linux-kernel


On 12/19/2024 8:42 PM, Renjun Wang wrote:
> Based on commit 61440628a4ff ("usb: dwc3: gadget: Cleanup SG handling"),
> the field dwc3_request.sg is no longer needed and not used in any
> other files, remove it.
>
> Signed-off-by: Renjun Wang <renjunw0@foxmail.com>
> ---
>   drivers/usb/dwc3/core.h | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index ee73789326bc..3be069c4520e 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -956,7 +956,6 @@ struct dwc3_request {
>   	struct usb_request	request;
>   	struct list_head	list;
>   	struct dwc3_ep		*dep;
> -	struct scatterlist	*sg;
>   	struct scatterlist	*start_sg;
>   
>   	unsigned int		num_pending_sgs;
The same change has already been incorporated as part of the following 
commit.
commit: 686d4a2c26b49 ("usb: dwc3: remove unused sg struct member")

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-12-20  9:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20241219151351epcas5p14f6be94bf65085f86d0163615bb81ae7@epcas5p1.samsung.com>
2024-12-19 15:12 ` [PATCH] usb: dwc3: gadget: remove not used field dwc3_request.sg Renjun Wang
2024-12-20  6:39   ` Ahmad Fatoum
2024-12-20  9:57   ` Selvarasu Ganesan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®