From: Maaz Mombasawala <maaz.mombasawala@broadcom.com>
To: Fan Wu <12321260@zju.edu.cn>
Cc: Zack Rusin <zack.rusin@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/vmwgfx: uninstall the IRQ before freeing the command buffer manager on unload
Date: Tue, 21 Jul 2026 13:33:07 -0700 [thread overview]
Message-ID: <ce41837c-6305-4d31-809e-353ea6c2fcf8@broadcom.com> (raw)
In-Reply-To: <1F85D73C-FE3E-4838-9A54-0014AAE3913B@zju.edu.cn>
On 7/16/26 7:24 PM, Fan Wu wrote:
> Hi Maaz,
>
> Thanks for the review. I'll drop this reordering — keeping the IRQ alive
> for command-buffer processing during teardown is the right call.
>
> One question before I investigate further: is there an existing teardown
> invariant that guarantees an already-woken, but not yet run, CMDBUF or
> FENCE threaded handler (vmw_thread_fn) cannot remain pending once cman or
> fman teardown begins? If there is, I may well be chasing a non-issue, and
> I'd rather not propose an alternative that fights an invariant I'm missing.
>
> I'll re-check whether such a handler can outlive the current destroy
> sequence before suggesting anything further.
>
> Best,
> Fan Wu
>
You can drop this, the current teardown sequence processes things in
the correct order workqueue -> thread_fn -> irq.
--
Maaz Mombasawala <maaz.mombasawala@broadcom.com>
prev parent reply other threads:[~2026-07-21 20:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 9:45 Fan Wu
2026-07-15 23:39 ` Maaz Mombasawala
2026-07-17 2:24 ` Fan Wu
2026-07-21 20:33 ` Maaz Mombasawala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce41837c-6305-4d31-809e-353ea6c2fcf8@broadcom.com \
--to=maaz.mombasawala@broadcom.com \
--cc=12321260@zju.edu.cn \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zack.rusin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®