From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Hungyu Lin" <dennylin0707@gmail.com>, pkshih@realtek.com
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
rtl8821cerfe2@gmail.com, straube.linux@gmail.com,
"Hungyu Lin" <dennylin0707@gmail.com>
Subject: Re: [PATCH v2] wifi: rtw88: 8723b: avoid converting RX SNR twice
Date: Sat, 10 Oct 2026 11:14:32 +0000 [thread overview]
Message-ID: <ce5a3b408acc48642aa31866df39630aec7792f6@linux.dev> (raw)
In-Reply-To: <3c89d2ac770c659eacd532134c89b4725be9ab97.1791627615.git.dennylin0707@gmail.com>
October 10, 2026 at 12:47 PM, "Hungyu Lin" <dennylin0707@gmail.com mailto:dennylin0707@gmail.com?to=%22Hungyu%20Lin%22%20%3Cdennylin0707%40gmail.com%3E > wrote:
>
> rtw8723b_query_phy_status_ofdm() divides the SNR report by two when
> filling pkt_stat->rx_snr, then shifts it again when updating
> dm_info->rx_snr. This halves the SNR used for diagnostics and average
> statistics.
>
> Store the raw report in pkt_stat->rx_snr and convert it only when
> updating dm_info->rx_snr, as the other chip drivers do.
>
> Fixes: d726c70ce082 ("wifi: rtw88: 8723b: add the RTL8723B chip driver")
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
Ping-Ke should fixes tag be present here if this commit isn't in
mainline yet?
> ---
> Changes in v2:
> - Store the raw SNR report in pkt_stat->rx_snr and keep the shift when
> updating dm_info->rx_snr.
>
> drivers/net/wireless/realtek/rtw88/rtw8723b.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723b.c b/drivers/net/wireless/realtek/rtw88/rtw8723b.c
> index 8bb9c03d769c..18bd2b108ccb 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8723b.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8723b.c
> @@ -1280,7 +1280,7 @@ static void rtw8723b_query_phy_status_ofdm(struct rtw_dev *rtwdev, void *phy_raw
> pkt_stat->rx_power[RF_PATH_A] = (val_s8 * 2) - 110;
>
> pkt_stat->rssi = rtw_phy_rf_power_2_rssi(pkt_stat->rx_power, 1);
> - pkt_stat->rx_snr[RF_PATH_A] = (s8)(phy_status->path_rxsnr[RF_PATH_A] / 2);
> + pkt_stat->rx_snr[RF_PATH_A] = phy_status->path_rxsnr[RF_PATH_A];
>
> /* signal power reported by HW */
> val_s8 = phy_status->cck_sig_qual_ofdm_pwdb_all >> 1;
>
Either way change looks good to me.
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
prev parent reply other threads:[~2026-10-10 11:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 10:47 Hungyu Lin
2026-10-10 11:14 ` Luka Gejak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce5a3b408acc48642aa31866df39630aec7792f6@linux.dev \
--to=luka.gejak@linux.dev \
--cc=dennylin0707@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=rtl8821cerfe2@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®