From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Danilo Krummrich <danilokrummrich@dk-develop.de>,
dmitry.torokhov@gmail.com, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: linus.walleij@linaro.org
Subject: Re: [PATCH 2/2] input: ps2-gpio: enforce and document open drain
Date: Mon, 14 Feb 2022 22:50:21 +0100 [thread overview]
Message-ID: <ce5ccbbc-0419-ae3d-5ab1-f8985cb7e792@canonical.com> (raw)
In-Reply-To: <20220211233137.99624-3-danilokrummrich@dk-develop.de>
On 12/02/2022 00:31, Danilo Krummrich wrote:
> The PS/2 bus defines the data and clock line be open drain, therefore
> document this in the dt-binding and enforce the particular flag in the
> driver.
>
> Without enforcing to flag at least the clock gpio as open drain we run
> into the following warning:
>
> WARNING: CPU: 1 PID: 40 at drivers/gpio/gpiolib.c:3175 gpiochip_enable_irq+0x54/0x90
>
> gpiochip_enable_irq() warns on a GPIO being configured as output and
> using IRQ without being flagged as open drain.
>
> Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
> ---
> .../devicetree/bindings/serio/ps2-gpio.yaml | 14 ++++++++++----
> drivers/input/serio/ps2-gpio.c | 9 +++++++--
> 2 files changed, 17 insertions(+), 6 deletions(-)
>
Bindings as separate patch, please.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-02-14 21:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 23:31 dt-bindings: ps2-gpio: convert binding to json-schema Danilo Krummrich
2022-02-11 23:31 ` [PATCH 1/2] " Danilo Krummrich
2022-02-14 21:49 ` Krzysztof Kozlowski
2022-02-14 22:53 ` Danilo Krummrich
2022-02-15 15:22 ` Rob Herring
2022-02-11 23:31 ` [PATCH 2/2] input: ps2-gpio: enforce and document open drain Danilo Krummrich
2022-02-14 21:50 ` Krzysztof Kozlowski [this message]
2022-02-14 22:42 ` Danilo Krummrich
2022-02-15 7:05 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce5ccbbc-0419-ae3d-5ab1-f8985cb7e792@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=danilokrummrich@dk-develop.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®