mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: [PATCH] clk/meson: Complete exception handling in meson8b_clkc_init_common()
@ 2020-04-29 13:30 Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-04-29 13:30 UTC (permalink / raw)
  To: Bernard Zhao, linux-amlogic, linux-arm-kernel, linux-clk
  Cc: linux-kernel, kernel-janitors, opensource.kernel, Jerome Brunet,
	Kevin Hilman, Michael Turquette, Neil Armstrong, Stephen Boyd

> In common init function, when run into err branch, we didn`t
> use kfree to release kzmalloc area, this may bring in memleak

* I suggest to improve also this change description.

* Please move the resource release functions to end of
  the function “meson8b_clkc_init_common” here.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=96c9a7802af7d500a582d89a8b864584fe878c1b#n450

* Will the tag “Fixes” be relevant then for the completed exception handling?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=96c9a7802af7d500a582d89a8b864584fe878c1b#n183

Regards,
Markus

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-04-29 13:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-29 13:30 [PATCH] clk/meson: Complete exception handling in meson8b_clkc_init_common() Markus Elfring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®