mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Riesch <michael.riesch@collabora.com>
To: Matthias Fend <matthias.fend@emfend.at>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: imx415: Request the sensor clock without a name
Date: Wed, 14 May 2025 18:16:11 +0200	[thread overview]
Message-ID: <ced4b6b2-69c4-4d84-ab8b-7360d2b80ebb@collabora.com> (raw)
In-Reply-To: <20250514-imx415-v1-1-bb29fa622bb1@emfend.at>

Hi Matthias,

Thanks for giving this patch a spin.

FTR some context here:
https://lore.kernel.org/all/20241130141716.1007115-1-matthias.fend@emfend.at/

On 5/14/25 12:51, Matthias Fend wrote:
> Request the sensor clock without specifying a name so that the driver
> behaves as described in the imx415 bindings.
> 
> Signed-off-by: Matthias Fend <matthias.fend@emfend.at>

Reviewed-by: Michael Riesch <michael.riesch@collabora.com>

Thanks and best regards,
Michael

> ---
>  drivers/media/i2c/imx415.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c
> index 9f37779bd6111f434c198ad1cf70c14b80724042..278e743646ea15819d5a79577e786b47c259dbfa 100644
> --- a/drivers/media/i2c/imx415.c
> +++ b/drivers/media/i2c/imx415.c
> @@ -1251,7 +1251,7 @@ static int imx415_parse_hw_config(struct imx415 *sensor)
>  		return dev_err_probe(sensor->dev, PTR_ERR(sensor->reset),
>  				     "failed to get reset GPIO\n");
>  
> -	sensor->clk = devm_clk_get(sensor->dev, "inck");
> +	sensor->clk = devm_clk_get(sensor->dev, NULL);
>  	if (IS_ERR(sensor->clk))
>  		return dev_err_probe(sensor->dev, PTR_ERR(sensor->clk),
>  				     "failed to get clock\n");
> 
> ---
> base-commit: 9f35e33144ae5377d6a8de86dd3bd4d995c6ac65
> change-id: 20250514-imx415-c65889e55211
> 
> Best regards,


      parent reply	other threads:[~2025-05-14 16:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-14 10:51 Matthias Fend
2025-05-14 12:42 ` Jai Luthra
2025-05-14 16:16 ` Michael Riesch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ced4b6b2-69c4-4d84-ab8b-7360d2b80ebb@collabora.com \
    --to=michael.riesch@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=matthias.fend@emfend.at \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®