[PATCH] media: i2c: imx415: Request the sensor clock without a name

[PATCH] media: i2c: imx415: Request the sensor clock without a name

[Matthias Fend]

Request the sensor clock without specifying a name so that the driver
behaves as described in the imx415 bindings.

Signed-off-by: Matthias Fend <matthias.fend@emfend.at>
---
 drivers/media/i2c/imx415.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c
index 9f37779bd6111f434c198ad1cf70c14b80724042..278e743646ea15819d5a79577e786b47c259dbfa 100644
--- a/drivers/media/i2c/imx415.c
+++ b/drivers/media/i2c/imx415.c
@@ -1251,7 +1251,7 @@ static int imx415_parse_hw_config(struct imx415 *sensor)
 		return dev_err_probe(sensor->dev, PTR_ERR(sensor->reset),
 				     "failed to get reset GPIO\n");
 
-	sensor->clk = devm_clk_get(sensor->dev, "inck");
+	sensor->clk = devm_clk_get(sensor->dev, NULL);
 	if (IS_ERR(sensor->clk))
 		return dev_err_probe(sensor->dev, PTR_ERR(sensor->clk),
 				     "failed to get clock\n");

---
base-commit: 9f35e33144ae5377d6a8de86dd3bd4d995c6ac65
change-id: 20250514-imx415-c65889e55211

Best regards,
-- 
Matthias Fend <matthias.fend@emfend.at>

Re: [PATCH] media: i2c: imx415: Request the sensor clock without a name

[Jai Luthra]

[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]

Hi Matthias,

Thanks for the patch.

Quoting Matthias Fend (2025-05-14 12:51:01)
> Request the sensor clock without specifying a name so that the driver
> behaves as described in the imx415 bindings.
> 
> Signed-off-by: Matthias Fend <matthias.fend@emfend.at>

Reviewed-by: Jai Luthra <jai.luthra@ideasonboard.com>

> ---
>  drivers/media/i2c/imx415.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c
> index 9f37779bd6111f434c198ad1cf70c14b80724042..278e743646ea15819d5a79577e786b47c259dbfa 100644
> --- a/drivers/media/i2c/imx415.c
> +++ b/drivers/media/i2c/imx415.c
> @@ -1251,7 +1251,7 @@ static int imx415_parse_hw_config(struct imx415 *sensor)
>                 return dev_err_probe(sensor->dev, PTR_ERR(sensor->reset),
>                                      "failed to get reset GPIO\n");
>  
> -       sensor->clk = devm_clk_get(sensor->dev, "inck");
> +       sensor->clk = devm_clk_get(sensor->dev, NULL);
>         if (IS_ERR(sensor->clk))
>                 return dev_err_probe(sensor->dev, PTR_ERR(sensor->clk),
>                                      "failed to get clock\n");
> 
> ---
> base-commit: 9f35e33144ae5377d6a8de86dd3bd4d995c6ac65
> change-id: 20250514-imx415-c65889e55211
> 
> Best regards,
> -- 
> Matthias Fend <matthias.fend@emfend.at>
>

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEETeDYGOXVdejUWq/FQ96R+SSacUUFAmgkj9AACgkQQ96R+SSa
cUUBBQ//WCo/WnrJIOXDyUFiyYWlz7WpTIjN7DMRKbXFaDseWL8Za6KijHU10hbK
6B/H+rVGOi5OnwxyoxD0EmqxYldWitIu17nh0X5SShg+lq+ccRBmcgKobBhsTRtb
0zzAo1ENDlePYc+RqtmTLowVc1kmeNDpI9B2uk84pfq1sqTTM2LOrGHnULi3h7vS
hPNaMX+dH4E+Wo8u7WlNDqukPIAUd71fvTN8v+R55OcNM5AnJE0WuT3uPAbmLFgr
9S1srWpnUhSL7XT/jOP+R5YbpbxtRqiYFfdjwU//JftGBlQmizSZ649kY7dUmeXZ
+WzgClE6EXxEDyq1TOIK49pyBZCIgZSMwGop2wQJ+3wMlxEW+iAKUtiuTz5RYvc/
y5Pv/PImh/GdZCMhrDI7gJ1EyFdEFOjv8569qao6QhmM4J4z14x4esIKWY05kyhF
BrCc/AvdRKPedG9hHVZi1LkQgMHHCGnRUv3QNi07ad+1VOay2d7kNGzKs0764SpP
yyJHk9ugv4wrOPnLb1Z061f0CveKIcY390h8cbaoobuFDtYJMyAP5nwu3aR3fpMa
D+7s02a5ohyyAqJJtsCAM/U+oGhw+YBmUxuZcEfMS4J0kt3MgXziNd32WvjVm1BY
lkvSN6H5sdeGIW6AgMAOOz5ul/AeSi8jCjLL6I1uLWOiTy8WSF4=
=5KmA
-----END PGP SIGNATURE-----

Re: [PATCH] media: i2c: imx415: Request the sensor clock without a name

[Michael Riesch]

Hi Matthias,

Thanks for giving this patch a spin.

FTR some context here:
https://lore.kernel.org/all/20241130141716.1007115-1-matthias.fend@emfend.at/

On 5/14/25 12:51, Matthias Fend wrote:
> Request the sensor clock without specifying a name so that the driver
> behaves as described in the imx415 bindings.
> 
> Signed-off-by: Matthias Fend <matthias.fend@emfend.at>

Reviewed-by: Michael Riesch <michael.riesch@collabora.com>

Thanks and best regards,
Michael

> ---
>  drivers/media/i2c/imx415.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c
> index 9f37779bd6111f434c198ad1cf70c14b80724042..278e743646ea15819d5a79577e786b47c259dbfa 100644
> --- a/drivers/media/i2c/imx415.c
> +++ b/drivers/media/i2c/imx415.c
> @@ -1251,7 +1251,7 @@ static int imx415_parse_hw_config(struct imx415 *sensor)
>  		return dev_err_probe(sensor->dev, PTR_ERR(sensor->reset),
>  				     "failed to get reset GPIO\n");
>  
> -	sensor->clk = devm_clk_get(sensor->dev, "inck");
> +	sensor->clk = devm_clk_get(sensor->dev, NULL);
>  	if (IS_ERR(sensor->clk))
>  		return dev_err_probe(sensor->dev, PTR_ERR(sensor->clk),
>  				     "failed to get clock\n");
> 
> ---
> base-commit: 9f35e33144ae5377d6a8de86dd3bd4d995c6ac65
> change-id: 20250514-imx415-c65889e55211
> 
> Best regards,