mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vasant Hegde <vasant.hegde@amd.com>
To: Chen Ni <nichen@iscas.ac.cn>,
	joro@8bytes.org, suravee.suthikulpanit@amd.com, will@kernel.org,
	robin.murphy@arm.com
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/amd: Convert comma to semicolon
Date: Wed, 4 Sep 2024 12:07:23 +0530	[thread overview]
Message-ID: <cedb5352-8298-4edd-9212-37952cf879b2@amd.com> (raw)
In-Reply-To: <20240903072518.780705-1-nichen@iscas.ac.cn>

Hi Chen,

On 9/3/2024 12:55 PM, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.

Thanks for the fix. Jason already have same fix as part of his io-pgtable
refactoring series [1].

[1]
https://lore.kernel.org/linux-iommu/0-v2-831cdc4d00f3+1a315-amd_iopgtbl_jgg@nvidia.com/T/#m79d88869627b02eed4b954d31c8b96090f3e0b5c

-Vasant

> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/iommu/amd/io_pgtable_v2.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iommu/amd/io_pgtable_v2.c b/drivers/iommu/amd/io_pgtable_v2.c
> index 664e91c88748..67f1fd8fab07 100644
> --- a/drivers/iommu/amd/io_pgtable_v2.c
> +++ b/drivers/iommu/amd/io_pgtable_v2.c
> @@ -373,9 +373,9 @@ static struct io_pgtable *v2_alloc_pgtable(struct io_pgtable_cfg *cfg, void *coo
>  	pgtable->iop.ops.unmap_pages  = iommu_v2_unmap_pages;
>  	pgtable->iop.ops.iova_to_phys = iommu_v2_iova_to_phys;
>  
> -	cfg->pgsize_bitmap = AMD_IOMMU_PGSIZES_V2,
> -	cfg->ias           = ias,
> -	cfg->oas           = IOMMU_OUT_ADDR_BIT_SIZE,
> +	cfg->pgsize_bitmap = AMD_IOMMU_PGSIZES_V2;
> +	cfg->ias           = ias;
> +	cfg->oas           = IOMMU_OUT_ADDR_BIT_SIZE;
>  	cfg->tlb           = &v2_flush_ops;
>  
>  	return &pgtable->iop;


  reply	other threads:[~2024-09-04  6:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03  7:25 Chen Ni
2024-09-04  6:37 ` Vasant Hegde [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-07-16  7:25 Chen Ni
2024-07-18  3:20 ` Suthikulpanit, Suravee
2024-07-23 16:33 ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cedb5352-8298-4edd-9212-37952cf879b2@amd.com \
    --to=vasant.hegde@amd.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nichen@iscas.ac.cn \
    --cc=robin.murphy@arm.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®