mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] iommu/amd: Convert comma to semicolon
@ 2024-09-03  7:25 Chen Ni
  2024-09-04  6:37 ` Vasant Hegde
  0 siblings, 1 reply; 5+ messages in thread
From: Chen Ni @ 2024-09-03  7:25 UTC (permalink / raw)
  To: joro, suravee.suthikulpanit, will, robin.murphy
  Cc: iommu, linux-kernel, Chen Ni

Replace a comma between expression statements by a semicolon.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/iommu/amd/io_pgtable_v2.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/iommu/amd/io_pgtable_v2.c b/drivers/iommu/amd/io_pgtable_v2.c
index 664e91c88748..67f1fd8fab07 100644
--- a/drivers/iommu/amd/io_pgtable_v2.c
+++ b/drivers/iommu/amd/io_pgtable_v2.c
@@ -373,9 +373,9 @@ static struct io_pgtable *v2_alloc_pgtable(struct io_pgtable_cfg *cfg, void *coo
 	pgtable->iop.ops.unmap_pages  = iommu_v2_unmap_pages;
 	pgtable->iop.ops.iova_to_phys = iommu_v2_iova_to_phys;
 
-	cfg->pgsize_bitmap = AMD_IOMMU_PGSIZES_V2,
-	cfg->ias           = ias,
-	cfg->oas           = IOMMU_OUT_ADDR_BIT_SIZE,
+	cfg->pgsize_bitmap = AMD_IOMMU_PGSIZES_V2;
+	cfg->ias           = ias;
+	cfg->oas           = IOMMU_OUT_ADDR_BIT_SIZE;
 	cfg->tlb           = &v2_flush_ops;
 
 	return &pgtable->iop;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] iommu/amd: Convert comma to semicolon
  2024-09-03  7:25 [PATCH] iommu/amd: Convert comma to semicolon Chen Ni
@ 2024-09-04  6:37 ` Vasant Hegde
  0 siblings, 0 replies; 5+ messages in thread
From: Vasant Hegde @ 2024-09-04  6:37 UTC (permalink / raw)
  To: Chen Ni, joro, suravee.suthikulpanit, will, robin.murphy
  Cc: iommu, linux-kernel

Hi Chen,

On 9/3/2024 12:55 PM, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.

Thanks for the fix. Jason already have same fix as part of his io-pgtable
refactoring series [1].

[1]
https://lore.kernel.org/linux-iommu/0-v2-831cdc4d00f3+1a315-amd_iopgtbl_jgg@nvidia.com/T/#m79d88869627b02eed4b954d31c8b96090f3e0b5c

-Vasant

> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/iommu/amd/io_pgtable_v2.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iommu/amd/io_pgtable_v2.c b/drivers/iommu/amd/io_pgtable_v2.c
> index 664e91c88748..67f1fd8fab07 100644
> --- a/drivers/iommu/amd/io_pgtable_v2.c
> +++ b/drivers/iommu/amd/io_pgtable_v2.c
> @@ -373,9 +373,9 @@ static struct io_pgtable *v2_alloc_pgtable(struct io_pgtable_cfg *cfg, void *coo
>  	pgtable->iop.ops.unmap_pages  = iommu_v2_unmap_pages;
>  	pgtable->iop.ops.iova_to_phys = iommu_v2_iova_to_phys;
>  
> -	cfg->pgsize_bitmap = AMD_IOMMU_PGSIZES_V2,
> -	cfg->ias           = ias,
> -	cfg->oas           = IOMMU_OUT_ADDR_BIT_SIZE,
> +	cfg->pgsize_bitmap = AMD_IOMMU_PGSIZES_V2;
> +	cfg->ias           = ias;
> +	cfg->oas           = IOMMU_OUT_ADDR_BIT_SIZE;
>  	cfg->tlb           = &v2_flush_ops;
>  
>  	return &pgtable->iop;


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] iommu/amd: Convert comma to semicolon
  2024-07-16  7:25 Chen Ni
  2024-07-18  3:20 ` Suthikulpanit, Suravee
@ 2024-07-23 16:33 ` Will Deacon
  1 sibling, 0 replies; 5+ messages in thread
From: Will Deacon @ 2024-07-23 16:33 UTC (permalink / raw)
  To: joro, suravee.suthikulpanit, robin.murphy, Chen Ni
  Cc: catalin.marinas, kernel-team, Will Deacon, iommu, linux-kernel

On Tue, 16 Jul 2024 15:25:45 +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> 

Applied to iommu (next), thanks!

[1/1] iommu/amd: Convert comma to semicolon
      https://git.kernel.org/iommu/c/86c5eac3c4c4

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] iommu/amd: Convert comma to semicolon
  2024-07-16  7:25 Chen Ni
@ 2024-07-18  3:20 ` Suthikulpanit, Suravee
  2024-07-23 16:33 ` Will Deacon
  1 sibling, 0 replies; 5+ messages in thread
From: Suthikulpanit, Suravee @ 2024-07-18  3:20 UTC (permalink / raw)
  To: Chen Ni, joro, will, robin.murphy; +Cc: iommu, linux-kernel

On 7/16/2024 2:25 PM, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Fixes: c9b258c6be09 ("iommu/amd: Prepare for generic IO page table framework")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>   drivers/iommu/amd/io_pgtable.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iommu/amd/io_pgtable.c b/drivers/iommu/amd/io_pgtable.c
> index 9d9a7fde59e7..1074ee25064d 100644
> --- a/drivers/iommu/amd/io_pgtable.c
> +++ b/drivers/iommu/amd/io_pgtable.c
> @@ -588,9 +588,9 @@ static struct io_pgtable *v1_alloc_pgtable(struct io_pgtable_cfg *cfg, void *coo
>   {
>   	struct amd_io_pgtable *pgtable = io_pgtable_cfg_to_data(cfg);
>   
> -	cfg->pgsize_bitmap  = AMD_IOMMU_PGSIZES,
> -	cfg->ias            = IOMMU_IN_ADDR_BIT_SIZE,
> -	cfg->oas            = IOMMU_OUT_ADDR_BIT_SIZE,
> +	cfg->pgsize_bitmap  = AMD_IOMMU_PGSIZES;
> +	cfg->ias            = IOMMU_IN_ADDR_BIT_SIZE;
> +	cfg->oas            = IOMMU_OUT_ADDR_BIT_SIZE;
>   	cfg->tlb            = &v1_flush_ops;
>   
>   	pgtable->iop.ops.map_pages    = iommu_v1_map_pages;

Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>

Thanks,
Suravee

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] iommu/amd: Convert comma to semicolon
@ 2024-07-16  7:25 Chen Ni
  2024-07-18  3:20 ` Suthikulpanit, Suravee
  2024-07-23 16:33 ` Will Deacon
  0 siblings, 2 replies; 5+ messages in thread
From: Chen Ni @ 2024-07-16  7:25 UTC (permalink / raw)
  To: joro, suravee.suthikulpanit, will, robin.murphy
  Cc: iommu, linux-kernel, Chen Ni

Replace a comma between expression statements by a semicolon.

Fixes: c9b258c6be09 ("iommu/amd: Prepare for generic IO page table framework")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/iommu/amd/io_pgtable.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/iommu/amd/io_pgtable.c b/drivers/iommu/amd/io_pgtable.c
index 9d9a7fde59e7..1074ee25064d 100644
--- a/drivers/iommu/amd/io_pgtable.c
+++ b/drivers/iommu/amd/io_pgtable.c
@@ -588,9 +588,9 @@ static struct io_pgtable *v1_alloc_pgtable(struct io_pgtable_cfg *cfg, void *coo
 {
 	struct amd_io_pgtable *pgtable = io_pgtable_cfg_to_data(cfg);
 
-	cfg->pgsize_bitmap  = AMD_IOMMU_PGSIZES,
-	cfg->ias            = IOMMU_IN_ADDR_BIT_SIZE,
-	cfg->oas            = IOMMU_OUT_ADDR_BIT_SIZE,
+	cfg->pgsize_bitmap  = AMD_IOMMU_PGSIZES;
+	cfg->ias            = IOMMU_IN_ADDR_BIT_SIZE;
+	cfg->oas            = IOMMU_OUT_ADDR_BIT_SIZE;
 	cfg->tlb            = &v1_flush_ops;
 
 	pgtable->iop.ops.map_pages    = iommu_v1_map_pages;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-09-04  6:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-03  7:25 [PATCH] iommu/amd: Convert comma to semicolon Chen Ni
2024-09-04  6:37 ` Vasant Hegde
  -- strict thread matches above, loose matches on Subject: below --
2024-07-16  7:25 Chen Ni
2024-07-18  3:20 ` Suthikulpanit, Suravee
2024-07-23 16:33 ` Will Deacon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®