* [PATCH] mailbox: imx: fix RST channel support
@ 2022-08-29 3:37 Peng Fan (OSS)
2022-08-30 1:50 ` Liu Ying
2022-09-14 0:36 ` Peng Fan
0 siblings, 2 replies; 4+ messages in thread
From: Peng Fan (OSS) @ 2022-08-29 3:37 UTC (permalink / raw)
To: jassisinghbrar, shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, linux-kernel, linux-arm-kernel,
Peng Fan, Liu Ying
From: Peng Fan <peng.fan@nxp.com>
Because IMX_MU_xCR_MAX was increased to 5, some mu cfgs were not updated
to include the CR register. Add the missed CR register to xcr array.
Fixes: 3d38ac9c40bd ("mailbox: imx: fix RST channel support")
Reported-by: Liu Ying <victor.liu@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V1:
Tested on i.MX93/8ULP/8QXP/7ULP
drivers/mailbox/imx-mailbox.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
index 02922073c9ef..20f2ec880ad6 100644
--- a/drivers/mailbox/imx-mailbox.c
+++ b/drivers/mailbox/imx-mailbox.c
@@ -904,7 +904,7 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx7ulp = {
.xTR = 0x20,
.xRR = 0x40,
.xSR = {0x60, 0x60, 0x60, 0x60},
- .xCR = {0x64, 0x64, 0x64, 0x64},
+ .xCR = {0x64, 0x64, 0x64, 0x64, 0x64},
};
static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = {
@@ -927,7 +927,7 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp_s4 = {
.xTR = 0x200,
.xRR = 0x280,
.xSR = {0xC, 0x118, 0x124, 0x12C},
- .xCR = {0x110, 0x114, 0x120, 0x128},
+ .xCR = {0x8, 0x110, 0x114, 0x120, 0x128},
};
static const struct imx_mu_dcfg imx_mu_cfg_imx93_s4 = {
@@ -938,7 +938,7 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx93_s4 = {
.xTR = 0x200,
.xRR = 0x280,
.xSR = {0xC, 0x118, 0x124, 0x12C},
- .xCR = {0x110, 0x114, 0x120, 0x128},
+ .xCR = {0x8, 0x110, 0x114, 0x120, 0x128},
};
static const struct imx_mu_dcfg imx_mu_cfg_imx8_scu = {
@@ -949,7 +949,7 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8_scu = {
.xTR = 0x0,
.xRR = 0x10,
.xSR = {0x20, 0x20, 0x20, 0x20},
- .xCR = {0x24, 0x24, 0x24, 0x24},
+ .xCR = {0x24, 0x24, 0x24, 0x24, 0x24},
};
static const struct imx_mu_dcfg imx_mu_cfg_imx8_seco = {
@@ -960,7 +960,7 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8_seco = {
.xTR = 0x0,
.xRR = 0x10,
.xSR = {0x20, 0x20, 0x20, 0x20},
- .xCR = {0x24, 0x24, 0x24, 0x24},
+ .xCR = {0x24, 0x24, 0x24, 0x24, 0x24},
};
static const struct of_device_id imx_mu_dt_ids[] = {
--
2.37.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mailbox: imx: fix RST channel support
2022-08-29 3:37 [PATCH] mailbox: imx: fix RST channel support Peng Fan (OSS)
@ 2022-08-30 1:50 ` Liu Ying
2022-09-14 0:36 ` Peng Fan
1 sibling, 0 replies; 4+ messages in thread
From: Liu Ying @ 2022-08-30 1:50 UTC (permalink / raw)
To: Peng Fan (OSS), jassisinghbrar, shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, linux-kernel, linux-arm-kernel, Peng Fan
On Mon, 2022-08-29 at 11:37 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Because IMX_MU_xCR_MAX was increased to 5, some mu cfgs were not updated
> to include the CR register. Add the missed CR register to xcr array.
>
> Fixes: 3d38ac9c40bd ("mailbox: imx: fix RST channel support")
> Reported-by: Liu Ying <victor.liu@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>
> V1:
> Tested on i.MX93/8ULP/8QXP/7ULP
>
> drivers/mailbox/imx-mailbox.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Tested-by: Liu Ying <victor.liu@nxp.com> # i.MX8qm/qxp MEK boards boot
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mailbox: imx: fix RST channel support
2022-08-29 3:37 [PATCH] mailbox: imx: fix RST channel support Peng Fan (OSS)
2022-08-30 1:50 ` Liu Ying
@ 2022-09-14 0:36 ` Peng Fan
2022-09-16 21:37 ` Jassi Brar
1 sibling, 1 reply; 4+ messages in thread
From: Peng Fan @ 2022-09-14 0:36 UTC (permalink / raw)
To: jassisinghbrar, shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, linux-kernel, linux-arm-kernel,
Peng Fan, Liu Ying
Hi Jassi,
On 8/29/2022 11:37 AM, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Because IMX_MU_xCR_MAX was increased to 5, some mu cfgs were not updated
> to include the CR register. Add the missed CR register to xcr array.
>
> Fixes: 3d38ac9c40bd ("mailbox: imx: fix RST channel support")
> Reported-by: Liu Ying <victor.liu@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Would you pick up this patch for 6.0 release?
Thanks,
Peng.
> ---
>
> V1:
> Tested on i.MX93/8ULP/8QXP/7ULP
>
> drivers/mailbox/imx-mailbox.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> index 02922073c9ef..20f2ec880ad6 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -904,7 +904,7 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx7ulp = {
> .xTR = 0x20,
> .xRR = 0x40,
> .xSR = {0x60, 0x60, 0x60, 0x60},
> - .xCR = {0x64, 0x64, 0x64, 0x64},
> + .xCR = {0x64, 0x64, 0x64, 0x64, 0x64},
> };
>
> static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = {
> @@ -927,7 +927,7 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp_s4 = {
> .xTR = 0x200,
> .xRR = 0x280,
> .xSR = {0xC, 0x118, 0x124, 0x12C},
> - .xCR = {0x110, 0x114, 0x120, 0x128},
> + .xCR = {0x8, 0x110, 0x114, 0x120, 0x128},
> };
>
> static const struct imx_mu_dcfg imx_mu_cfg_imx93_s4 = {
> @@ -938,7 +938,7 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx93_s4 = {
> .xTR = 0x200,
> .xRR = 0x280,
> .xSR = {0xC, 0x118, 0x124, 0x12C},
> - .xCR = {0x110, 0x114, 0x120, 0x128},
> + .xCR = {0x8, 0x110, 0x114, 0x120, 0x128},
> };
>
> static const struct imx_mu_dcfg imx_mu_cfg_imx8_scu = {
> @@ -949,7 +949,7 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8_scu = {
> .xTR = 0x0,
> .xRR = 0x10,
> .xSR = {0x20, 0x20, 0x20, 0x20},
> - .xCR = {0x24, 0x24, 0x24, 0x24},
> + .xCR = {0x24, 0x24, 0x24, 0x24, 0x24},
> };
>
> static const struct imx_mu_dcfg imx_mu_cfg_imx8_seco = {
> @@ -960,7 +960,7 @@ static const struct imx_mu_dcfg imx_mu_cfg_imx8_seco = {
> .xTR = 0x0,
> .xRR = 0x10,
> .xSR = {0x20, 0x20, 0x20, 0x20},
> - .xCR = {0x24, 0x24, 0x24, 0x24},
> + .xCR = {0x24, 0x24, 0x24, 0x24, 0x24},
> };
>
> static const struct of_device_id imx_mu_dt_ids[] = {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mailbox: imx: fix RST channel support
2022-09-14 0:36 ` Peng Fan
@ 2022-09-16 21:37 ` Jassi Brar
0 siblings, 0 replies; 4+ messages in thread
From: Jassi Brar @ 2022-09-16 21:37 UTC (permalink / raw)
To: Peng Fan
Cc: shawnguo, s.hauer, kernel, festevam, linux-imx, linux-kernel,
linux-arm-kernel, Peng Fan, Liu Ying
On Tue, Sep 13, 2022 at 7:36 PM Peng Fan <peng.fan@oss.nxp.com> wrote:
>
> Hi Jassi,
>
> On 8/29/2022 11:37 AM, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Because IMX_MU_xCR_MAX was increased to 5, some mu cfgs were not updated
> > to include the CR register. Add the missed CR register to xcr array.
> >
> > Fixes: 3d38ac9c40bd ("mailbox: imx: fix RST channel support")
> > Reported-by: Liu Ying <victor.liu@nxp.com>
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
>
Fixes: 3d38ac9c40bd ("mailbox: imx: fix RST channel support") seems wrong.
-j
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-16 21:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-29 3:37 [PATCH] mailbox: imx: fix RST channel support Peng Fan (OSS)
2022-08-30 1:50 ` Liu Ying
2022-09-14 0:36 ` Peng Fan
2022-09-16 21:37 ` Jassi Brar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®