mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Kaiwei Liu <kaiwei.liu@unisoc.com>, Vinod Koul <vkoul@kernel.org>,
	Orson Zhai <orsonzhai@gmail.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
	kaiwei liu <liukaiwei086@gmail.com>,
	Wenming Wu <wenming.wu@unisoc.com>
Subject: Re: [PATCH 1/5] dma: delect redundant parameter for dma driver function
Date: Mon, 7 Aug 2023 15:43:07 +0800	[thread overview]
Message-ID: <cef5d9ad-7b29-f09f-f88b-2fd78451165b@linux.alibaba.com> (raw)
In-Reply-To: <20230807051907.2713-1-kaiwei.liu@unisoc.com>



On 8/7/2023 1:19 PM, Kaiwei Liu wrote:
> The parameter *sdesc in function sprd_dma_check_trans_done is not
> used, so here delect redundant parameter.
> 
> Signed-off-by: Kaiwei Liu <kaiwei.liu@unisoc.com>

The subject line should be "dmaengine: sprd: xxx", and please also 
change all your following patches.

With subject line fixed, you can add:
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

> ---
>   drivers/dma/sprd-dma.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
> index 2b639adb48ba..20c3cb1ef2f5 100644
> --- a/drivers/dma/sprd-dma.c
> +++ b/drivers/dma/sprd-dma.c
> @@ -572,8 +572,7 @@ static void sprd_dma_stop(struct sprd_dma_chn *schan)
>   	schan->cur_desc = NULL;
>   }
>   
> -static bool sprd_dma_check_trans_done(struct sprd_dma_desc *sdesc,
> -				      enum sprd_dma_int_type int_type,
> +static bool sprd_dma_check_trans_done(enum sprd_dma_int_type int_type,
>   				      enum sprd_dma_req_mode req_mode)
>   {
>   	if (int_type == SPRD_DMA_NO_INT)
> @@ -619,8 +618,7 @@ static irqreturn_t dma_irq_handle(int irq, void *dev_id)
>   			vchan_cyclic_callback(&sdesc->vd);
>   		} else {
>   			/* Check if the dma request descriptor is done. */
> -			trans_done = sprd_dma_check_trans_done(sdesc, int_type,
> -							       req_type);
> +			trans_done = sprd_dma_check_trans_done(int_type, req_type);
>   			if (trans_done == true) {
>   				vchan_cookie_complete(&sdesc->vd);
>   				schan->cur_desc = NULL;

  reply	other threads:[~2023-08-07  7:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-07  5:19 Kaiwei Liu
2023-08-07  7:43 ` Baolin Wang [this message]
2023-08-07  8:53 ` Chunyan Zhang
  -- strict thread matches above, loose matches on Subject: below --
2023-08-07  5:07 Kaiwei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cef5d9ad-7b29-f09f-f88b-2fd78451165b@linux.alibaba.com \
    --to=baolin.wang@linux.alibaba.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=kaiwei.liu@unisoc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liukaiwei086@gmail.com \
    --cc=orsonzhai@gmail.com \
    --cc=vkoul@kernel.org \
    --cc=wenming.wu@unisoc.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®