* [PATCH v4 1/2] arm64: dts: qcom: talos: Add graph port placeholders for USB Type-C muxing
2026-11-16 13:05 [PATCH v4 0/2] arm64: dts: qcom: talos-lyra-evk: Wire up CYPD6129 USB Type-C ports Akash Kumar
@ 2026-11-16 13:05 ` Akash Kumar
2026-11-16 13:05 ` [PATCH v4 2/2] arm64: dts: qcom: talos-lyra-evk: Wire up CYPD6129 USB Type-C ports Akash Kumar
2026-11-17 10:55 ` [PATCH v4 0/2] " Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Akash Kumar @ 2026-11-16 13:05 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Dmitry Baryshkov, Abel Vesa, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
From: Akash Kumar <akakum@qti.qualcomm.com>
Add empty port/endpoint nodes on the primary USB QMP PHY (usb_qmpphy)
and the usb_1/usb_2 dwc3 controllers, along with orientation-switch on
the PHY. These placeholders let board files wire up a USB-C PD
controller's HS/SS endpoints directly via
&label { remote-endpoint = <...>; }; instead of redeclaring the
port/ports structure on the shared nodes.
Signed-off-by: Akash Kumar <akakum@qti.qualcomm.com>
---
arch/arm64/boot/dts/qcom/talos.dtsi | 35 +++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi
index 1d74e459f892..04636fd88807 100644
--- a/arch/arm64/boot/dts/qcom/talos.dtsi
+++ b/arch/arm64/boot/dts/qcom/talos.dtsi
@@ -5078,7 +5078,21 @@ usb_qmpphy: phy@88e6000 {
#phy-cells = <0>;
+ orientation-switch;
+
status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ usb_qmpphy_out: endpoint {
+ };
+ };
+ };
};
usb_qmpphy_2: phy@88e8000 {
@@ -5163,7 +5177,21 @@ usb_1: usb@a600000 {
wakeup-source;
dma-coherent;
+ usb-role-switch;
+
status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ usb_1_dwc3_hs: endpoint {
+ };
+ };
+ };
};
usb_2: usb@a800000 {
@@ -5220,7 +5248,14 @@ usb_2: usb@a800000 {
wakeup-source;
dma-coherent;
+ usb-role-switch;
+
status = "disabled";
+
+ port {
+ usb_2_dwc3_hs: endpoint {
+ };
+ };
};
tsens0: thermal-sensor@c263000 {
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v4 2/2] arm64: dts: qcom: talos-lyra-evk: Wire up CYPD6129 USB Type-C ports
2026-11-16 13:05 [PATCH v4 0/2] arm64: dts: qcom: talos-lyra-evk: Wire up CYPD6129 USB Type-C ports Akash Kumar
2026-11-16 13:05 ` [PATCH v4 1/2] arm64: dts: qcom: talos: Add graph port placeholders for USB Type-C muxing Akash Kumar
@ 2026-11-16 13:05 ` Akash Kumar
2026-11-17 10:55 ` [PATCH v4 0/2] " Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Akash Kumar @ 2026-11-16 13:05 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Dmitry Baryshkov, Abel Vesa, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
From: Akash Kumar <akakum@qti.qualcomm.com>
Add the CYPD6129 UCSI PD controller (typec@40) on i2c5 with its two
USB-C connectors, and route their HS/SS endpoints to usb_1/usb_2's
dwc3 controllers and the USB QMP PHY. The PD controller, its GPIO86
interrupt line, and the PM8150 GPIO10 VBUS-enable control are on the
SoC/SoM card, so they are added to talos-lyra-evk-som.dtsi.
connector@1 additionally routes its SBU lines through a GPIO-controlled
SBU mux (onnn,fsusb43l10x) selected by expander0, since connector@1's
physical Type-C port carries SuperSpeed and SBU while connector@0's
port is USB-HS-only by hardware design. The SBU mux and its GPIO
expanders live on the carrier board, so they are added to
talos-lyra-evk.dts along with the TLMM GPIO64 VBUS boost enable fixed
regulator that supplies the USB daughter-card connector's VBUS.
Switch usb_1/usb_2 to dr_mode = "otg" with usb-role-switch so role
switching is driven by the PD controller, and add the supporting
USB1_VBUS regulator and pinctrl entries needed by this routing.
Signed-off-by: Akash Kumar <akakum@qti.qualcomm.com>
---
.../boot/dts/qcom/talos-lyra-evk-som.dtsi | 121 ++++++++++++++++++
arch/arm64/boot/dts/qcom/talos-lyra-evk.dts | 42 ++++--
2 files changed, 152 insertions(+), 11 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi
index 7d9a08471906..ed3a369dac02 100644
--- a/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi
+++ b/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi
@@ -31,6 +31,16 @@ xo_board_clk: xo-board-clk {
#clock-cells = <0>;
};
};
+
+ regulator-usb1-vbus {
+ compatible = "regulator-fixed";
+ regulator-name = "USB1_VBUS";
+ gpio = <&pm8150_gpios 10 GPIO_ACTIVE_HIGH>;
+ pinctrl-0 = <&usb1_en>;
+ pinctrl-names = "default";
+ enable-active-high;
+ regulator-always-on;
+ };
};
&apps_rsc {
@@ -179,6 +189,87 @@ &gpu_zap_shader {
firmware-name = "qcom/qcs615/a612_zap.mbn";
};
+&i2c5 {
+ typec@40 {
+ compatible = "cypress,cypd6129";
+ reg = <0x40>;
+ interrupts-extended = <&tlmm 86 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-0 = <&usb0_intr_state>;
+ pinctrl-names = "default";
+ wakeup-source;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ connector@0 {
+ compatible = "usb-c-connector";
+ reg = <0>;
+ label = "USB-C";
+ data-role = "dual";
+ power-role = "dual";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ ucsi_ccg_port_0_hs: endpoint {
+ remote-endpoint = <&usb_2_dwc3_hs>;
+ };
+ };
+ };
+ };
+
+ connector@1 {
+ compatible = "usb-c-connector";
+ reg = <1>;
+ label = "USB-C";
+ data-role = "dual";
+ power-role = "dual";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ ucsi_ccg_port_1_hs: endpoint {
+ remote-endpoint = <&usb_1_dwc3_hs>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ ccg_typec_con1_ss: endpoint {
+ remote-endpoint = <&usb_qmpphy_out>;
+ };
+ };
+
+ port@2 {
+ reg = <2>;
+
+ ccg_typec_con1_sbu: endpoint {
+ remote-endpoint = <&sbu_mux_in>;
+ };
+ };
+ };
+ };
+ };
+};
+
+&pm8150_gpios {
+ usb1_en: usb1-en-state {
+ pins = "gpio10";
+ function = "normal";
+ output-enable;
+ power-source = <0>;
+ };
+};
+
&qupv3_id_0 {
status = "okay";
};
@@ -229,6 +320,15 @@ &sdhc_2 {
status = "okay";
};
+&tlmm {
+ usb0_intr_state: usb0-intr-state {
+ pins = "gpio86";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
+};
+
&uart0 {
status = "okay";
};
@@ -250,6 +350,14 @@ &ufs_mem_phy {
status = "okay";
};
+&usb_1 {
+ status = "okay";
+};
+
+&usb_1_dwc3_hs {
+ remote-endpoint = <&ucsi_ccg_port_1_hs>;
+};
+
&usb_1_hsphy {
vdd-supply = <&vreg_l5a>;
vdda-pll-supply = <&vreg_l12a>;
@@ -258,6 +366,15 @@ &usb_1_hsphy {
status = "okay";
};
+&usb_2 {
+ status = "okay";
+};
+
+/* HS only */
+&usb_2_dwc3_hs {
+ remote-endpoint = <&ucsi_ccg_port_0_hs>;
+};
+
&usb_2_hsphy {
vdd-supply = <&vreg_l5a>;
vdda-pll-supply = <&vreg_l12a>;
@@ -279,3 +396,7 @@ &usb_qmpphy_2 {
status = "okay";
};
+
+&usb_qmpphy_out {
+ remote-endpoint = <&ccg_typec_con1_ss>;
+};
diff --git a/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts b/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts
index d4468e609911..020ce7db4241 100644
--- a/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts
+++ b/arch/arm64/boot/dts/qcom/talos-lyra-evk.dts
@@ -4,6 +4,7 @@
*/
/dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
#include "talos-lyra-evk-som.dtsi"
/ {
@@ -22,6 +23,30 @@ dp0_connector_in: endpoint {
};
};
};
+
+ regulator-vbus-boost-5v {
+ compatible = "regulator-fixed";
+ regulator-name = "vreg_vbus_boost_5v";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ gpio = <&tlmm 64 GPIO_ACTIVE_HIGH>;
+ pinctrl-0 = <&vbus_boost_en>;
+ pinctrl-names = "default";
+ enable-active-high;
+ regulator-always-on;
+ };
+
+ sbu-mux {
+ compatible = "onnn,fsusb43l10x", "gpio-sbu-mux";
+ select-gpios = <&expander0 12 GPIO_ACTIVE_LOW>;
+ orientation-switch;
+
+ port {
+ sbu_mux_in: endpoint {
+ remote-endpoint = <&ccg_typec_con1_sbu>;
+ };
+ };
+ };
};
&i2c5 {
@@ -100,16 +125,11 @@ dp_hot_plug_det: dp-hot-plug-det-state {
function = "dp_hot";
bias-disable;
};
-};
-&usb_1 {
- dr_mode = "peripheral";
-
- status = "okay";
-};
-
-&usb_2 {
- dr_mode = "host";
-
- status = "okay";
+ vbus_boost_en: vbus-boost-en-state {
+ pins = "gpio64";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
};
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v4 0/2] arm64: dts: qcom: talos-lyra-evk: Wire up CYPD6129 USB Type-C ports
2026-11-16 13:05 [PATCH v4 0/2] arm64: dts: qcom: talos-lyra-evk: Wire up CYPD6129 USB Type-C ports Akash Kumar
2026-11-16 13:05 ` [PATCH v4 1/2] arm64: dts: qcom: talos: Add graph port placeholders for USB Type-C muxing Akash Kumar
2026-11-16 13:05 ` [PATCH v4 2/2] arm64: dts: qcom: talos-lyra-evk: Wire up CYPD6129 USB Type-C ports Akash Kumar
@ 2026-11-17 10:55 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-17 10:55 UTC (permalink / raw)
To: Akash Kumar, Bjorn Andersson, Konrad Dybcio
Cc: Dmitry Baryshkov, Abel Vesa, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On 16/11/2026 14:05, Akash Kumar wrote:
> ---
> Akash Kumar (2):
> arm64: dts: qcom: talos: Add graph port placeholders for USB Type-C
> muxing
> arm64: dts: qcom: talos-lyra-evk: Wire up CYPD6129 USB Type-C ports
>
> .../boot/dts/qcom/talos-lyra-evk-som.dtsi | 121 ++++++++++++++++++
> arch/arm64/boot/dts/qcom/talos-lyra-evk.dts | 42 ++++--
> arch/arm64/boot/dts/qcom/talos.dtsi | 35 +++++
No such files.
So instead sending complete board, you pile up patches on top of patches
on top of patches. Didn't we have extensive talks about this? How
anything improved here?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread