[PATCH] media: exynos4-is: Free the control handler if fimc_ctrls_create() fails

[PATCH] media: exynos4-is: Free the control handler if fimc_ctrls_create() fails

[Wentao Liang]

v4l2_ctrl_handler_init() allocates the handler's bucket array, and each
subsequent v4l2_ctrl_new_std() call allocates a control.  When one of
those calls fails it only records the error in handler->error.
fimc_ctrls_create() returns that error with ctrls->ready left false, so
neither caller calls fimc_ctrls_delete(), and that function would not
free the handler in that state anyway.  The bucket array and the
controls created so far are leaked.

Free the handler before returning the error.

Fixes: 9448ab7dec30 ("[media] s5p-fimc: Add color effect control")
Cc: stable@vger.kernel.org
Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/media/platform/samsung/exynos4-is/fimc-core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-core.c b/drivers/media/platform/samsung/exynos4-is/fimc-core.c
index b36812ad25c0..8e6dd602aa79 100644
--- a/drivers/media/platform/samsung/exynos4-is/fimc-core.c
+++ b/drivers/media/platform/samsung/exynos4-is/fimc-core.c
@@ -606,6 +606,8 @@ int fimc_ctrls_create(struct fimc_ctx *ctx)
 	if (!handler->error) {
 		v4l2_ctrl_cluster(2, &ctrls->colorfx);
 		ctrls->ready = true;
+	} else {
+		v4l2_ctrl_handler_free(handler);
 	}
 
 	return handler->error;
-- 
2.34.1

Re: [PATCH] media: exynos4-is: Free the control handler if fimc_ctrls_create() fails

[Krzysztof Kozlowski]

On Tue, 03 Nov 2026 09:46:12 +0000, Wentao Liang wrote:
> v4l2_ctrl_handler_init() allocates the handler's bucket array, and each
> subsequent v4l2_ctrl_new_std() call allocates a control.  When one of
> those calls fails it only records the error in handler->error.
> fimc_ctrls_create() returns that error with ctrls->ready left false, so
> neither caller calls fimc_ctrls_delete(), and that function would not
> free the handler in that state anyway.  The bucket array and the
> controls created so far are leaked.
> 
> Free the handler before returning the error.
> 
> Fixes: 9448ab7dec30 ("[media] s5p-fimc: Add color effect control")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
>  drivers/media/platform/samsung/exynos4-is/fimc-core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 



Multiple things here:
1. Your team ignored completely previous feedback. Multiple times.

2. You use multiple identities with this email address, thus I doubt that we
   speak with an actual person.

3. Your bot does not even bother running checkpatch, right?

4. Nothing of this was reproduced nor tested.

5. Finally, the same feedback:
You sent multiple independent patches, to multiple independent
subsystems. The amount of these patches clearly suggest this was
AI generated and most likely not tested.

More importantly, you sent all this work without properly organizing
relevant patches into patchsets. This makes reviewing difficult
and might cause multiple reviewers to address the same issue.
Replying to the entire set is impossible and requires handling each
patch independently, instead of applying or discarding the set.
Maintainers also won't see the bigger picture of your work. Quite
worrying.

This is on the verge of hostile patch: bomb us with so many
contributions, we won't be able to handle them in efficient manner,
like responding ONCE to ask you to slow down.  Considering all this
is untested and LLM generated, I have even more doubts whether this
should be considered for review.

Please read kernel documentation BEFORE posting more work. It will
explain you how to identify subsystems, how to organize your work per
subsystem (so a patchset grouping multiple patches with a short cover
letter), how to document the issue discovery method and what was
or was not tested.

Best regards,
Krzysztof

Re: [PATCH] media: exynos4-is: Free the control handler if fimc_ctrls_create() fails

[Krzysztof Kozlowski]

On 03/11/2026 10:46, Wentao Liang wrote:
> v4l2_ctrl_handler_init() allocates the handler's bucket array, and each
> subsequent v4l2_ctrl_new_std() call allocates a control.  When one of
> those calls fails it only records the error in handler->error.
> fimc_ctrls_create() returns that error with ctrls->ready left false, so
> neither caller calls fimc_ctrls_delete(), and that function would not
> free the handler in that state anyway.  The bucket array and the
> controls created so far are leaked.
> 
> Free the handler before returning the error.
> 
> Fixes: 9448ab7dec30 ("[media] s5p-fimc: Add color effect control")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>

This is another posting of bot ignoring feedback and probably
introducing vilnerabilities hidden in big spam posting.

Best regards,
Krzysztof