From: Andrew Lunn <andrew@lunn.ch>
To: Alexander Popov <alex.popov@linux.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Michal Kubecek <mkubecek@suse.cz>, Gal Pressman <gal@nvidia.com>,
Kory Maincent <kory.maincent@bootlin.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Ido Schimmel <idosch@nvidia.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
security@kernel.org, notify@kernel.org
Subject: Re: [PATCH] ethtool: don't touch the parent device of a net device being unregistered
Date: Sun, 29 Mar 2026 15:52:03 +0200 [thread overview]
Message-ID: <cf7b22ca-71da-464c-96c9-7286b06d5aca@lunn.ch> (raw)
In-Reply-To: <676733D7-814A-4B66-9E49-93DD1259ED48@linux.com>
> >> That's not sufficient detail. ethnl_parse_header_dev_get() is under RCU
> >> and unregistration does an RCU sync after delisting the device. Also
> >> not sure you're distinguishing struct net_device and struct device.
> >>
> >> How did you hit this issue? What are the net devices involved?
> >
> >I've provided additional details about the reproducer of this vulnerability to Jakub and to security@kernel.org.
>
> Hello! May I ask about the decision on this patch?
>
> At patchwork.kernel.org, it is marked as "Changes Requested":
> <https://patchwork.kernel.org/project/netdevbpf/patch/20260322075917.254874-1-alex.popov@linux.com/>
>
> However, I don't have any instructions on what to change in it.
You need to add to the commit message to explain how it can happen.
My question said i _think_ devices are arranged in a tree, and release
happens from the leaves towards the root. So a parent should not be
release first. If i'm correct, this crash indicates a problem
somewhere else, not here. So we should fix that. Your commit message
needs to convince me the change is fixing the real problem, not
papering over the cracks.
Andrew
next prev parent reply other threads:[~2026-03-29 13:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 7:59 Alexander Popov
2026-03-22 14:39 ` Andrew Lunn
2026-03-22 23:08 ` Alexander Popov
2026-03-23 22:08 ` Jakub Kicinski
2026-03-24 18:46 ` Alexander Popov
2026-03-29 8:47 ` Alexander Popov
2026-03-29 13:52 ` Andrew Lunn [this message]
2026-03-29 17:54 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf7b22ca-71da-464c-96c9-7286b06d5aca@lunn.ch \
--to=andrew@lunn.ch \
--cc=alex.popov@linux.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=notify@kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®