mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* DIE_NMI_IPI to oprofile ?
@ 2007-06-26  6:51 Amitabha Roy
  2007-06-26 10:20 ` Björn Steinbrink
  0 siblings, 1 reply; 2+ messages in thread
From: Amitabha Roy @ 2007-06-26  6:51 UTC (permalink / raw)
  To: oprofile-list, linux-kernel

Hi

>From looking at the default_do_nmi code in traps.c it seems that (at
least for the non BSP case, with reason=0) the die notifier chain gets
called with val=DIE_NMI_IPI.

However in the profile_exceptions_notify_handler we check for DIE_NMI
(and not DIE_NMI_IPI) to decide if we want to cycle through the
counters. This seems wrong to me unless I am missing something (which
must be the case, otherwise this code is broken :).

Can anyone help me understand this ?

Thanks
-Amitabha

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: DIE_NMI_IPI to oprofile ?
  2007-06-26  6:51 DIE_NMI_IPI to oprofile ? Amitabha Roy
@ 2007-06-26 10:20 ` Björn Steinbrink
  0 siblings, 0 replies; 2+ messages in thread
From: Björn Steinbrink @ 2007-06-26 10:20 UTC (permalink / raw)
  To: Amitabha Roy; +Cc: oprofile-list, linux-kernel

On 2007.06.25 23:51:51 -0700, Amitabha Roy wrote:
> Hi
> 
> >From looking at the default_do_nmi code in traps.c it seems that (at
> least for the non BSP case, with reason=0) the die notifier chain gets
> called with val=DIE_NMI_IPI.
> 
> However in the profile_exceptions_notify_handler we check for DIE_NMI
> (and not DIE_NMI_IPI) to decide if we want to cycle through the
> counters. This seems wrong to me unless I am missing something (which
> must be the case, otherwise this code is broken :).
> 
> Can anyone help me understand this ?

notify_die(DIE_NMI, ...) is also called from nmi_watchdog_tick. So
depending on "reason" you call:

notify_die(DIE_NMI_IPI, ...)
nmi_watchdog_tick(...)
---> notify_die(DIE_NMI, ...)

or just

notify_die(DIE_NMI, ...)

HTH
Björn

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-06-26 10:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-06-26  6:51 DIE_NMI_IPI to oprofile ? Amitabha Roy
2007-06-26 10:20 ` Björn Steinbrink

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®