mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [RFT PATCH 0/3] Add missing CX_MEM/DBGC GPU regions for SM6115/QCM2290
@ 2025-12-29 20:47 Konrad Dybcio
  2025-12-29 20:47 ` [PATCH RFT 1/3] dt-bindings: display/msm/gpu: Straighten out reg-names on A619L/610/702 Konrad Dybcio
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Konrad Dybcio @ 2025-12-29 20:47 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Dmitry Baryshkov, Rob Clark, Sean Paul,
	Akhil P Oommen, Abhinav Kumar, Jessica Zhang, Marijn Suijten,
	David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann
  Cc: linux-arm-msm, devicetree, linux-kernel, dri-devel, freedreno,
	Konrad Dybcio, Krzysztof Kozlowski

These regions were previously left undescribed, fix that.

Compile-tested only, the driver shouldn't break though.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
Konrad Dybcio (3):
      dt-bindings: display/msm/gpu: Straighten out reg-names on A619L/610/702
      arm64: dts: qcom: agatti: Add CX_MEM/DBGC GPU regions
      arm64: dts: qcom: sm6115: Add CX_MEM/DBGC GPU regions

 Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 ------
 arch/arm64/boot/dts/qcom/agatti.dtsi                   | 8 ++++++--
 arch/arm64/boot/dts/qcom/sm6115.dtsi                   | 8 ++++++--
 3 files changed, 12 insertions(+), 10 deletions(-)
---
base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
change-id: 20251229-topic-6115_2290_gpu_dbgc-79822622b58d

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH RFT 1/3] dt-bindings: display/msm/gpu: Straighten out reg-names on A619L/610/702
  2025-12-29 20:47 [RFT PATCH 0/3] Add missing CX_MEM/DBGC GPU regions for SM6115/QCM2290 Konrad Dybcio
@ 2025-12-29 20:47 ` Konrad Dybcio
  2025-12-30 18:07   ` Rob Herring (Arm)
  2025-12-29 20:47 ` [PATCH RFT 2/3] arm64: dts: qcom: agatti: Add CX_MEM/DBGC GPU regions Konrad Dybcio
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 9+ messages in thread
From: Konrad Dybcio @ 2025-12-29 20:47 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Dmitry Baryshkov, Rob Clark, Sean Paul,
	Akhil P Oommen, Abhinav Kumar, Jessica Zhang, Marijn Suijten,
	David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann
  Cc: linux-arm-msm, devicetree, linux-kernel, dri-devel, freedreno,
	Konrad Dybcio

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

These GPUs have physically have the same regions as the base case
("main" + "cx_mem" + "cx_dbgc"). Remove the specific override.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml
index 826aafdcc20b..ae8f76136fa2 100644
--- a/Documentation/devicetree/bindings/display/msm/gpu.yaml
+++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml
@@ -378,12 +378,6 @@ allOf:
             - const: xo
               description: GPUCC clocksource clock
 
-        reg-names:
-          minItems: 1
-          items:
-            - const: kgsl_3d0_reg_memory
-            - const: cx_dbgc
-
       required:
         - clocks
         - clock-names

-- 
2.52.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH RFT 2/3] arm64: dts: qcom: agatti: Add CX_MEM/DBGC GPU regions
  2025-12-29 20:47 [RFT PATCH 0/3] Add missing CX_MEM/DBGC GPU regions for SM6115/QCM2290 Konrad Dybcio
  2025-12-29 20:47 ` [PATCH RFT 1/3] dt-bindings: display/msm/gpu: Straighten out reg-names on A619L/610/702 Konrad Dybcio
@ 2025-12-29 20:47 ` Konrad Dybcio
  2025-12-30 18:11   ` Dmitry Baryshkov
  2025-12-29 20:47 ` [PATCH RFT 3/3] arm64: dts: qcom: sm6115: " Konrad Dybcio
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 9+ messages in thread
From: Konrad Dybcio @ 2025-12-29 20:47 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Dmitry Baryshkov, Rob Clark, Sean Paul,
	Akhil P Oommen, Abhinav Kumar, Jessica Zhang, Marijn Suijten,
	David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann
  Cc: linux-arm-msm, devicetree, linux-kernel, dri-devel, freedreno,
	Konrad Dybcio, Krzysztof Kozlowski

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Describe the GPU register regions, with the former existing but not
being used much if at all on this silicon, and the latter containing
various debugging levers generally related to dumping the state of
the IP upon a crash.

Fixes: 4faeef52c8e6 ("arm64: dts: qcom: qcm2290: Add GPU nodes")
Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Closes: https://lore.kernel.org/linux-arm-msm/8a64f70b-8034-45e7-86a3-0015cf357132@oss.qualcomm.com/T/#m404f1425c36b61467760f058b696b8910340a063
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/agatti.dtsi | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/agatti.dtsi b/arch/arm64/boot/dts/qcom/agatti.dtsi
index 8bf5c5583fc2..969ae1378db2 100644
--- a/arch/arm64/boot/dts/qcom/agatti.dtsi
+++ b/arch/arm64/boot/dts/qcom/agatti.dtsi
@@ -1591,8 +1591,12 @@ usb_dwc3_ss: endpoint {
 
 		gpu: gpu@5900000 {
 			compatible = "qcom,adreno-07000200", "qcom,adreno";
-			reg = <0x0 0x05900000 0x0 0x40000>;
-			reg-names = "kgsl_3d0_reg_memory";
+			reg = <0x0 0x05900000 0x0 0x40000>,
+			      <0x0 0x0599e000 0x0 0x1000>,
+			      <0x0 0x05961000 0x0 0x800>;
+			reg-names = "kgsl_3d0_reg_memory",
+				    "cx_mem",
+				    "cx_dbgc";
 
 			interrupts = <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH>;
 

-- 
2.52.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH RFT 3/3] arm64: dts: qcom: sm6115: Add CX_MEM/DBGC GPU regions
  2025-12-29 20:47 [RFT PATCH 0/3] Add missing CX_MEM/DBGC GPU regions for SM6115/QCM2290 Konrad Dybcio
  2025-12-29 20:47 ` [PATCH RFT 1/3] dt-bindings: display/msm/gpu: Straighten out reg-names on A619L/610/702 Konrad Dybcio
  2025-12-29 20:47 ` [PATCH RFT 2/3] arm64: dts: qcom: agatti: Add CX_MEM/DBGC GPU regions Konrad Dybcio
@ 2025-12-29 20:47 ` Konrad Dybcio
  2025-12-30 18:11   ` Dmitry Baryshkov
  2025-12-29 21:19 ` [RFT PATCH 0/3] Add missing CX_MEM/DBGC GPU regions for SM6115/QCM2290 Akhil P Oommen
  2026-01-21 19:56 ` (subset) " Bjorn Andersson
  4 siblings, 1 reply; 9+ messages in thread
From: Konrad Dybcio @ 2025-12-29 20:47 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Dmitry Baryshkov, Rob Clark, Sean Paul,
	Akhil P Oommen, Abhinav Kumar, Jessica Zhang, Marijn Suijten,
	David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann
  Cc: linux-arm-msm, devicetree, linux-kernel, dri-devel, freedreno,
	Konrad Dybcio, Krzysztof Kozlowski

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Describe the GPU register regions, with the former existing but not
being used much if at all on this silicon, and the latter containing
various debugging levers generally related to dumping the state of
the IP upon a crash.

Fixes: 11750af256f8 ("arm64: dts: qcom: sm6115: Add GPU nodes")
Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Closes: https://lore.kernel.org/linux-arm-msm/8a64f70b-8034-45e7-86a3-0015cf357132@oss.qualcomm.com/T/#m404f1425c36b61467760f058b696b8910340a063
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm6115.dtsi | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
index 5e2032c26ea3..4dba724f2c75 100644
--- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
@@ -1715,8 +1715,12 @@ usb_dwc3_ss: endpoint {
 
 		gpu: gpu@5900000 {
 			compatible = "qcom,adreno-610.0", "qcom,adreno";
-			reg = <0x0 0x05900000 0x0 0x40000>;
-			reg-names = "kgsl_3d0_reg_memory";
+			reg = <0x0 0x05900000 0x0 0x40000>,
+			      <0x0 0x0599e000 0x0 0x1000>,
+			      <0x0 0x05961000 0x0 0x800>;
+			reg-names = "kgsl_3d0_reg_memory",
+				    "cx_mem",
+				    "cx_dbgc";
 
 			/* There's no (real) GMU, so we have to handle quite a bunch of clocks! */
 			clocks = <&gpucc GPU_CC_GX_GFX3D_CLK>,

-- 
2.52.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [RFT PATCH 0/3] Add missing CX_MEM/DBGC GPU regions for SM6115/QCM2290
  2025-12-29 20:47 [RFT PATCH 0/3] Add missing CX_MEM/DBGC GPU regions for SM6115/QCM2290 Konrad Dybcio
                   ` (2 preceding siblings ...)
  2025-12-29 20:47 ` [PATCH RFT 3/3] arm64: dts: qcom: sm6115: " Konrad Dybcio
@ 2025-12-29 21:19 ` Akhil P Oommen
  2026-01-21 19:56 ` (subset) " Bjorn Andersson
  4 siblings, 0 replies; 9+ messages in thread
From: Akhil P Oommen @ 2025-12-29 21:19 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Dmitry Baryshkov, Rob Clark, Sean Paul, Abhinav Kumar,
	Jessica Zhang, Marijn Suijten, David Airlie, Simona Vetter,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	linux-arm-msm, devicetree, linux-kernel, dri-devel, freedreno,
	Konrad Dybcio, Krzysztof Kozlowski

On 12/30/2025 2:17 AM, Konrad Dybcio wrote:
> These regions were previously left undescribed, fix that.
> 
> Compile-tested only, the driver shouldn't break though.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> Konrad Dybcio (3):
>       dt-bindings: display/msm/gpu: Straighten out reg-names on A619L/610/702
>       arm64: dts: qcom: agatti: Add CX_MEM/DBGC GPU regions
>       arm64: dts: qcom: sm6115: Add CX_MEM/DBGC GPU regions

For the entire series:

Reviewed-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>

-Akhil

> 
>  Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 ------
>  arch/arm64/boot/dts/qcom/agatti.dtsi                   | 8 ++++++--
>  arch/arm64/boot/dts/qcom/sm6115.dtsi                   | 8 ++++++--
>  3 files changed, 12 insertions(+), 10 deletions(-)
> ---
> base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
> change-id: 20251229-topic-6115_2290_gpu_dbgc-79822622b58d
> 
> Best regards,


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH RFT 1/3] dt-bindings: display/msm/gpu: Straighten out reg-names on A619L/610/702
  2025-12-29 20:47 ` [PATCH RFT 1/3] dt-bindings: display/msm/gpu: Straighten out reg-names on A619L/610/702 Konrad Dybcio
@ 2025-12-30 18:07   ` Rob Herring (Arm)
  0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring (Arm) @ 2025-12-30 18:07 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: Conor Dooley, Krzysztof Kozlowski, dri-devel, David Airlie,
	Abhinav Kumar, Thomas Zimmermann, Maarten Lankhorst, Sean Paul,
	Marijn Suijten, linux-kernel, Konrad Dybcio, linux-arm-msm,
	Bjorn Andersson, Akhil P Oommen, Rob Clark, freedreno,
	Jessica Zhang, Simona Vetter, devicetree, Maxime Ripard,
	Dmitry Baryshkov


On Mon, 29 Dec 2025 21:47:39 +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> These GPUs have physically have the same regions as the base case
> ("main" + "cx_mem" + "cx_dbgc"). Remove the specific override.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 ------
>  1 file changed, 6 deletions(-)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH RFT 3/3] arm64: dts: qcom: sm6115: Add CX_MEM/DBGC GPU regions
  2025-12-29 20:47 ` [PATCH RFT 3/3] arm64: dts: qcom: sm6115: " Konrad Dybcio
@ 2025-12-30 18:11   ` Dmitry Baryshkov
  0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Baryshkov @ 2025-12-30 18:11 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Dmitry Baryshkov, Rob Clark, Sean Paul, Akhil P Oommen,
	Abhinav Kumar, Jessica Zhang, Marijn Suijten, David Airlie,
	Simona Vetter, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, linux-arm-msm, devicetree, linux-kernel,
	dri-devel, freedreno, Konrad Dybcio, Krzysztof Kozlowski

On Mon, Dec 29, 2025 at 09:47:41PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Describe the GPU register regions, with the former existing but not
> being used much if at all on this silicon, and the latter containing
> various debugging levers generally related to dumping the state of
> the IP upon a crash.
> 
> Fixes: 11750af256f8 ("arm64: dts: qcom: sm6115: Add GPU nodes")
> Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Closes: https://lore.kernel.org/linux-arm-msm/8a64f70b-8034-45e7-86a3-0015cf357132@oss.qualcomm.com/T/#m404f1425c36b61467760f058b696b8910340a063
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm6115.dtsi | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH RFT 2/3] arm64: dts: qcom: agatti: Add CX_MEM/DBGC GPU regions
  2025-12-29 20:47 ` [PATCH RFT 2/3] arm64: dts: qcom: agatti: Add CX_MEM/DBGC GPU regions Konrad Dybcio
@ 2025-12-30 18:11   ` Dmitry Baryshkov
  0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Baryshkov @ 2025-12-30 18:11 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Dmitry Baryshkov, Rob Clark, Sean Paul, Akhil P Oommen,
	Abhinav Kumar, Jessica Zhang, Marijn Suijten, David Airlie,
	Simona Vetter, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, linux-arm-msm, devicetree, linux-kernel,
	dri-devel, freedreno, Konrad Dybcio, Krzysztof Kozlowski

On Mon, Dec 29, 2025 at 09:47:40PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Describe the GPU register regions, with the former existing but not
> being used much if at all on this silicon, and the latter containing
> various debugging levers generally related to dumping the state of
> the IP upon a crash.
> 
> Fixes: 4faeef52c8e6 ("arm64: dts: qcom: qcm2290: Add GPU nodes")
> Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Closes: https://lore.kernel.org/linux-arm-msm/8a64f70b-8034-45e7-86a3-0015cf357132@oss.qualcomm.com/T/#m404f1425c36b61467760f058b696b8910340a063
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/agatti.dtsi | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: (subset) [RFT PATCH 0/3] Add missing CX_MEM/DBGC GPU regions for SM6115/QCM2290
  2025-12-29 20:47 [RFT PATCH 0/3] Add missing CX_MEM/DBGC GPU regions for SM6115/QCM2290 Konrad Dybcio
                   ` (3 preceding siblings ...)
  2025-12-29 21:19 ` [RFT PATCH 0/3] Add missing CX_MEM/DBGC GPU regions for SM6115/QCM2290 Akhil P Oommen
@ 2026-01-21 19:56 ` Bjorn Andersson
  4 siblings, 0 replies; 9+ messages in thread
From: Bjorn Andersson @ 2026-01-21 19:56 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Dmitry Baryshkov,
	Rob Clark, Sean Paul, Akhil P Oommen, Abhinav Kumar,
	Jessica Zhang, Marijn Suijten, David Airlie, Simona Vetter,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	Konrad Dybcio
  Cc: linux-arm-msm, devicetree, linux-kernel, dri-devel, freedreno,
	Konrad Dybcio, Krzysztof Kozlowski


On Mon, 29 Dec 2025 21:47:38 +0100, Konrad Dybcio wrote:
> These regions were previously left undescribed, fix that.
> 
> Compile-tested only, the driver shouldn't break though.
> 
> 

Applied, thanks!

[2/3] arm64: dts: qcom: agatti: Add CX_MEM/DBGC GPU regions
      commit: 0fdcc948929a6d673bd0f90631dd6e42090c3dbd
[3/3] arm64: dts: qcom: sm6115: Add CX_MEM/DBGC GPU regions
      commit: 78c13dac18cf0e6f6cbc6ea85d4f967e6cca9562

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2026-01-21 19:56 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-29 20:47 [RFT PATCH 0/3] Add missing CX_MEM/DBGC GPU regions for SM6115/QCM2290 Konrad Dybcio
2025-12-29 20:47 ` [PATCH RFT 1/3] dt-bindings: display/msm/gpu: Straighten out reg-names on A619L/610/702 Konrad Dybcio
2025-12-30 18:07   ` Rob Herring (Arm)
2025-12-29 20:47 ` [PATCH RFT 2/3] arm64: dts: qcom: agatti: Add CX_MEM/DBGC GPU regions Konrad Dybcio
2025-12-30 18:11   ` Dmitry Baryshkov
2025-12-29 20:47 ` [PATCH RFT 3/3] arm64: dts: qcom: sm6115: " Konrad Dybcio
2025-12-30 18:11   ` Dmitry Baryshkov
2025-12-29 21:19 ` [RFT PATCH 0/3] Add missing CX_MEM/DBGC GPU regions for SM6115/QCM2290 Akhil P Oommen
2026-01-21 19:56 ` (subset) " Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®