mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eduard Zingerman <eddyz87@gmail.com>
To: Ihor Solodrai <ihor.solodrai@linux.dev>,
	Alexei Starovoitov <ast@kernel.org>,
	 Andrii Nakryiko <andrii@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Kumar Kartikeya Dwivedi	 <memxor@gmail.com>
Cc: Alan Maguire <alan.maguire@oracle.com>,
	Emil Tsalapatis	 <emil@etsalapatis.com>,
	Jiri Olsa <jolsa@kernel.org>, Song Liu <song@kernel.org>,
	 Tejun Heo <tj@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>,
	bpf@vger.kernel.org,  linux-kernel@vger.kernel.org,
	sched-ext@lists.linux.dev
Subject: Re: [PATCH bpf-next v1 0/4] libbpf: Support kernel-side kfunc flavors
Date: Wed, 18 Nov 2026 14:57:49 -0700	[thread overview]
Message-ID: <cfb47f547888b0f70200c0cd5eecff2f20592f29.camel@gmail.com> (raw)
In-Reply-To: <dfba2231-4cf4-4bb2-90b9-6261b7567895@linux.dev>

On Wed, 2026-11-18 at 14:48 -0700, Ihor Solodrai wrote:
> On 2026-11-18 2:42 p.m., Eduard Zingerman wrote:
> > On Wed, 2026-11-18 at 14:12 -0700, Eduard Zingerman wrote:
> > > On Tue, 2026-11-17 at 12:21 -0700, Ihor Solodrai wrote:
> > 
> > ...
> > 
> > > > resolve_btfids fails the build if two of bpf_foo and its flavors have
> > > > compatible prototypes, unless both have foo's exact prototype
> > > > (aliases), so the fallback finds at most one match.  This ensures at
> > > 
> > > Why is an exception for kfuncs with identical prototypes necessary?
> > 
> > Ok, my helpful assistant points out the following use case:
> > 
> > On kernel side:
> > 
> >    __bpf_kfunc bool foo(struct task_struct *p, u64 flags);
> >    __bpf_kfunc bool foo___v2(struct task_struct *p, u64 flags);
> > 
> > 
> > On BPF side:
> > 
> > 
> >    extern bool foo(struct task_struct *p, u64 flags) __ksym;
> >    extern bool foo___v2___compat(struct task_struct *p, u64 flags) __ksym;
> > 
> >    /* Resolves to the kernel's foo(). */
> >    foo(p, 0);
> > 
> >    /* libbpf strips ___compat; resolves to the kernel's foo___v2().
> >     * workaround used before this series.
> >     */
> >    foo___v2___compat(p, 0);
> > 
> > New mechanics adds an obligation on the kernel side to maintain that
> > foo and foo___v2___compat are semantically identical, despite being
> > physically different functions. (Does it?)
> 
> Yes. I just replied with exactly same example (it's used in sched-ext).
> 
> > 
> > Would it be possible to use some kind of annotation, e.g.:
> > - __alias(foo___v2) (an ELF symbol alias), or
> > - __kfunc_alias(foo___v2)
> >    (resolving to some sort of btf_decl_tag for resolve_btfids to act upon).
> > And avoid allowing functions with compatible prototypes w/o exceptions.
> > 
> > ?
> 
> My intuition is that it's possible, but it'd be more complicated.
> The question is why?

Is it a requirement now for foo() and foo___v2___compat()
to be semantically identical? If it is, the alias mechanics forgoes
this requirement.

> libbpf side might become marginally simpler, but we'd add complexity
> on the kernel side, no?

On kernel side or on resolve_btfids side?

      reply	other threads:[~2026-11-18 21:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 19:21 Ihor Solodrai
2026-11-17 19:21 ` [PATCH bpf-next v1 1/4] libbpf: Fall back to kernel ___ flavors when resolving kfuncs Ihor Solodrai
2026-11-18 22:44   ` Eduard Zingerman
2026-11-17 19:21 ` [PATCH bpf-next v1 2/4] selftests/bpf: Test kfunc flavor resolution Ihor Solodrai
2026-11-17 19:21 ` [PATCH bpf-next v1 3/4] resolve_btfids: Reject kfunc families that libbpf can't disambiguate Ihor Solodrai
2026-11-18 22:59   ` Eduard Zingerman
2026-11-17 19:21 ` [PATCH bpf-next v1 4/4] docs/bpf: Describe how to change a kfunc's prototype Ihor Solodrai
2026-11-17 20:53 ` [PATCH bpf-next v1 0/4] libbpf: Support kernel-side kfunc flavors Tejun Heo
2026-11-18 21:12 ` Eduard Zingerman
2026-11-18 21:37   ` Ihor Solodrai
2026-11-18 22:11     ` Eduard Zingerman
2026-11-18 23:13       ` Ihor Solodrai
2026-11-18 21:42   ` Eduard Zingerman
2026-11-18 21:48     ` Ihor Solodrai
2026-11-18 21:57       ` Eduard Zingerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfb47f547888b0f70200c0cd5eecff2f20592f29.camel@gmail.com \
    --to=eddyz87@gmail.com \
    --cc=alan.maguire@oracle.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=emil@etsalapatis.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=memxor@gmail.com \
    --cc=sched-ext@lists.linux.dev \
    --cc=song@kernel.org \
    --cc=tj@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®