mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eduard Zingerman <eddyz87@gmail.com>
To: Ihor Solodrai <ihor.solodrai@linux.dev>,
	Alexei Starovoitov <ast@kernel.org>,
	 Andrii Nakryiko <andrii@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Kumar Kartikeya Dwivedi	 <memxor@gmail.com>
Cc: Alan Maguire <alan.maguire@oracle.com>,
	Emil Tsalapatis	 <emil@etsalapatis.com>,
	Jiri Olsa <jolsa@kernel.org>, Song Liu <song@kernel.org>,
	 Tejun Heo <tj@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>,
	bpf@vger.kernel.org,  linux-kernel@vger.kernel.org,
	sched-ext@lists.linux.dev
Subject: Re: [PATCH bpf-next v1 0/4] libbpf: Support kernel-side kfunc flavors
Date: Wed, 18 Nov 2026 15:11:15 -0700	[thread overview]
Message-ID: <d2f665211f7c294bf7a8f3897b247863090e4e19.camel@gmail.com> (raw)
In-Reply-To: <6a1b6f05-448e-461c-bd79-0acd67fb7edc@linux.dev>

On Wed, 2026-11-18 at 14:37 -0700, Ihor Solodrai wrote:
> On 2026-11-18 2:12 p.m., Eduard Zingerman wrote:
> > On Tue, 2026-11-17 at 12:21 -0700, Ihor Solodrai wrote:
> > > An incompatible change to a kfunc's prototype, such as an added
> > > parameter, breaks BPF programs built against the old one. libbpf
> > > ignores the ___<flavor> suffix of a kfunc declared in a BPF program,
> > > but makes an exact name look up on the kernel side, so the kernel
> > > can't keep the old prototype available under the kfunc's name.
> > > 
> > > sched_ext ran into this. cded46d97159 ("sched_ext: Make
> > > scx_bpf_dsq_insert*() return bool") kept the old prototype as
> > > scx_bpf_dsq_insert___compat, expecting libbpf to bind old binaries to
> > > it, and broke them. 2dbbdeda77a6 ("sched_ext: Fix scx_bpf_dsq_insert()
> > > backward binary compatibility") reversed the naming. A ___v2 kfunc
> > > declared as vmlinux.h spells it doesn't bind: 56bbc91219c0
> > > ("sched_ext: Fix scx_bpf_dsq_move_to_local___v2 compat detection")
> > > fixed a compat macro that silently dropped enq_flags because of this.
> > 
> > Please prefer examples to prose in cover letters.
> 
> The sched_ext story above narrates the commit history to illustrate
> the motivation for the feature.  Would you like to see code samples
> from there, or are you suggesting to drop the paragraph?
> 
> The documentation patch includes code examples of the new binding
> rules, I didn't want to duplicate that in the cover.

There are two ways to act while reading the above paragraph:
- follow the referenced commits and reconstruct the issue (time consuming).
- ignore it (not helpful).

> > Also, please de-Claude the included prose.
> 
> Please be more specific. Which "included prose"?

  sched_ext ran into this. cded46d97159 ... kept the old prototype as
  scx_bpf_dsq_insert___compat, expecting libbpf to bind old binaries to
  it, and broke them. 2dbbdeda77a6 ... reversed the naming. A ___v2
  kfunc declared as vmlinux.h spells it doesn't bind: 56bbc91219c0 ...
  fixed a compat macro that silently dropped enq_flags because of this.

This screams Claude from 1000 miles distance.
Maybe I have reading comprehension issues, but in order to decipher it
one has to:
- "kept old prototype" - figure out that two functions were declared
  "scx_bpf_dsq_insert" and "scx_bpf_dsq_insert___compat"
- "bind old binaries to it and broke them" - figure out that existing
  bpf programs referred to "scx_bpf_dsq_insert" and libbpf mechanics
  didn't work as expected.
- "reversed the naming" - like a new function became ___compat or what
  happened?
- "A ___v2 kfunc declared as vmlinux.h spells it ..."
  Now there is a ___v2 in the picture.
- "... doesn't bind" - figure out that this refers to libbpf mechanics.
- "fixed a compat macro that silently dropped enq_flags because of this."
  Incomprehensible w/o looking in the code.

> > 
> > > With this series, if the kernel's bpf_foo kfunc is missing or its
> > > prototype is incompatible with the declaration, libbpf binds the
> > > bpf_foo___<flavor> that has a compatible prototype. So a changed kfunc
> > > can keep its name, and the old prototype stays available as foo___v1.
> > > 
> > > resolve_btfids fails the build if two of bpf_foo and its flavors have
> > > compatible prototypes, unless both have foo's exact prototype
> > > (aliases), so the fallback finds at most one match.  This ensures at
> > 
> > Why is an exception for kfuncs with identical prototypes necessary?
> 
> For example, when the void scx_bpf_dsq_insert() is deprecated, the
> kernel side can do this:
> 
>    Today:       void scx_bpf_dsq_insert(...)
>                 bool scx_bpf_dsq_insert___v2(...)
> 
>    Later:       bool scx_bpf_dsq_insert(...)
>                 bool scx_bpf_dsq_insert___v2(...)  /* calls 
> scx_bpf_dsq_insert() */
> 
> Existing schedulers declare scx_bpf_dsq_insert___v2___compat.
> 
> libbpf strips the last suffix, so the bpf progs still call
> scx_bpf_dsq_insert___v2(). The wrapper keeps them working during the
> transition, including with older libbpf.
> 
> The exception allows to do this.
> Otherwise we break the ___v2___compat trick.

Thank you.

> > 
> > > kernel / module build time that no ambigous kfunc flavors exist.
> > > Documentation/bpf/kfuncs.rst describes the rules.
> > > 
> > > Compatibility is determined by bpf_core_types_are_compat(), the check
> > > libbpf already applies to kfuncs. Of the 70 same-name kfunc prototype
> > > changes between v6.6 and bpf-next, it finds 8 incompatible (arity,
> > > return kind, callback prototype). The other 62 (const, typedefs,
> > > parameter names, integer widths, pointee struct names, annotation
> > > suffixes) were made in place without breaking old callers.
> > 
> > Do you mean that without this series programs referring old prototypes
> > are broken?
> 
> Yes, if the kernel changed the prototype in place and the BPF program
> still expects the old one. For example, 8fe4dc4f6456 ("bpf: change
> prototype of bpf_session_{cookie,is_return}") added a ctx argument to
> bpf_session_is_return() in v7.0. libbpf can't resolve an object's old
> no-argument declaration on that kernel.
> 
> This series alone doesn't fix this, but with it the kernel *can*
> provide bpf_session_is_return___v1(void) for the old callers.

Ok, this clarifies things, thank you.

  reply	other threads:[~2026-11-18 22:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 19:21 Ihor Solodrai
2026-11-17 19:21 ` [PATCH bpf-next v1 1/4] libbpf: Fall back to kernel ___ flavors when resolving kfuncs Ihor Solodrai
2026-11-18 22:44   ` Eduard Zingerman
2026-11-17 19:21 ` [PATCH bpf-next v1 2/4] selftests/bpf: Test kfunc flavor resolution Ihor Solodrai
2026-11-17 19:21 ` [PATCH bpf-next v1 3/4] resolve_btfids: Reject kfunc families that libbpf can't disambiguate Ihor Solodrai
2026-11-18 22:59   ` Eduard Zingerman
2026-11-17 19:21 ` [PATCH bpf-next v1 4/4] docs/bpf: Describe how to change a kfunc's prototype Ihor Solodrai
2026-11-17 20:53 ` [PATCH bpf-next v1 0/4] libbpf: Support kernel-side kfunc flavors Tejun Heo
2026-11-18 21:12 ` Eduard Zingerman
2026-11-18 21:37   ` Ihor Solodrai
2026-11-18 22:11     ` Eduard Zingerman [this message]
2026-11-18 23:13       ` Ihor Solodrai
2026-11-18 21:42   ` Eduard Zingerman
2026-11-18 21:48     ` Ihor Solodrai
2026-11-18 21:57       ` Eduard Zingerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2f665211f7c294bf7a8f3897b247863090e4e19.camel@gmail.com \
    --to=eddyz87@gmail.com \
    --cc=alan.maguire@oracle.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=emil@etsalapatis.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=memxor@gmail.com \
    --cc=sched-ext@lists.linux.dev \
    --cc=song@kernel.org \
    --cc=tj@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®