mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: "Lecomte, Arnaud" <contact@arnaud-lcm.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk,
	snovitoll@gmail.com,
	syzbot+86b6d7c8bcc66747c505@syzkaller.appspotmail.com,
	syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] usb: mon: Fix slab-out-of-bounds in mon_bin_event due to unsafe URB transfer_buffer access
Date: Mon, 21 Jul 2025 09:51:34 -0400	[thread overview]
Message-ID: <cfc6d242-df9d-42cf-b275-08de2da669e8@rowland.harvard.edu> (raw)
In-Reply-To: <6cd8b6bd-d07b-404c-af23-42fcae9ed9df@arnaud-lcm.com>

On Mon, Jul 21, 2025 at 09:22:40AM +0100, Lecomte, Arnaud wrote:
> Hi Alan, thanks for your reply.
> 
> Your point raises an important question for me: Is there a specific reason
> why we don’t have
>  a synchronization mechanism in place to protect the URB's transfer buffer ?

Protect it from what?  Access by some driver at an inappropriate time?  
Drivers are supposed to know (and this is alluded to in the kerneldoc 
for usb_submit_urb()) that they aren't allowed to touch the transfer 
buffer while an URB is queued.

Alan Stern

  parent reply	other threads:[~2025-07-21 13:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-20 20:00 Arnaud Lecomte
2025-07-21  1:29 ` Alan Stern
2025-07-21  8:25   ` Lecomte, Arnaud
     [not found]   ` <6cd8b6bd-d07b-404c-af23-42fcae9ed9df@arnaud-lcm.com>
2025-07-21 13:51     ` Alan Stern [this message]
2025-07-22  8:22       ` Lecomte, Arnaud
2025-07-22 22:10 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfc6d242-df9d-42cf-b275-08de2da669e8@rowland.harvard.edu \
    --to=stern@rowland.harvard.edu \
    --cc=contact@arnaud-lcm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=snovitoll@gmail.com \
    --cc=syzbot+86b6d7c8bcc66747c505@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®