From: "Michael Kerrisk" <mtk.manpages@googlemail.com>
To: "Al Viro" <viro@zeniv.linux.org.uk>
Cc: "Ulrich Drepper" <drepper@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: dup2() vs dup3() inconsistency when
Date: Thu, 9 Oct 2008 14:10:08 +0200 [thread overview]
Message-ID: <cfd18e0f0810090510i87f088fi9eeea829ae2b58c1@mail.gmail.com> (raw)
Al,
your 2008-07-26 commit 6c5d0512a091480c9f981162227fdb1c9d70e555 for
fs/fcntl.c:sys_dup3 contains
+ if (unlikely(oldfd == newfd))
+ return -EINVAL;
This makes dup2() and dup3() differ with respect to the oldfd==newfd
case (dup2() becomes a no-op, just returning oldfd, dup3() gives the
EINVAL error.
Your commit log doesn't explain the rationale for this change. What
is it? (I could guess that it is to error on a case that may be a
user programming error, but I want to check this with you, so that I
add the right text to the man page.)
Cheers,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
git://git.kernel.org/pub/scm/docs/man-pages/man-pages.git
man-pages online: http://www.kernel.org/doc/man-pages/online_pages.html
Found a bug? http://www.kernel.org/doc/man-pages/reporting_bugs.html
next reply other threads:[~2008-10-09 12:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 12:10 Michael Kerrisk [this message]
2008-10-09 17:21 ` H. Peter Anvin
2008-10-09 20:31 ` Ulrich Drepper
2008-10-09 20:43 ` H. Peter Anvin
2008-10-09 20:52 ` Ulrich Drepper
2008-10-09 20:57 ` H. Peter Anvin
2008-10-09 21:04 ` Ulrich Drepper
2008-10-10 5:04 ` Michael Kerrisk
2008-10-10 12:09 ` Bernd Petrovitsch
2008-10-10 12:15 ` Michael Kerrisk
2008-10-10 13:02 ` Bernd Petrovitsch
2008-10-10 13:15 ` Michael Kerrisk
2008-10-10 13:31 ` Bernd Petrovitsch
2008-10-10 5:01 ` Michael Kerrisk
2008-10-10 13:43 ` Heikki Orsila
[not found] <bl2EV-7G2-9@gated-at.bofh.it>
[not found] ` <bl7v3-5sk-17@gated-at.bofh.it>
[not found] ` <blasN-OS-9@gated-at.bofh.it>
[not found] ` <blaCu-Z0-11@gated-at.bofh.it>
[not found] ` <blaMj-18o-23@gated-at.bofh.it>
[not found] ` <blaMj-18o-21@gated-at.bofh.it>
[not found] ` <bliqg-2DH-1@gated-at.bofh.it>
2008-10-10 11:42 ` Bodo Eggert
2008-10-10 11:59 ` Michael Kerrisk
2008-10-10 13:19 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfd18e0f0810090510i87f088fi9eeea829ae2b58c1@mail.gmail.com \
--to=mtk.manpages@googlemail.com \
--cc=drepper@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome