From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Hungyu Lin <dennylin0707@gmail.com>, vikash.garodia@oss.qualcomm.com
Cc: dikshita.agarwal@oss.qualcomm.com, abhinav.kumar@linux.dev,
mchehab@kernel.org, stefan.schmidt@linaro.org,
hverkuil@kernel.org, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] media: qcom: iris: handle runtime PM resume failure in core deinit
Date: Tue, 28 Jul 2026 13:52:11 +0100 [thread overview]
Message-ID: <cfd2e58c-e42b-44e3-a901-2048e496fb08@linaro.org> (raw)
In-Reply-To: <20260604050451.41583-1-dennylin0707@gmail.com>
On 04/06/2026 06:04, Hungyu Lin wrote:
> Check the return value of pm_runtime_resume_and_get() in
> iris_core_deinit().
>
> If runtime PM resume fails, skip hardware power-off operations but
> still perform software teardown and state transition. Also skip the
> corresponding pm_runtime_put_sync() call to avoid unbalanced runtime
> PM references.
>
> Fixes: bb8a95aa038e ("media: iris: implement power management")
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
> Changes in v2:
> - Keep software teardown and state transition when runtime PM resume fails
> - Skip only hardware power-off operations and pm_runtime_put_sync()
>
> drivers/media/platform/qcom/iris/iris_core.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_core.c b/drivers/media/platform/qcom/iris/iris_core.c
> index dbaac01eb15a..bf3c7f722490 100644
> --- a/drivers/media/platform/qcom/iris/iris_core.c
> +++ b/drivers/media/platform/qcom/iris/iris_core.c
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
prev parent reply other threads:[~2026-07-28 12:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tR8w2GUkOUcarBSbnLxQsLPJsDQrGHIxWcizc8oRS0vu5wWNbeqYLWN5I8JKOpgJg61rd7q3XoGBl0KeV4V9JQ==@protonmail.internalid>
2026-06-04 5:04 ` Hungyu Lin
2026-07-28 12:52 ` Bryan O'Donoghue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfd2e58c-e42b-44e3-a901-2048e496fb08@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=abhinav.kumar@linux.dev \
--cc=dennylin0707@gmail.com \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=hverkuil@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stefan.schmidt@linaro.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®