* [PATCH 0/5] power: supply: Remove unused gpio include header
@ 2025-12-20 21:54 Waqar Hameed
2025-12-20 21:54 ` [PATCH 1/5] power: supply: bd99954: " Waqar Hameed
` (5 more replies)
0 siblings, 6 replies; 10+ messages in thread
From: Waqar Hameed @ 2025-12-20 21:54 UTC (permalink / raw)
To: Sebastian Reichel, Tobias Schrammm, Matti Vaittinen
Cc: kernel, linux-pm, linux-kernel
These drivers include the gpio header but never use it. This patch
series just removes this unnecessary header.
This issue was found when writing a new driver for the upcoming TI
BQ25630 [1]. Patch adding support for that one will be sent as soon as
TI releases the datasheet publicly, which should be anytime soon...
[1] https://www.ti.com/product/BQ25630
Waqar Hameed (5):
power: supply: bd99954: Remove unused gpio include header
power: supply: bq256xx: Remove unused gpio include header
power: supply: bq25980: Remove unused gpio include header
power: supply: cw2015: Remove unused gpio include header
power: supply: ucs1002: Remove unused gpio include header
drivers/power/supply/bd99954-charger.c | 1 -
drivers/power/supply/bq256xx_charger.c | 1 -
drivers/power/supply/bq25980_charger.c | 1 -
drivers/power/supply/cw2015_battery.c | 1 -
drivers/power/supply/ucs1002_power.c | 1 -
5 files changed, 5 deletions(-)
base-commit: fa084c35afa13ab07a860ef0936cd987f9aa0460
--
2.39.5
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/5] power: supply: bd99954: Remove unused gpio include header
2025-12-20 21:54 [PATCH 0/5] power: supply: Remove unused gpio include header Waqar Hameed
@ 2025-12-20 21:54 ` Waqar Hameed
2025-12-22 7:19 ` Matti Vaittinen
2025-12-20 21:54 ` [PATCH 3/5] power: supply: bq25980: " Waqar Hameed
` (4 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: Waqar Hameed @ 2025-12-20 21:54 UTC (permalink / raw)
To: Matti Vaittinen, Sebastian Reichel; +Cc: kernel, linux-pm, linux-kernel
This header file is not used anywhere in the driver. Remove it.
Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
drivers/power/supply/bd99954-charger.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/power/supply/bd99954-charger.c b/drivers/power/supply/bd99954-charger.c
index d03a70cf84067..5c447b0882233 100644
--- a/drivers/power/supply/bd99954-charger.c
+++ b/drivers/power/supply/bd99954-charger.c
@@ -56,7 +56,6 @@
*/
#include <linux/delay.h>
-#include <linux/gpio/consumer.h>
#include <linux/interrupt.h>
#include <linux/i2c.h>
#include <linux/kernel.h>
--
2.39.5
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/5] power: supply: bq256xx: Remove unused gpio include header
2025-12-20 21:54 [PATCH 0/5] power: supply: Remove unused gpio include header Waqar Hameed
2025-12-20 21:54 ` [PATCH 1/5] power: supply: bd99954: " Waqar Hameed
2025-12-20 21:54 ` [PATCH 3/5] power: supply: bq25980: " Waqar Hameed
@ 2025-12-20 21:54 ` Waqar Hameed
2025-12-20 21:54 ` [PATCH 5/5] power: supply: ucs1002: " Waqar Hameed
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Waqar Hameed @ 2025-12-20 21:54 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: kernel, linux-pm, linux-kernel
This header file is not used anywhere in the driver. Remove it.
Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
drivers/power/supply/bq256xx_charger.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/power/supply/bq256xx_charger.c b/drivers/power/supply/bq256xx_charger.c
index ae14162f017a9..3eb1733940054 100644
--- a/drivers/power/supply/bq256xx_charger.c
+++ b/drivers/power/supply/bq256xx_charger.c
@@ -8,7 +8,6 @@
#include <linux/interrupt.h>
#include <linux/kernel.h>
#include <linux/module.h>
-#include <linux/gpio/consumer.h>
#include <linux/power_supply.h>
#include <linux/regmap.h>
#include <linux/types.h>
--
2.39.5
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/5] power: supply: bq25980: Remove unused gpio include header
2025-12-20 21:54 [PATCH 0/5] power: supply: Remove unused gpio include header Waqar Hameed
2025-12-20 21:54 ` [PATCH 1/5] power: supply: bd99954: " Waqar Hameed
@ 2025-12-20 21:54 ` Waqar Hameed
2025-12-20 21:54 ` [PATCH 2/5] power: supply: bq256xx: " Waqar Hameed
` (3 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Waqar Hameed @ 2025-12-20 21:54 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: kernel, linux-pm, linux-kernel
This header file is not used anywhere in the driver. Remove it.
Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
drivers/power/supply/bq25980_charger.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/power/supply/bq25980_charger.c b/drivers/power/supply/bq25980_charger.c
index 723858d62d141..4f91fd1a3dec9 100644
--- a/drivers/power/supply/bq25980_charger.c
+++ b/drivers/power/supply/bq25980_charger.c
@@ -8,7 +8,6 @@
#include <linux/interrupt.h>
#include <linux/kernel.h>
#include <linux/module.h>
-#include <linux/gpio/consumer.h>
#include <linux/power_supply.h>
#include <linux/regmap.h>
#include <linux/types.h>
--
2.39.5
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 4/5] power: supply: cw2015: Remove unused gpio include header
2025-12-20 21:54 [PATCH 0/5] power: supply: Remove unused gpio include header Waqar Hameed
` (3 preceding siblings ...)
2025-12-20 21:54 ` [PATCH 5/5] power: supply: ucs1002: " Waqar Hameed
@ 2025-12-20 21:54 ` Waqar Hameed
2026-01-12 1:56 ` [PATCH 0/5] power: supply: " Sebastian Reichel
5 siblings, 0 replies; 10+ messages in thread
From: Waqar Hameed @ 2025-12-20 21:54 UTC (permalink / raw)
To: Tobias Schrammm, Sebastian Reichel; +Cc: kernel, linux-pm, linux-kernel
This header file is not used anywhere in the driver. Remove it.
Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
drivers/power/supply/cw2015_battery.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/power/supply/cw2015_battery.c b/drivers/power/supply/cw2015_battery.c
index 0806abea2372f..a05dcc4a48f22 100644
--- a/drivers/power/supply/cw2015_battery.c
+++ b/drivers/power/supply/cw2015_battery.c
@@ -13,7 +13,6 @@
#include <linux/delay.h>
#include <linux/i2c.h>
#include <linux/gfp.h>
-#include <linux/gpio/consumer.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/power_supply.h>
--
2.39.5
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 5/5] power: supply: ucs1002: Remove unused gpio include header
2025-12-20 21:54 [PATCH 0/5] power: supply: Remove unused gpio include header Waqar Hameed
` (2 preceding siblings ...)
2025-12-20 21:54 ` [PATCH 2/5] power: supply: bq256xx: " Waqar Hameed
@ 2025-12-20 21:54 ` Waqar Hameed
2025-12-20 21:54 ` [PATCH 4/5] power: supply: cw2015: " Waqar Hameed
2026-01-12 1:56 ` [PATCH 0/5] power: supply: " Sebastian Reichel
5 siblings, 0 replies; 10+ messages in thread
From: Waqar Hameed @ 2025-12-20 21:54 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: kernel, linux-pm, linux-kernel
This header file is not used anywhere in the driver. Remove it.
Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
drivers/power/supply/ucs1002_power.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/power/supply/ucs1002_power.c b/drivers/power/supply/ucs1002_power.c
index fe94435340de6..3f44cc902f84d 100644
--- a/drivers/power/supply/ucs1002_power.c
+++ b/drivers/power/supply/ucs1002_power.c
@@ -6,7 +6,6 @@
*/
#include <linux/bits.h>
#include <linux/freezer.h>
-#include <linux/gpio/consumer.h>
#include <linux/i2c.h>
#include <linux/interrupt.h>
#include <linux/kernel.h>
--
2.39.5
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/5] power: supply: bd99954: Remove unused gpio include header
2025-12-20 21:54 ` [PATCH 1/5] power: supply: bd99954: " Waqar Hameed
@ 2025-12-22 7:19 ` Matti Vaittinen
0 siblings, 0 replies; 10+ messages in thread
From: Matti Vaittinen @ 2025-12-22 7:19 UTC (permalink / raw)
To: Waqar Hameed, Sebastian Reichel; +Cc: kernel, linux-pm, linux-kernel
On 20/12/2025 23:54, Waqar Hameed wrote:
> This header file is not used anywhere in the driver. Remove it.
>
> Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
Thanks!
Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>
> ---
> drivers/power/supply/bd99954-charger.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/power/supply/bd99954-charger.c b/drivers/power/supply/bd99954-charger.c
> index d03a70cf84067..5c447b0882233 100644
> --- a/drivers/power/supply/bd99954-charger.c
> +++ b/drivers/power/supply/bd99954-charger.c
> @@ -56,7 +56,6 @@
> */
>
> #include <linux/delay.h>
> -#include <linux/gpio/consumer.h>
> #include <linux/interrupt.h>
> #include <linux/i2c.h>
> #include <linux/kernel.h>
Yours,
-- Matti
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/5] power: supply: Remove unused gpio include header
2025-12-20 21:54 [PATCH 0/5] power: supply: Remove unused gpio include header Waqar Hameed
` (4 preceding siblings ...)
2025-12-20 21:54 ` [PATCH 4/5] power: supply: cw2015: " Waqar Hameed
@ 2026-01-12 1:56 ` Sebastian Reichel
5 siblings, 0 replies; 10+ messages in thread
From: Sebastian Reichel @ 2026-01-12 1:56 UTC (permalink / raw)
To: Sebastian Reichel, Tobias Schrammm, Matti Vaittinen, Waqar Hameed
Cc: kernel, linux-pm, linux-kernel
On Sat, 20 Dec 2025 22:54:07 +0100, Waqar Hameed wrote:
> These drivers include the gpio header but never use it. This patch
> series just removes this unnecessary header.
>
> This issue was found when writing a new driver for the upcoming TI
> BQ25630 [1]. Patch adding support for that one will be sent as soon as
> TI releases the datasheet publicly, which should be anytime soon...
>
> [...]
Applied, thanks!
[1/5] power: supply: bd99954: Remove unused gpio include header
commit: e312b7e3183d2d806609ee0e905da807ff5d891f
[2/5] power: supply: bq256xx: Remove unused gpio include header
commit: 38673fd9d622318eed1e35cfad5998b4056edc1e
[3/5] power: supply: bq25980: Remove unused gpio include header
commit: 3d74b6dfd703ba812c624c689451b0ae573b4f0b
[4/5] power: supply: cw2015: Remove unused gpio include header
commit: 91a4f92de8454621e9d4e77a58c19c9d60a69581
[5/5] power: supply: ucs1002: Remove unused gpio include header
commit: ce3bc8469e4c387fd937e2ef96a6d45b7e22afc7
Best regards,
--
Sebastian Reichel <sebastian.reichel@collabora.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/5] power: supply: Remove unused gpio include header
2025-12-20 21:39 Waqar Hameed
@ 2025-12-20 21:56 ` Waqar Hameed
0 siblings, 0 replies; 10+ messages in thread
From: Waqar Hameed @ 2025-12-20 21:56 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Tobias Schrammm, Matti Vaittinen, kernel, linux-pm, linux-kernel
On Sat, Dec 20, 2025 at 22:39 +0100 Waqar Hameed <waqar.hameed@axis.com> wrote:
> These drivers include the gpio header but never use it. This patch
> series just removes this unnecessary header.
>
> This issue was found when writing a new driver for the upcoming TI
> BQ25630 [1]. Patch adding support for that one will be sent as soon as
> TI releases the datasheet publicly, which should be anytime soon...
>
> [1] https://www.ti.com/product/BQ25630
>
> Waqar Hameed (5):
> power: supply: bd99954: Remove unused gpio include header
> power: supply: bq256xx: Remove unused gpio include header
> power: supply: bq25980: Remove unused gpio include header
> power: supply: cw2015: Remove unused gpio include header
> power: supply: ucs1002: Remove unused gpio include header
>
> drivers/power/supply/bd99954-charger.c | 1 -
> drivers/power/supply/bq256xx_charger.c | 1 -
> drivers/power/supply/bq25980_charger.c | 1 -
> drivers/power/supply/cw2015_battery.c | 1 -
> drivers/power/supply/ucs1002_power.c | 1 -
> 5 files changed, 5 deletions(-)
>
>
> base-commit: fa084c35afa13ab07a860ef0936cd987f9aa0460
Sorry, somehow the "in-reply-header" got removed so the patches didn't
group with the cover letter... I resent them again and hopefully it
works now!
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/5] power: supply: Remove unused gpio include header
@ 2025-12-20 21:39 Waqar Hameed
2025-12-20 21:56 ` Waqar Hameed
0 siblings, 1 reply; 10+ messages in thread
From: Waqar Hameed @ 2025-12-20 21:39 UTC (permalink / raw)
To: Sebastian Reichel, Tobias Schrammm, Matti Vaittinen
Cc: kernel, linux-pm, linux-kernel
These drivers include the gpio header but never use it. This patch
series just removes this unnecessary header.
This issue was found when writing a new driver for the upcoming TI
BQ25630 [1]. Patch adding support for that one will be sent as soon as
TI releases the datasheet publicly, which should be anytime soon...
[1] https://www.ti.com/product/BQ25630
Waqar Hameed (5):
power: supply: bd99954: Remove unused gpio include header
power: supply: bq256xx: Remove unused gpio include header
power: supply: bq25980: Remove unused gpio include header
power: supply: cw2015: Remove unused gpio include header
power: supply: ucs1002: Remove unused gpio include header
drivers/power/supply/bd99954-charger.c | 1 -
drivers/power/supply/bq256xx_charger.c | 1 -
drivers/power/supply/bq25980_charger.c | 1 -
drivers/power/supply/cw2015_battery.c | 1 -
drivers/power/supply/ucs1002_power.c | 1 -
5 files changed, 5 deletions(-)
base-commit: fa084c35afa13ab07a860ef0936cd987f9aa0460
--
2.39.5
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2026-01-12 1:56 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-20 21:54 [PATCH 0/5] power: supply: Remove unused gpio include header Waqar Hameed
2025-12-20 21:54 ` [PATCH 1/5] power: supply: bd99954: " Waqar Hameed
2025-12-22 7:19 ` Matti Vaittinen
2025-12-20 21:54 ` [PATCH 3/5] power: supply: bq25980: " Waqar Hameed
2025-12-20 21:54 ` [PATCH 2/5] power: supply: bq256xx: " Waqar Hameed
2025-12-20 21:54 ` [PATCH 5/5] power: supply: ucs1002: " Waqar Hameed
2025-12-20 21:54 ` [PATCH 4/5] power: supply: cw2015: " Waqar Hameed
2026-01-12 1:56 ` [PATCH 0/5] power: supply: " Sebastian Reichel
-- strict thread matches above, loose matches on Subject: below --
2025-12-20 21:39 Waqar Hameed
2025-12-20 21:56 ` Waqar Hameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome