* [PATCH v2 0/8] platform/x86: Fix typos in comments
@ 2026-09-10 4:44 Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 1/8] platform/x86: asus-laptop: Fix typo in infos_show() comment Hemanth Selam
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: Hemanth Selam @ 2026-09-10 4:44 UTC (permalink / raw)
To: hansg, ilpo.jarvinen
Cc: corentin.chary, luke, denis.benato, W_Armin, eric.piel,
kenneth.t.chan, jlee, srinivas.pandruvada, mpearson-lenovo,
platform-driver-x86, linux-kernel
v1 was one patch touching eight drivers. Denis Benato asked for it to be
split one patch per file or driver, so here it is as eight patches, one
per driver. The corrections themselves are unchanged from v1.
The words all come from scripts/spelling.txt, which is the list
checkpatch.pl uses. codespell finds nothing further in these eight files
except "ALS" in asus-laptop.c, which is the Ambient Light Sensor and must
stay as it is.
Two of these comments have a grammar problem in addition to the
misspelling:
asus-laptop.c "The HWRS method return information about the
hardware" wants "returns"
samsung-laptop.c "This allow to call arbitrary sabi commands" wants
"allows calling"
I have left both alone so that this series stays a spelling fix and so
Mark's review still covers exactly the text he read. I am happy to send
those two as a separate patch if you would like them corrected.
Mark Pearson reviewed v1 in full, so his tag is carried on every patch.
Denis offered his tag on the condition that Ilpo agrees to the split, and
it is included on that basis; please drop it if that is not right.
v1: https://lore.kernel.org/all/20260907085426.3661-1-hemanth.selam@gmail.com/
Hemanth Selam (8):
platform/x86: asus-laptop: Fix typo in infos_show() comment
platform/x86: asus-nb-wmi: Fix typo in asus_nb_wmi_quirks() comment
platform/x86: hp_accel: Fix typo in lis3lv02d_acpi_write() comment
platform/x86/intel/tpmi: Fix typo in TPMI_FEATURE_NAME_LEN comment
platform/x86: msi-laptop: Fix typo in struct quirk_entry comment
platform/x86: panasonic-laptop: Fix typo in the file history comment
platform/x86: samsung-laptop: Fix typo in sabi_configs comment
platform/x86: uniwill-laptop: Fix typo in the kbd LED brightness
comment
drivers/platform/x86/asus-laptop.c | 2 +-
drivers/platform/x86/asus-nb-wmi.c | 2 +-
drivers/platform/x86/hp/hp_accel.c | 2 +-
drivers/platform/x86/intel/vsec_tpmi.c | 2 +-
drivers/platform/x86/msi-laptop.c | 2 +-
drivers/platform/x86/panasonic-laptop.c | 2 +-
drivers/platform/x86/samsung-laptop.c | 2 +-
drivers/platform/x86/uniwill/uniwill-acpi.c | 2 +-
8 files changed, 8 insertions(+), 8 deletions(-)
--
2.48.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/8] platform/x86: asus-laptop: Fix typo in infos_show() comment
2026-09-10 4:44 [PATCH v2 0/8] platform/x86: Fix typos in comments Hemanth Selam
@ 2026-09-10 4:44 ` Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 2/8] platform/x86: asus-nb-wmi: Fix typo in asus_nb_wmi_quirks() comment Hemanth Selam
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Hemanth Selam @ 2026-09-10 4:44 UTC (permalink / raw)
To: hansg, ilpo.jarvinen
Cc: corentin.chary, luke, denis.benato, W_Armin, eric.piel,
kenneth.t.chan, jlee, srinivas.pandruvada, mpearson-lenovo,
platform-driver-x86, linux-kernel
Correct "informations" to "information" in the comment describing the
HWRS method. Comment only, no functional change.
Assisted-by: Cursor:claude-opus-5
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Denis Benato <denis.benato@linux.dev>
---
drivers/platform/x86/asus-laptop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
index 449addd1ac7a..de607edb9490 100644
--- a/drivers/platform/x86/asus-laptop.c
+++ b/drivers/platform/x86/asus-laptop.c
@@ -865,7 +865,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr,
len += sysfs_emit_at(page, len, "SFUN value : %#x\n",
(uint) temp);
/*
- * The HWRS method return informations about the hardware.
+ * The HWRS method return information about the hardware.
* 0x80 bit is for WLAN, 0x100 for Bluetooth.
* 0x40 for WWAN, 0x10 for WIMAX.
* The significance of others is yet to be found.
--
2.48.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 2/8] platform/x86: asus-nb-wmi: Fix typo in asus_nb_wmi_quirks() comment
2026-09-10 4:44 [PATCH v2 0/8] platform/x86: Fix typos in comments Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 1/8] platform/x86: asus-laptop: Fix typo in infos_show() comment Hemanth Selam
@ 2026-09-10 4:44 ` Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 3/8] platform/x86: hp_accel: Fix typo in lis3lv02d_acpi_write() comment Hemanth Selam
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Hemanth Selam @ 2026-09-10 4:44 UTC (permalink / raw)
To: hansg, ilpo.jarvinen
Cc: corentin.chary, luke, denis.benato, W_Armin, eric.piel,
kenneth.t.chan, jlee, srinivas.pandruvada, mpearson-lenovo,
platform-driver-x86, linux-kernel
Correct "paramater" to "parameter". Comment only, no functional
change.
Assisted-by: Cursor:claude-opus-5
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Denis Benato <denis.benato@linux.dev>
---
drivers/platform/x86/asus-nb-wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index aeb461b1644d..9b729afb34f9 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -573,7 +573,7 @@ static void asus_nb_wmi_quirks(struct asus_wmi_driver *driver)
driver->quirks = quirks;
driver->panel_power = BACKLIGHT_POWER_ON;
- /* overwrite the wapf setting if the wapf paramater is specified */
+ /* overwrite the wapf setting if the wapf parameter is specified */
if (wapf != -1)
quirks->wapf = wapf;
else
--
2.48.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 3/8] platform/x86: hp_accel: Fix typo in lis3lv02d_acpi_write() comment
2026-09-10 4:44 [PATCH v2 0/8] platform/x86: Fix typos in comments Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 1/8] platform/x86: asus-laptop: Fix typo in infos_show() comment Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 2/8] platform/x86: asus-nb-wmi: Fix typo in asus_nb_wmi_quirks() comment Hemanth Selam
@ 2026-09-10 4:44 ` Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 4/8] platform/x86/intel/tpmi: Fix typo in TPMI_FEATURE_NAME_LEN comment Hemanth Selam
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Hemanth Selam @ 2026-09-10 4:44 UTC (permalink / raw)
To: hansg, ilpo.jarvinen
Cc: corentin.chary, luke, denis.benato, W_Armin, eric.piel,
kenneth.t.chan, jlee, srinivas.pandruvada, mpearson-lenovo,
platform-driver-x86, linux-kernel
Correct "writting" to "writing". Comment only, no functional change.
Assisted-by: Cursor:claude-opus-5
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Denis Benato <denis.benato@linux.dev>
---
drivers/platform/x86/hp/hp_accel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/hp/hp_accel.c b/drivers/platform/x86/hp/hp_accel.c
index 39b73dc473f1..40e1b9fb1b6d 100644
--- a/drivers/platform/x86/hp/hp_accel.c
+++ b/drivers/platform/x86/hp/hp_accel.c
@@ -122,7 +122,7 @@ static int lis3lv02d_acpi_read(struct lis3lv02d *lis3, int reg, u8 *ret)
static int lis3lv02d_acpi_write(struct lis3lv02d *lis3, int reg, u8 val)
{
struct acpi_device *dev = lis3->bus_priv;
- unsigned long long ret; /* Not used when writting */
+ unsigned long long ret; /* Not used when writing */
union acpi_object in_obj[2];
struct acpi_object_list args = { 2, in_obj };
--
2.48.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 4/8] platform/x86/intel/tpmi: Fix typo in TPMI_FEATURE_NAME_LEN comment
2026-09-10 4:44 [PATCH v2 0/8] platform/x86: Fix typos in comments Hemanth Selam
` (2 preceding siblings ...)
2026-09-10 4:44 ` [PATCH v2 3/8] platform/x86: hp_accel: Fix typo in lis3lv02d_acpi_write() comment Hemanth Selam
@ 2026-09-10 4:44 ` Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 5/8] platform/x86: msi-laptop: Fix typo in struct quirk_entry comment Hemanth Selam
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Hemanth Selam @ 2026-09-10 4:44 UTC (permalink / raw)
To: hansg, ilpo.jarvinen
Cc: corentin.chary, luke, denis.benato, W_Armin, eric.piel,
kenneth.t.chan, jlee, srinivas.pandruvada, mpearson-lenovo,
platform-driver-x86, linux-kernel
Correct "upto" to "up to". Comment only, no functional change.
Assisted-by: Cursor:claude-opus-5
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Denis Benato <denis.benato@linux.dev>
---
drivers/platform/x86/intel/vsec_tpmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel/vsec_tpmi.c b/drivers/platform/x86/intel/vsec_tpmi.c
index 0153dd57838e..fbe9c8af4aee 100644
--- a/drivers/platform/x86/intel/vsec_tpmi.c
+++ b/drivers/platform/x86/intel/vsec_tpmi.c
@@ -597,7 +597,7 @@ static const char *intel_tpmi_name(enum intel_tpmi_id id)
}
}
-/* String Length for tpmi-"feature_name(upto 8 bytes)" */
+/* String Length for tpmi-"feature_name(up to 8 bytes)" */
#define TPMI_FEATURE_NAME_LEN 14
static int tpmi_create_device(struct intel_tpmi_info *tpmi_info,
--
2.48.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 5/8] platform/x86: msi-laptop: Fix typo in struct quirk_entry comment
2026-09-10 4:44 [PATCH v2 0/8] platform/x86: Fix typos in comments Hemanth Selam
` (3 preceding siblings ...)
2026-09-10 4:44 ` [PATCH v2 4/8] platform/x86/intel/tpmi: Fix typo in TPMI_FEATURE_NAME_LEN comment Hemanth Selam
@ 2026-09-10 4:44 ` Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 6/8] platform/x86: panasonic-laptop: Fix typo in the file history comment Hemanth Selam
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Hemanth Selam @ 2026-09-10 4:44 UTC (permalink / raw)
To: hansg, ilpo.jarvinen
Cc: corentin.chary, luke, denis.benato, W_Armin, eric.piel,
kenneth.t.chan, jlee, srinivas.pandruvada, mpearson-lenovo,
platform-driver-x86, linux-kernel
Correct "cann't" to "can't". Comment only, no functional change.
Assisted-by: Cursor:claude-opus-5
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Denis Benato <denis.benato@linux.dev>
---
drivers/platform/x86/msi-laptop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c
index ddef6b78d2fa..0a0c756a5598 100644
--- a/drivers/platform/x86/msi-laptop.c
+++ b/drivers/platform/x86/msi-laptop.c
@@ -117,7 +117,7 @@ struct quirk_entry {
* Wlan/Bluetooth/3G, those netbook will load the SCM (windows app) to
* disable the original Wlan/Bluetooth control by BIOS when user press
* fn key, then control Wlan/Bluetooth/3G by SCM (software control by
- * OS). Without SCM, user cann't on/off 3G module on those 3G netbook.
+ * OS). Without SCM, user can't on/off 3G module on those 3G netbook.
* On Linux, msi-laptop driver will do the same thing to disable the
* original BIOS control, then might need use HAL or other userland
* application to do the software control that simulate with SCM.
--
2.48.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 6/8] platform/x86: panasonic-laptop: Fix typo in the file history comment
2026-09-10 4:44 [PATCH v2 0/8] platform/x86: Fix typos in comments Hemanth Selam
` (4 preceding siblings ...)
2026-09-10 4:44 ` [PATCH v2 5/8] platform/x86: msi-laptop: Fix typo in struct quirk_entry comment Hemanth Selam
@ 2026-09-10 4:44 ` Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 7/8] platform/x86: samsung-laptop: Fix typo in sabi_configs comment Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 8/8] platform/x86: uniwill-laptop: Fix typo in the kbd LED brightness comment Hemanth Selam
7 siblings, 0 replies; 9+ messages in thread
From: Hemanth Selam @ 2026-09-10 4:44 UTC (permalink / raw)
To: hansg, ilpo.jarvinen
Cc: corentin.chary, luke, denis.benato, W_Armin, eric.piel,
kenneth.t.chan, jlee, srinivas.pandruvada, mpearson-lenovo,
platform-driver-x86, linux-kernel
Correct "retrive" to "retrieve" in the v0.4 entry. Comment only, no
functional change.
Assisted-by: Cursor:claude-opus-5
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Denis Benato <denis.benato@linux.dev>
---
drivers/platform/x86/panasonic-laptop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/panasonic-laptop.c b/drivers/platform/x86/panasonic-laptop.c
index 19d194ff37ca..a3597344edef 100644
--- a/drivers/platform/x86/panasonic-laptop.c
+++ b/drivers/platform/x86/panasonic-laptop.c
@@ -107,7 +107,7 @@
*
* Jul.25, 2004 Hiroshi Miura <miura@da-cha.org>
* - v0.4 first post version
- * add function to retrive SIFR
+ * add function to retrieve SIFR
*
* Jul.24, 2004 Hiroshi Miura <miura@da-cha.org>
* - v0.3 get proper status of hotkey
--
2.48.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 7/8] platform/x86: samsung-laptop: Fix typo in sabi_configs comment
2026-09-10 4:44 [PATCH v2 0/8] platform/x86: Fix typos in comments Hemanth Selam
` (5 preceding siblings ...)
2026-09-10 4:44 ` [PATCH v2 6/8] platform/x86: panasonic-laptop: Fix typo in the file history comment Hemanth Selam
@ 2026-09-10 4:44 ` Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 8/8] platform/x86: uniwill-laptop: Fix typo in the kbd LED brightness comment Hemanth Selam
7 siblings, 0 replies; 9+ messages in thread
From: Hemanth Selam @ 2026-09-10 4:44 UTC (permalink / raw)
To: hansg, ilpo.jarvinen
Cc: corentin.chary, luke, denis.benato, W_Armin, eric.piel,
kenneth.t.chan, jlee, srinivas.pandruvada, mpearson-lenovo,
platform-driver-x86, linux-kernel
Correct "wihout" to "without". Comment only, no functional change.
Assisted-by: Cursor:claude-opus-5
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Denis Benato <denis.benato@linux.dev>
---
drivers/platform/x86/samsung-laptop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
index 710f3d5bf84c..18631e96bb17 100644
--- a/drivers/platform/x86/samsung-laptop.c
+++ b/drivers/platform/x86/samsung-laptop.c
@@ -295,7 +295,7 @@ static const struct sabi_config sabi_configs[] = {
* d0, d1, d2, d3 - data fields
* call - call SABI using command and data
*
- * This allow to call arbitrary sabi commands wihout
+ * This allow to call arbitrary sabi commands without
* modifying the driver at all.
* For example, setting the keyboard backlight brightness to 5
*
--
2.48.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 8/8] platform/x86: uniwill-laptop: Fix typo in the kbd LED brightness comment
2026-09-10 4:44 [PATCH v2 0/8] platform/x86: Fix typos in comments Hemanth Selam
` (6 preceding siblings ...)
2026-09-10 4:44 ` [PATCH v2 7/8] platform/x86: samsung-laptop: Fix typo in sabi_configs comment Hemanth Selam
@ 2026-09-10 4:44 ` Hemanth Selam
7 siblings, 0 replies; 9+ messages in thread
From: Hemanth Selam @ 2026-09-10 4:44 UTC (permalink / raw)
To: hansg, ilpo.jarvinen
Cc: corentin.chary, luke, denis.benato, W_Armin, eric.piel,
kenneth.t.chan, jlee, srinivas.pandruvada, mpearson-lenovo,
platform-driver-x86, linux-kernel
Correct "device-specfic" to "device-specific" in the comment on
restoring the default RGB value. Comment only, no functional change.
Assisted-by: Cursor:claude-opus-5
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Denis Benato <denis.benato@linux.dev>
---
drivers/platform/x86/uniwill/uniwill-acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/uniwill/uniwill-acpi.c b/drivers/platform/x86/uniwill/uniwill-acpi.c
index 7a2eeaec4c96..eeead0159828 100644
--- a/drivers/platform/x86/uniwill/uniwill-acpi.c
+++ b/drivers/platform/x86/uniwill/uniwill-acpi.c
@@ -1705,7 +1705,7 @@ static int uniwill_kbd_led_mc_brightness_set(struct led_classdev *led_cdev,
/*
* The EC interprets a RGB value of 0x000000 as a command to restore
- * the device-specfic default RGB value. Work around this by writing
+ * the device-specific default RGB value. Work around this by writing
* a RGB value of 0x010101 (faint white) instead.
*/
if (data->kbd_led_mc_subled_info[0].intensity == 0 &&
--
2.48.1
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-09-10 4:45 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-10 4:44 [PATCH v2 0/8] platform/x86: Fix typos in comments Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 1/8] platform/x86: asus-laptop: Fix typo in infos_show() comment Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 2/8] platform/x86: asus-nb-wmi: Fix typo in asus_nb_wmi_quirks() comment Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 3/8] platform/x86: hp_accel: Fix typo in lis3lv02d_acpi_write() comment Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 4/8] platform/x86/intel/tpmi: Fix typo in TPMI_FEATURE_NAME_LEN comment Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 5/8] platform/x86: msi-laptop: Fix typo in struct quirk_entry comment Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 6/8] platform/x86: panasonic-laptop: Fix typo in the file history comment Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 7/8] platform/x86: samsung-laptop: Fix typo in sabi_configs comment Hemanth Selam
2026-09-10 4:44 ` [PATCH v2 8/8] platform/x86: uniwill-laptop: Fix typo in the kbd LED brightness comment Hemanth Selam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®