From: Yongbang Shi <shiyongbang@huawei.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
<dmitry.baryshkov@oss.qualcomm.com>, <tiantao6@hisilicon.com>,
<xinliang.liu@linaro.org>, <maarten.lankhorst@linux.intel.com>,
<mripard@kernel.org>, <airlied@gmail.com>, <daniel@ffwll.ch>,
<kong.kongxinwei@hisilicon.com>
Cc: <liangjian010@huawei.com>, <chenjianmin@huawei.com>,
<fengsheng5@huawei.com>, <helin52@h-partners.com>,
<shenjian15@huawei.com>, <shaojijie@huawei.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<shiyongbang@huawei.com>
Subject: Re: [PATCH for drm-misc-fixes v6 0/4] Fix some bugs in the hibmc driver
Date: Tue, 12 May 2026 20:12:19 +0800 [thread overview]
Message-ID: <d017d6e8-1035-4088-a543-6fc00f2c29c3@huawei.com> (raw)
In-Reply-To: <d45b7e90-9e13-4c04-8f4c-37898aabc2c0@suse.de>
> Hi,
>
> I've gone through the series and reviewed the patches. Let me know when they are ready to get merged.
>
Thanks for the review. The series is ready for merging now.
Thanks,
Yongbang.
> Best regards
> Thomas
>
>
> Am 09.05.26 um 05:22 schrieb Yongbang Shi:
>> From: Lin He <helin52@huawei.com>
>>
>> There are some bugfix for hibmc-drm driver.
>>
>> ---
>> ChangeLog:
>> v5 -> v6:
>> - Rename 'phys_state' to 'phys_status'
>> - Replace `drm_kms_helper_poll_init` with `drmm_kms_helper_poll_init`
>> and adjust the timing of the call.
>> - Split "return vdac->phys_state = state;" into separate statements.
>> - Change `get_mode` to return 0 when no modes are available, allowing DRM to
>> install a default resolution.
>> - Change the initial phys_status of vdac from
>> 'connector_status_connected' to 'connector_status_disconnected'
>> - Removed invalid bit configurations from `hibmc_display_ctrl`.
>> - Modify the return values of `hibmc_get_best_clock_idx` and
>> `hibmc_crtc_mode_valid`
>> v4 -> v5:
>> - The 'epoch_counter' of the vdac connector is incremented when the
>> physical status changes.
>> - The polling mechanism for the KMS helper is enabled.
>> v3 -> v4:
>> - fix incorrect cover-letter subject prefix in v3.
>> v2 -> v3:
>> - remove unused macro CLOCK_TOLERANCE.
>> v1 -> v2:
>> - fix the checkpatch.pl warning "Unknown commit ID 'e6c7c59da494'".
>> - fix the checkpatch.pl warning "line length of 83/85 exceeds 80 columns".
>> - remove tag "Reviewed-by: Tao Tian <tiantao6@hisilicon.com>", witch will
>> be given in public.
>> - add 'drm-misc-fixes' in subject prefix.
>> ---
>>
>> Lin He (4):
>> drm/hisilicon/hibmc: add updating link cap in DP detect()
>> drm/hisilicon/hibmc: fix no showing when no connectors connected
>> drm/hisilicon/hibmc: move display contrl config to hibmc_probe()
>> drm/hisilicon/hibmc: use clock to look up the PLL value
>>
>> drivers/gpu/drm/hisilicon/hibmc/dp/dp_comm.h | 1 +
>> drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.h | 1 +
>> drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.c | 2 +-
>> .../gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 80 +++++++++++--------
>> .../gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c | 35 +++++---
>> .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 14 ++++
>> .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 1 +
>> .../gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 75 +++++++++--------
>> 8 files changed, 124 insertions(+), 85 deletions(-)
>>
>
next prev parent reply other threads:[~2026-05-12 12:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-09 3:22 Yongbang Shi
2026-05-09 3:22 ` [PATCH for drm-misc-fixes v6 1/4] drm/hisilicon/hibmc: add updating link cap in DP detect() Yongbang Shi
2026-05-12 7:29 ` Thomas Zimmermann
2026-05-09 3:23 ` [PATCH for drm-misc-fixes v6 2/4] drm/hisilicon/hibmc: fix no showing when no connectors connected Yongbang Shi
2026-05-12 7:31 ` Thomas Zimmermann
2026-05-09 3:23 ` [PATCH for drm-misc-fixes v6 3/4] drm/hisilicon/hibmc: move display contrl config to hibmc_probe() Yongbang Shi
2026-05-12 7:32 ` Thomas Zimmermann
2026-05-09 3:23 ` [PATCH for drm-misc-fixes v6 4/4] drm/hisilicon/hibmc: use clock to look up the PLL value Yongbang Shi
2026-05-12 7:31 ` Thomas Zimmermann
2026-05-12 7:34 ` [PATCH for drm-misc-fixes v6 0/4] Fix some bugs in the hibmc driver Thomas Zimmermann
2026-05-12 12:12 ` Yongbang Shi [this message]
2026-05-13 7:28 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d017d6e8-1035-4088-a543-6fc00f2c29c3@huawei.com \
--to=shiyongbang@huawei.com \
--cc=airlied@gmail.com \
--cc=chenjianmin@huawei.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fengsheng5@huawei.com \
--cc=helin52@h-partners.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=liangjian010@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=tiantao6@hisilicon.com \
--cc=tzimmermann@suse.de \
--cc=xinliang.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®