Re: [PATCH v2 2/8] staging: erofs: add compacted compression indexes support

[Gao Xiang <gaoxiang25@huawei.com>]

On 2019/6/21 15:53, Chao Yu wrote:
> On 2019/6/21 0:07, Gao Xiang wrote:
>> This patch aims at compacted compression indexes:
>>  1) cleanup z_erofs_map_blocks_iter and move into zmap.c;
>>  2) add compacted 4/2B decoding support.
>>
>> On kirin980 platform, sequential read is increased about
>> 6% (725MiB/s -> 770MiB/s) on enwik9 dataset if compacted 2B
>> feature is enabled.
>>
>> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
> 
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
> 
>> +static int vle_legacy_load_cluster_from_disk(struct z_erofs_maprecorder *m,
>> +					     unsigned long lcn)
>> +{
>> +	struct inode *const inode = m->inode;
>> +	struct erofs_vnode *const vi = EROFS_V(inode);
>> +	const erofs_off_t ibase = iloc(EROFS_I_SB(inode), vi->nid);
>> +	const erofs_off_t pos = Z_EROFS_VLE_EXTENT_ALIGN(ibase +
>> +							 vi->inode_isize +
>> +							 vi->xattr_isize) +
>> +		16 + lcn * sizeof(struct z_erofs_vle_decompressed_index);
> 
> use macro instead of raw number?

OK, I will wrap it up in patch v3 too.

Thanks,
Gao Xiang

> 
> Thanks,
>