From: Andreas Larsson <andreas@gaisler.com>
To: Sang-Heon Jeon <ekffu200098@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH 1/2] sparc32: remove redundant memset in arch_mm_preinit()
Date: Fri, 9 Oct 2026 16:40:11 +0200 [thread overview]
Message-ID: <d0524359-d497-4396-9fa6-aacc6ce4520f@gaisler.com> (raw)
In-Reply-To: <20260827145437.490605-2-ekffu200098@gmail.com>
On 2026-08-27 16:54, Sang-Heon Jeon wrote:
> memblock_alloc() returns zeroed memory, so the memset after the
> allocation is redundant.
>
> No functional change.
>
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> ---
> arch/sparc/mm/init_32.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/sparc/mm/init_32.c b/arch/sparc/mm/init_32.c
> index e0e66f91ceeb..b4f31d41d665 100644
> --- a/arch/sparc/mm/init_32.c
> +++ b/arch/sparc/mm/init_32.c
> @@ -255,7 +255,6 @@ void __init arch_mm_preinit(void)
> prom_printf("mem_init: Cannot alloc valid_addr_bitmap.\n");
> prom_halt();
> }
> - memset(sparc_valid_addr_bitmap, 0, i << 2);
>
> taint_real_pages();
> }
No need for this anymore as this code is gone on my for-next thanks to
commit 91c897e01883 ("sparc32: drop unused valid address bitmap").
Cheers,
Andreas
next prev parent reply other threads:[~2026-10-09 14:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 14:54 [PATCH 0/2] sparc32: remove redundant memsets after memblock allocations Sang-Heon Jeon
2026-08-27 14:54 ` [PATCH 1/2] sparc32: remove redundant memset in arch_mm_preinit() Sang-Heon Jeon
2026-10-09 14:40 ` Andreas Larsson [this message]
2026-08-27 14:54 ` [PATCH 2/2] sparc32: remove redundant memset in srmmu_nocache_init() Sang-Heon Jeon
2026-10-09 14:41 ` Andreas Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0524359-d497-4396-9fa6-aacc6ce4520f@gaisler.com \
--to=andreas@gaisler.com \
--cc=davem@davemloft.net \
--cc=ekffu200098@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®