mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Larsson <andreas@gaisler.com>
To: Sang-Heon Jeon <ekffu200098@gmail.com>,
	"David S. Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH 2/2] sparc32: remove redundant memset in srmmu_nocache_init()
Date: Fri, 9 Oct 2026 16:41:23 +0200	[thread overview]
Message-ID: <eac21764-dbb1-441c-b42e-aacbd2ca0d67@gaisler.com> (raw)
In-Reply-To: <20260827145437.490605-3-ekffu200098@gmail.com>

On 2026-08-27 16:54, Sang-Heon Jeon wrote:
> memblock_alloc_or_panic() returns zeroed memory, so the memset after
> the allocation is redundant.
> 
> No functional change.
> 
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> ---
>  arch/sparc/mm/srmmu.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/sparc/mm/srmmu.c b/arch/sparc/mm/srmmu.c
> index 9a74902ad181..f9a92a07a255 100644
> --- a/arch/sparc/mm/srmmu.c
> +++ b/arch/sparc/mm/srmmu.c
> @@ -279,7 +279,6 @@ static void __init srmmu_nocache_init(void)
>  
>  	srmmu_nocache_pool = memblock_alloc_or_panic(srmmu_nocache_size,
>  					    SRMMU_NOCACHE_ALIGN_MAX);
> -	memset(srmmu_nocache_pool, 0, srmmu_nocache_size);
>  
>  	srmmu_nocache_bitmap =
>  		memblock_alloc_or_panic(BITS_TO_LONGS(bitmap_bits) * sizeof(long),

Reviewed-by: Andreas Larsson <andreas@gaisler.com>

Picking this up to my for-next.

Thanks,
Andreas


      reply	other threads:[~2026-10-09 14:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27 14:54 [PATCH 0/2] sparc32: remove redundant memsets after memblock allocations Sang-Heon Jeon
2026-08-27 14:54 ` [PATCH 1/2] sparc32: remove redundant memset in arch_mm_preinit() Sang-Heon Jeon
2026-10-09 14:40   ` Andreas Larsson
2026-08-27 14:54 ` [PATCH 2/2] sparc32: remove redundant memset in srmmu_nocache_init() Sang-Heon Jeon
2026-10-09 14:41   ` Andreas Larsson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eac21764-dbb1-441c-b42e-aacbd2ca0d67@gaisler.com \
    --to=andreas@gaisler.com \
    --cc=davem@davemloft.net \
    --cc=ekffu200098@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®