* [PATCH] phy: tegra: select USB_COMMON
@ 2018-05-30 21:33 Arnd Bergmann
2018-05-30 22:12 ` Dmitry Osipenko
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-05-30 21:33 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman
Cc: Dmitry Osipenko, Thierry Reding, Arnd Bergmann, linux-usb, linux-kernel
A built-in PHY driver cannot link against modular USB core code:
drivers/usb/phy/phy-tegra-usb.o: In function `tegra_usb_phy_probe':
phy-tegra-usb.c:(.text+0x6bc): undefined reference to `usb_get_dr_mode'
This uses a 'select' statement in Kconfig like we have for other such
PHY drivers.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/usb/phy/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
index b9b0a44be679..d7312eed6088 100644
--- a/drivers/usb/phy/Kconfig
+++ b/drivers/usb/phy/Kconfig
@@ -162,6 +162,7 @@ config USB_MXS_PHY
config USB_TEGRA_PHY
tristate "NVIDIA Tegra USB PHY Driver"
depends on ARCH_TEGRA
+ select USB_COMMON
select USB_PHY
select USB_ULPI
help
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: tegra: select USB_COMMON
2018-05-30 21:33 [PATCH] phy: tegra: select USB_COMMON Arnd Bergmann
@ 2018-05-30 22:12 ` Dmitry Osipenko
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Osipenko @ 2018-05-30 22:12 UTC (permalink / raw)
To: Arnd Bergmann, Felipe Balbi, Greg Kroah-Hartman
Cc: Thierry Reding, linux-usb, linux-kernel
On 31.05.2018 00:33, Arnd Bergmann wrote:
> A built-in PHY driver cannot link against modular USB core code:
>
> drivers/usb/phy/phy-tegra-usb.o: In function `tegra_usb_phy_probe':
> phy-tegra-usb.c:(.text+0x6bc): undefined reference to `usb_get_dr_mode'
>
> This uses a 'select' statement in Kconfig like we have for other such
> PHY drivers.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/usb/phy/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> index b9b0a44be679..d7312eed6088 100644
> --- a/drivers/usb/phy/Kconfig
> +++ b/drivers/usb/phy/Kconfig
> @@ -162,6 +162,7 @@ config USB_MXS_PHY
> config USB_TEGRA_PHY
> tristate "NVIDIA Tegra USB PHY Driver"
> depends on ARCH_TEGRA
> + select USB_COMMON
> select USB_PHY
> select USB_ULPI
> help
>
Thank you!
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-30 22:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-30 21:33 [PATCH] phy: tegra: select USB_COMMON Arnd Bergmann
2018-05-30 22:12 ` Dmitry Osipenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®