mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Santos <Jonathan.Santos@analog.com>
To: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>
Cc: Sergiu Cuciurean <sergiu.cuciurean@analog.com>, <lars@metafoo.de>,
	<Michael.Hennerich@analog.com>, <marcelo.schmitt@analog.com>,
	<jic23@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <linus.walleij@linaro.org>,
	<brgl@bgdev.pl>, <lgirdwood@gmail.com>, <broonie@kernel.org>,
	<dlechner@baylibre.com>, <marcelo.schmitt1@gmail.com>,
	<jonath4nns@gmail.com>,
	Jonathan Santos <Jonathan.Santos@analog.com>
Subject: [PATCH v4 10/17] iio: adc: ad7768-1: Move buffer allocation to a separate function
Date: Thu, 6 Mar 2025 18:02:46 -0300	[thread overview]
Message-ID: <d078cdcf3a8bdd60ec3b9b6822e9705bf3f98bfa.1741268122.git.Jonathan.Santos@analog.com> (raw)
In-Reply-To: <cover.1741268122.git.Jonathan.Santos@analog.com>

From: Sergiu Cuciurean <sergiu.cuciurean@analog.com>

This change moves the buffer allocation in a separate function, making
space for adding another type of iio buffer if needed.

Reviewed-by: David Lechner <dlechner@baylibre.com>
Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
Signed-off-by: Jonathan Santos <Jonathan.Santos@analog.com>
---
v4 Changes:
* None.

v3 Changes:
* Added missing SoB.

v2 Changes:
* Interrupt and completion moved out from ad7768_triggered_buffer_alloc(). 
---
 drivers/iio/adc/ad7768-1.c | 44 ++++++++++++++++++++++----------------
 1 file changed, 26 insertions(+), 18 deletions(-)

diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
index 86f44d28c478..e88e9431bb7a 100644
--- a/drivers/iio/adc/ad7768-1.c
+++ b/drivers/iio/adc/ad7768-1.c
@@ -619,6 +619,31 @@ static int ad7768_set_channel_label(struct iio_dev *indio_dev,
 	return 0;
 }
 
+static int ad7768_triggered_buffer_alloc(struct iio_dev *indio_dev)
+{
+	struct ad7768_state *st = iio_priv(indio_dev);
+	int ret;
+
+	st->trig = devm_iio_trigger_alloc(indio_dev->dev.parent, "%s-dev%d",
+					  indio_dev->name,
+					  iio_device_id(indio_dev));
+	if (!st->trig)
+		return -ENOMEM;
+
+	st->trig->ops = &ad7768_trigger_ops;
+	iio_trigger_set_drvdata(st->trig, indio_dev);
+	ret = devm_iio_trigger_register(indio_dev->dev.parent, st->trig);
+	if (ret)
+		return ret;
+
+	indio_dev->trig = iio_trigger_get(st->trig);
+
+	return devm_iio_triggered_buffer_setup(indio_dev->dev.parent, indio_dev,
+					       &iio_pollfunc_store_time,
+					       &ad7768_trigger_handler,
+					       &ad7768_buffer_ops);
+}
+
 static int ad7768_probe(struct spi_device *spi)
 {
 	struct ad7768_state *st;
@@ -689,20 +714,6 @@ static int ad7768_probe(struct spi_device *spi)
 		return ret;
 	}
 
-	st->trig = devm_iio_trigger_alloc(&spi->dev, "%s-dev%d",
-					  indio_dev->name,
-					  iio_device_id(indio_dev));
-	if (!st->trig)
-		return -ENOMEM;
-
-	st->trig->ops = &ad7768_trigger_ops;
-	iio_trigger_set_drvdata(st->trig, indio_dev);
-	ret = devm_iio_trigger_register(&spi->dev, st->trig);
-	if (ret)
-		return ret;
-
-	indio_dev->trig = iio_trigger_get(st->trig);
-
 	init_completion(&st->completion);
 
 	ret = ad7768_set_channel_label(indio_dev, ARRAY_SIZE(ad7768_channels));
@@ -716,10 +727,7 @@ static int ad7768_probe(struct spi_device *spi)
 	if (ret)
 		return ret;
 
-	ret = devm_iio_triggered_buffer_setup(&spi->dev, indio_dev,
-					      &iio_pollfunc_store_time,
-					      &ad7768_trigger_handler,
-					      &ad7768_buffer_ops);
+	ret = ad7768_triggered_buffer_alloc(indio_dev);
 	if (ret)
 		return ret;
 
-- 
2.34.1


  parent reply	other threads:[~2025-03-06 21:03 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-06 21:00 [PATCH v4 00/17] iio: adc: ad7768-1: Add features, improvements, and fixes Jonathan Santos
2025-03-06 21:00 ` [PATCH v4 01/17] iio: adc: ad7768-1: Fix conversion result sign Jonathan Santos
2025-03-08 13:13   ` Jonathan Cameron
2025-03-06 21:00 ` [PATCH v4 02/17] iio: adc: ad7768-1: set MOSI idle state to prevent accidental reset Jonathan Santos
2025-03-07 12:06   ` Marcelo Schmitt
2025-03-08 13:15     ` Jonathan Cameron
2025-03-31 13:16     ` Jonathan Santos
2025-03-06 21:00 ` [PATCH v4 03/17] dt-bindings: iio: adc: ad7768-1: add trigger-sources property Jonathan Santos
2025-03-08 13:17   ` Jonathan Cameron
2025-04-01 16:15   ` David Lechner
2025-03-06 21:01 ` [PATCH v4 04/17] dt-bindings: iio: adc: ad7768-1: Document GPIO controller Jonathan Santos
2025-03-07 13:46   ` Bartosz Golaszewski
2025-03-14 10:22   ` Linus Walleij
2025-03-06 21:01 ` [PATCH v4 05/17] dt-bindings: iio: adc: ad7768-1: document regulator provider property Jonathan Santos
2025-04-01 16:20   ` David Lechner
2025-03-06 21:01 ` [PATCH v4 06/17] Documentation: ABI: add wideband filter type to sysfs-bus-iio Jonathan Santos
2025-03-07 12:45   ` Marcelo Schmitt
2025-03-08 13:20     ` Jonathan Cameron
2025-03-06 21:01 ` [PATCH v4 07/17] iio: adc: ad7768-1: remove unnecessary locking Jonathan Santos
2025-03-08 13:24   ` Jonathan Cameron
2025-03-06 21:02 ` [PATCH v4 08/17] iio: adc: ad7768-1: convert driver to use regmap Jonathan Santos
2025-03-07 13:20   ` Marcelo Schmitt
2025-03-08 13:27     ` Jonathan Cameron
2025-04-01 16:31   ` David Lechner
2025-04-01 16:38     ` David Lechner
2025-03-06 21:02 ` [PATCH v4 09/17] iio: adc: ad7768-1: Add reset gpio Jonathan Santos
2025-03-07 13:42   ` Marcelo Schmitt
2025-03-08 13:30     ` Jonathan Cameron
2025-03-06 21:02 ` Jonathan Santos [this message]
2025-03-07 13:52   ` [PATCH v4 10/17] iio: adc: ad7768-1: Move buffer allocation to a separate function Marcelo Schmitt
2025-03-08 13:33   ` Jonathan Cameron
2025-03-06 21:02 ` [PATCH v4 11/17] iio: adc: ad7768-1: add regulator to control VCM output Jonathan Santos
2025-03-07 14:32   ` Marcelo Schmitt
2025-03-08 13:08     ` Jonathan Cameron
2025-03-08 13:38   ` Jonathan Cameron
2025-03-06 21:03 ` [PATCH v4 12/17] iio: adc: ad7768-1: Add GPIO controller support Jonathan Santos
2025-03-07 13:45   ` Bartosz Golaszewski
2025-03-08 13:41   ` Jonathan Cameron
2025-04-04 21:12   ` Marcelo Schmitt
2025-03-06 21:03 ` [PATCH v4 13/17] iio: adc: ad7768-1: add multiple scan types to support 16-bits mode Jonathan Santos
2025-03-06 21:03 ` [PATCH v4 14/17] iio: adc: ad7768-1: add support for Synchronization over SPI Jonathan Santos
2025-04-01 17:02   ` David Lechner
2025-03-06 21:04 ` [PATCH v4 15/17] iio: adc: ad7768-1: replace manual attribute declaration Jonathan Santos
2025-03-07 14:49   ` Marcelo Schmitt
2025-04-01 17:05   ` David Lechner
2025-03-06 21:04 ` [PATCH v4 16/17] iio: adc: ad7768-1: add filter type and oversampling ratio attributes Jonathan Santos
2025-03-08 13:56   ` Jonathan Cameron
2025-04-01  0:18     ` Jonathan Santos
2025-04-06 10:49       ` Jonathan Cameron
2025-03-06 21:04 ` [PATCH v4 17/17] iio: adc: ad7768-1: add low pass -3dB cutoff attribute Jonathan Santos
2025-03-07 15:12   ` Marcelo Schmitt
2025-04-01 17:12   ` David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d078cdcf3a8bdd60ec3b9b6822e9705bf3f98bfa.1741268122.git.Jonathan.Santos@analog.com \
    --to=jonathan.santos@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=jonath4nns@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=marcelo.schmitt@analog.com \
    --cc=robh@kernel.org \
    --cc=sergiu.cuciurean@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®