mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] media: amphion: fix decoder's interlaced field
@ 2022-04-12 11:01 Ming Qian
  2022-04-13 18:26 ` Nicolas Dufresne
  2022-04-13 18:36 ` Fabio Estevam
  0 siblings, 2 replies; 6+ messages in thread
From: Ming Qian @ 2022-04-12 11:01 UTC (permalink / raw)
  To: mchehab, shawnguo
  Cc: hverkuil-cisco, robh+dt, s.hauer, kernel, festevam, linux-imx,
	aisheng.dong, linux-media, linux-kernel, linux-arm-kernel

For interlaced frame, the amphion vpu will store the
two fields sequential into one buffer, top-bottom order
so the field should be set to V4L2_FIELD_SEQ_TB.
fix the previous bug that set it to V4L2_FIELD_SEQ_BT wrongly.

Signed-off-by: Ming Qian <ming.qian@nxp.com>
---
 drivers/media/platform/amphion/vdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/amphion/vdec.c b/drivers/media/platform/amphion/vdec.c
index 09628dd0c855..0a1976852b0d 100644
--- a/drivers/media/platform/amphion/vdec.c
+++ b/drivers/media/platform/amphion/vdec.c
@@ -804,7 +804,7 @@ static void vdec_init_fmt(struct vpu_inst *inst)
 	if (vdec->codec_info.progressive)
 		inst->cap_format.field = V4L2_FIELD_NONE;
 	else
-		inst->cap_format.field = V4L2_FIELD_SEQ_BT;
+		inst->cap_format.field = V4L2_FIELD_SEQ_TB;
 	if (vdec->codec_info.color_primaries == V4L2_COLORSPACE_DEFAULT)
 		vdec->codec_info.color_primaries = V4L2_COLORSPACE_REC709;
 	if (vdec->codec_info.transfer_chars == V4L2_XFER_FUNC_DEFAULT)
-- 
2.35.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] media: amphion: fix decoder's interlaced field
  2022-04-12 11:01 [PATCH v2] media: amphion: fix decoder's interlaced field Ming Qian
@ 2022-04-13 18:26 ` Nicolas Dufresne
  2022-04-13 18:36 ` Fabio Estevam
  1 sibling, 0 replies; 6+ messages in thread
From: Nicolas Dufresne @ 2022-04-13 18:26 UTC (permalink / raw)
  To: Ming Qian, mchehab, shawnguo
  Cc: hverkuil-cisco, robh+dt, s.hauer, kernel, festevam, linux-imx,
	aisheng.dong, linux-media, linux-kernel, linux-arm-kernel

Le mardi 12 avril 2022 à 19:01 +0800, Ming Qian a écrit :
> For interlaced frame, the amphion vpu will store the
> two fields sequential into one buffer, top-bottom order
> so the field should be set to V4L2_FIELD_SEQ_TB.
> fix the previous bug that set it to V4L2_FIELD_SEQ_BT wrongly.
> 
> Signed-off-by: Ming Qian <ming.qian@nxp.com>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> ---
>  drivers/media/platform/amphion/vdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/amphion/vdec.c b/drivers/media/platform/amphion/vdec.c
> index 09628dd0c855..0a1976852b0d 100644
> --- a/drivers/media/platform/amphion/vdec.c
> +++ b/drivers/media/platform/amphion/vdec.c
> @@ -804,7 +804,7 @@ static void vdec_init_fmt(struct vpu_inst *inst)
>  	if (vdec->codec_info.progressive)
>  		inst->cap_format.field = V4L2_FIELD_NONE;
>  	else
> -		inst->cap_format.field = V4L2_FIELD_SEQ_BT;
> +		inst->cap_format.field = V4L2_FIELD_SEQ_TB;
>  	if (vdec->codec_info.color_primaries == V4L2_COLORSPACE_DEFAULT)
>  		vdec->codec_info.color_primaries = V4L2_COLORSPACE_REC709;
>  	if (vdec->codec_info.transfer_chars == V4L2_XFER_FUNC_DEFAULT)


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] media: amphion: fix decoder's interlaced field
  2022-04-12 11:01 [PATCH v2] media: amphion: fix decoder's interlaced field Ming Qian
  2022-04-13 18:26 ` Nicolas Dufresne
@ 2022-04-13 18:36 ` Fabio Estevam
  2022-04-14  1:52   ` [EXT] " Ming Qian
  1 sibling, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2022-04-13 18:36 UTC (permalink / raw)
  To: Ming Qian
  Cc: Mauro Carvalho Chehab, Shawn Guo, Hans Verkuil, Rob Herring,
	Sascha Hauer, Sascha Hauer, NXP Linux Team, Dong Aisheng,
	linux-media, linux-kernel,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

Hi Ming,

On Tue, Apr 12, 2022 at 8:02 AM Ming Qian <ming.qian@nxp.com> wrote:
>
> For interlaced frame, the amphion vpu will store the
> two fields sequential into one buffer, top-bottom order
> so the field should be set to V4L2_FIELD_SEQ_TB.
> fix the previous bug that set it to V4L2_FIELD_SEQ_BT wrongly.
>
> Signed-off-by: Ming Qian <ming.qian@nxp.com>

Missing Fixes tag?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [EXT] Re: [PATCH v2] media: amphion: fix decoder's interlaced field
  2022-04-13 18:36 ` Fabio Estevam
@ 2022-04-14  1:52   ` Ming Qian
  2022-04-14  2:00     ` Fabio Estevam
  0 siblings, 1 reply; 6+ messages in thread
From: Ming Qian @ 2022-04-14  1:52 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Mauro Carvalho Chehab, Shawn Guo, Hans Verkuil, Rob Herring,
	Sascha Hauer, Sascha Hauer, dl-linux-imx, Aisheng Dong,
	linux-media, linux-kernel,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

> From: Fabio Estevam [mailto:festevam@gmail.com]
> Sent: Thursday, April 14, 2022 2:36 AM
> To: Ming Qian <ming.qian@nxp.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Shawn Guo
> <shawnguo@kernel.org>; Hans Verkuil <hverkuil-cisco@xs4all.nl>; Rob Herring
> <robh+dt@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>; Sascha
> Hauer <kernel@pengutronix.de>; dl-linux-imx <linux-imx@nxp.com>; Aisheng
> Dong <aisheng.dong@nxp.com>; linux-media <linux-media@vger.kernel.org>;
> linux-kernel <linux-kernel@vger.kernel.org>; moderated list:ARM/FREESCALE
> IMX / MXC ARM ARCHITECTURE <linux-arm-kernel@lists.infradead.org>
> Subject: [EXT] Re: [PATCH v2] media: amphion: fix decoder's interlaced field
> 
> Caution: EXT Email
> 
> Hi Ming,
> 
> On Tue, Apr 12, 2022 at 8:02 AM Ming Qian <ming.qian@nxp.com> wrote:
> >
> > For interlaced frame, the amphion vpu will store the two fields
> > sequential into one buffer, top-bottom order so the field should be
> > set to V4L2_FIELD_SEQ_TB.
> > fix the previous bug that set it to V4L2_FIELD_SEQ_BT wrongly.
> >
> > Signed-off-by: Ming Qian <ming.qian@nxp.com>
> 
> Missing Fixes tag?
Hi Fabio,
    I'm sorry I missed it, and would you please give an example of the fixes tag?
Ming

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [EXT] Re: [PATCH v2] media: amphion: fix decoder's interlaced field
  2022-04-14  1:52   ` [EXT] " Ming Qian
@ 2022-04-14  2:00     ` Fabio Estevam
  2022-04-14  2:08       ` Ming Qian
  0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2022-04-14  2:00 UTC (permalink / raw)
  To: Ming Qian
  Cc: Mauro Carvalho Chehab, Shawn Guo, Hans Verkuil, Rob Herring,
	Sascha Hauer, Sascha Hauer, dl-linux-imx, Aisheng Dong,
	linux-media, linux-kernel,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

Hi Ming,

On Wed, Apr 13, 2022 at 10:52 PM Ming Qian <ming.qian@nxp.com> wrote:

> Hi Fabio,
>     I'm sorry I missed it, and would you please give an example of the fixes tag?

You should add the following line above your Signed-off-by line:

Fixes: 6de8d628df6e ("media: amphion: add v4l2 m2m vpu decoder stateful driver")
Signed-off-by: Ming Qian <ming.qian@nxp.com>

The Fixes line should be in a single line, not splitter in two lines.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [EXT] Re: [PATCH v2] media: amphion: fix decoder's interlaced field
  2022-04-14  2:00     ` Fabio Estevam
@ 2022-04-14  2:08       ` Ming Qian
  0 siblings, 0 replies; 6+ messages in thread
From: Ming Qian @ 2022-04-14  2:08 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: Mauro Carvalho Chehab, Shawn Guo, Hans Verkuil, Rob Herring,
	Sascha Hauer, Sascha Hauer, dl-linux-imx, Aisheng Dong,
	linux-media, linux-kernel,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

> From: Fabio Estevam [mailto:festevam@gmail.com]
> Sent: Thursday, April 14, 2022 10:00 AM
> To: Ming Qian <ming.qian@nxp.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Shawn Guo
> <shawnguo@kernel.org>; Hans Verkuil <hverkuil-cisco@xs4all.nl>; Rob Herring
> <robh+dt@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>; Sascha
> Hauer <kernel@pengutronix.de>; dl-linux-imx <linux-imx@nxp.com>; Aisheng
> Dong <aisheng.dong@nxp.com>; linux-media <linux-media@vger.kernel.org>;
> linux-kernel <linux-kernel@vger.kernel.org>; moderated list:ARM/FREESCALE
> IMX / MXC ARM ARCHITECTURE <linux-arm-kernel@lists.infradead.org>
> Subject: Re: [EXT] Re: [PATCH v2] media: amphion: fix decoder's interlaced field
> 
> Caution: EXT Email
> 
> Hi Ming,
> 
> On Wed, Apr 13, 2022 at 10:52 PM Ming Qian <ming.qian@nxp.com> wrote:
> 
> > Hi Fabio,
> >     I'm sorry I missed it, and would you please give an example of the fixes
> tag?
> 
> You should add the following line above your Signed-off-by line:
> 
> Fixes: 6de8d628df6e ("media: amphion: add v4l2 m2m vpu decoder stateful
> driver")
> Signed-off-by: Ming Qian <ming.qian@nxp.com>
> 
> The Fixes line should be in a single line, not splitter in two lines.

Hi Fabio,

    Thanks very much, I'll add this fixes tag, and I will pay attention to this issue later.

Ming

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-04-14  2:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-12 11:01 [PATCH v2] media: amphion: fix decoder's interlaced field Ming Qian
2022-04-13 18:26 ` Nicolas Dufresne
2022-04-13 18:36 ` Fabio Estevam
2022-04-14  1:52   ` [EXT] " Ming Qian
2022-04-14  2:00     ` Fabio Estevam
2022-04-14  2:08       ` Ming Qian

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®