* [PATCH] arm64: dts: st: Fix SAI addresses on stm32mp251
@ 2026-04-11 13:02 Marek Vasut
2026-04-15 17:00 ` Olivier MOYSAN
2026-06-01 8:01 ` Alexandre TORGUE
0 siblings, 2 replies; 3+ messages in thread
From: Marek Vasut @ 2026-04-11 13:02 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Alexandre Torgue, Conor Dooley, Krzysztof Kozlowski,
Maxime Coquelin, Olivier Moysan, Rob Herring, devicetree,
linux-kernel, linux-stm32
The second field of SAI register addresses should be within 0x3f0 bytes
from the start of the SAI register addresses, the second field describes
the ID registers which are at that addrses. Currently, the second field
does not match RM, fix it.
Fixes: bf26d75a95f1 ("arm64: dts: st: add sai support on stm32mp251")
Signed-off-by: Marek Vasut <marex@nabladev.com>
---
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Olivier Moysan <olivier.moysan@foss.st.com>
Cc: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
---
arch/arm64/boot/dts/st/stm32mp251.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi
index 673fbc5632e69..9c63fdb5a885a 100644
--- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
+++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
@@ -1202,7 +1202,7 @@ spi5: spi@40280000 {
sai1: sai@40290000 {
compatible = "st,stm32mp25-sai";
- reg = <0x40290000 0x4>, <0x4029a3f0 0x10>;
+ reg = <0x40290000 0x4>, <0x402903f0 0x10>;
ranges = <0 0x40290000 0x400>;
#address-cells = <1>;
#size-cells = <1>;
@@ -1236,7 +1236,7 @@ sai1b: audio-controller@40290024 {
sai2: sai@402a0000 {
compatible = "st,stm32mp25-sai";
- reg = <0x402a0000 0x4>, <0x402aa3f0 0x10>;
+ reg = <0x402a0000 0x4>, <0x402a03f0 0x10>;
ranges = <0 0x402a0000 0x400>;
#address-cells = <1>;
#size-cells = <1>;
@@ -1270,7 +1270,7 @@ sai2b: audio-controller@402a0024 {
sai3: sai@402b0000 {
compatible = "st,stm32mp25-sai";
- reg = <0x402b0000 0x4>, <0x402ba3f0 0x10>;
+ reg = <0x402b0000 0x4>, <0x402b03f0 0x10>;
ranges = <0 0x402b0000 0x400>;
#address-cells = <1>;
#size-cells = <1>;
@@ -1362,7 +1362,7 @@ usart1: serial@40330000 {
sai4: sai@40340000 {
compatible = "st,stm32mp25-sai";
- reg = <0x40340000 0x4>, <0x4034a3f0 0x10>;
+ reg = <0x40340000 0x4>, <0x403403f0 0x10>;
ranges = <0 0x40340000 0x400>;
#address-cells = <1>;
#size-cells = <1>;
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: st: Fix SAI addresses on stm32mp251
2026-04-11 13:02 [PATCH] arm64: dts: st: Fix SAI addresses on stm32mp251 Marek Vasut
@ 2026-04-15 17:00 ` Olivier MOYSAN
2026-06-01 8:01 ` Alexandre TORGUE
1 sibling, 0 replies; 3+ messages in thread
From: Olivier MOYSAN @ 2026-04-15 17:00 UTC (permalink / raw)
To: Marek Vasut, linux-arm-kernel
Cc: Alexandre Torgue, Conor Dooley, Krzysztof Kozlowski,
Maxime Coquelin, Rob Herring, devicetree, linux-kernel,
linux-stm32
Hi Marek,
On 4/11/26 15:02, Marek Vasut wrote:
> The second field of SAI register addresses should be within 0x3f0 bytes
> from the start of the SAI register addresses, the second field describes
> the ID registers which are at that addrses. Currently, the second field
> does not match RM, fix it.
>
> Fixes: bf26d75a95f1 ("arm64: dts: st: add sai support on stm32mp251")
> Signed-off-by: Marek Vasut <marex@nabladev.com>
> ---
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Olivier Moysan <olivier.moysan@foss.st.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> ---
> arch/arm64/boot/dts/st/stm32mp251.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> index 673fbc5632e69..9c63fdb5a885a 100644
> --- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> @@ -1202,7 +1202,7 @@ spi5: spi@40280000 {
>
> sai1: sai@40290000 {
> compatible = "st,stm32mp25-sai";
> - reg = <0x40290000 0x4>, <0x4029a3f0 0x10>;
> + reg = <0x40290000 0x4>, <0x402903f0 0x10>;
> ranges = <0 0x40290000 0x400>;
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -1236,7 +1236,7 @@ sai1b: audio-controller@40290024 {
>
> sai2: sai@402a0000 {
> compatible = "st,stm32mp25-sai";
> - reg = <0x402a0000 0x4>, <0x402aa3f0 0x10>;
> + reg = <0x402a0000 0x4>, <0x402a03f0 0x10>;
> ranges = <0 0x402a0000 0x400>;
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -1270,7 +1270,7 @@ sai2b: audio-controller@402a0024 {
>
> sai3: sai@402b0000 {
> compatible = "st,stm32mp25-sai";
> - reg = <0x402b0000 0x4>, <0x402ba3f0 0x10>;
> + reg = <0x402b0000 0x4>, <0x402b03f0 0x10>;
> ranges = <0 0x402b0000 0x400>;
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -1362,7 +1362,7 @@ usart1: serial@40330000 {
>
> sai4: sai@40340000 {
> compatible = "st,stm32mp25-sai";
> - reg = <0x40340000 0x4>, <0x4034a3f0 0x10>;
> + reg = <0x40340000 0x4>, <0x403403f0 0x10>;
> ranges = <0 0x40340000 0x400>;
> #address-cells = <1>;
> #size-cells = <1>;
Reviewed-by: Olivier Moysan <olivier.moysan@foss.st.com>
Thanks for your patch
BRs
Olivier
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: st: Fix SAI addresses on stm32mp251
2026-04-11 13:02 [PATCH] arm64: dts: st: Fix SAI addresses on stm32mp251 Marek Vasut
2026-04-15 17:00 ` Olivier MOYSAN
@ 2026-06-01 8:01 ` Alexandre TORGUE
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre TORGUE @ 2026-06-01 8:01 UTC (permalink / raw)
To: Marek Vasut, linux-arm-kernel
Cc: Conor Dooley, Krzysztof Kozlowski, Maxime Coquelin,
Olivier Moysan, Rob Herring, devicetree, linux-kernel,
linux-stm32
Hi Marek
On 4/11/26 15:02, Marek Vasut wrote:
> The second field of SAI register addresses should be within 0x3f0 bytes
> from the start of the SAI register addresses, the second field describes
> the ID registers which are at that addrses. Currently, the second field
> does not match RM, fix it.
>
> Fixes: bf26d75a95f1 ("arm64: dts: st: add sai support on stm32mp251")
> Signed-off-by: Marek Vasut <marex@nabladev.com>
> ---
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Olivier Moysan <olivier.moysan@foss.st.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> ---
> arch/arm64/boot/dts/st/stm32mp251.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> index 673fbc5632e69..9c63fdb5a885a 100644
> --- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> @@ -1202,7 +1202,7 @@ spi5: spi@40280000 {
>
> sai1: sai@40290000 {
> compatible = "st,stm32mp25-sai";
> - reg = <0x40290000 0x4>, <0x4029a3f0 0x10>;
> + reg = <0x40290000 0x4>, <0x402903f0 0x10>;
> ranges = <0 0x40290000 0x400>;
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -1236,7 +1236,7 @@ sai1b: audio-controller@40290024 {
>
> sai2: sai@402a0000 {
> compatible = "st,stm32mp25-sai";
> - reg = <0x402a0000 0x4>, <0x402aa3f0 0x10>;
> + reg = <0x402a0000 0x4>, <0x402a03f0 0x10>;
> ranges = <0 0x402a0000 0x400>;
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -1270,7 +1270,7 @@ sai2b: audio-controller@402a0024 {
>
> sai3: sai@402b0000 {
> compatible = "st,stm32mp25-sai";
> - reg = <0x402b0000 0x4>, <0x402ba3f0 0x10>;
> + reg = <0x402b0000 0x4>, <0x402b03f0 0x10>;
> ranges = <0 0x402b0000 0x400>;
> #address-cells = <1>;
> #size-cells = <1>;
> @@ -1362,7 +1362,7 @@ usart1: serial@40330000 {
>
> sai4: sai@40340000 {
> compatible = "st,stm32mp25-sai";
> - reg = <0x40340000 0x4>, <0x4034a3f0 0x10>;
> + reg = <0x40340000 0x4>, <0x403403f0 0x10>;
> ranges = <0 0x40340000 0x400>;
> #address-cells = <1>;
> #size-cells = <1>;
Applied on stm32-next.
thanks!
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-01 8:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-11 13:02 [PATCH] arm64: dts: st: Fix SAI addresses on stm32mp251 Marek Vasut
2026-04-15 17:00 ` Olivier MOYSAN
2026-06-01 8:01 ` Alexandre TORGUE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®