mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: netdev@vger.kernel.org,
	Ajit Khaparde <ajit.khaparde@broadcom.com>,
	Sathya Perla <sathya.perla@broadcom.com>,
	Somnath Kotur <somnath.kotur@broadcom.com>,
	Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/2] benet: Delete an error message for a failed memory allocation in be_alloc_work()
Date: Mon, 1 Jan 2018 18:53:41 +0100	[thread overview]
Message-ID: <d0ce16d9-9fd0-dcf0-c78b-70efb2d76db1@users.sourceforge.net> (raw)
In-Reply-To: <86e577a3-77a4-2e74-dd2d-4d63e90ffb72@users.sourceforge.net>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 1 Jan 2018 18:38:06 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/net/ethernet/emulex/benet/be_main.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index c6e859a27ee6..475d94762306 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -4930,11 +4930,8 @@ static struct be_cmd_work *be_alloc_work(struct be_adapter *adapter,
 	struct be_cmd_work *work;
 
 	work = kzalloc(sizeof(*work), GFP_ATOMIC);
-	if (!work) {
-		dev_err(&adapter->pdev->dev,
-			"be_work memory allocation failed\n");
+	if (!work)
 		return NULL;
-	}
 
 	INIT_WORK(&work->work, func);
 	work->adapter = adapter;
-- 
2.15.1

  reply	other threads:[~2018-01-01 17:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-01 17:52 [PATCH 0/2] benet: Adjustments for two function implementations SF Markus Elfring
2018-01-01 17:53 ` SF Markus Elfring [this message]
2018-01-01 17:54 ` [PATCH 2/2] benet: Delete an unnecessary return statement in be_work_add_vxlan_port() SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0ce16d9-9fd0-dcf0-c78b-70efb2d76db1@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=ajit.khaparde@broadcom.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sathya.perla@broadcom.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=sriharsha.basavapatna@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome