mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Arnd Bergmann" <arnd@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev
Subject: Re: [PATCH 1/2] tty: serial: remove hub6 multiport support
Date: Mon, 19 Oct 2026 10:51:58 +0200	[thread overview]
Message-ID: <d0d4182e-342f-4038-ad9f-e6b580c9f2e5@app.fastmail.com> (raw)
In-Reply-To: <atXLd6SdHNr0UcjI@monoceros>

On Mon, Oct 19, 2026, at 09:51, Uwe Kleine-König wrote:
> On Fri, Oct 16, 2026 at 02:59:47PM +0200, Arnd Bergmann wrote:
>> Link: https://mirrors.nycbug.org/pub/The_Unix_Archive/Unix_Usenet/comp.unix.sysv386/1990-December/007174.html
>> Fixes: a300273c458c ("serial: 8250: hub6: Add cleanup code")
>> Fixes: c526404a4a92 ("serial: 8250: Fix corner case for port matching")
>> Fixes: 7ab80d1e7243 ("serial: 8250: fix compile error with hub6_match_port() when compiled as a module")
>> Fixes: da7b5fd4e17f ("serial: 8250_hub6: add missing include for hub6_match_port()")
>> Fixes: 3d406299d882 ("serial: 8250_hub6: add hub6_match_port()")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Fine for me. I wonder about the amount of Fixes: lines, but don't care
> enough to check.

My first thought on this was that the hub6 support should just be a
loadable module and that it would only require inlining hub6_match_port
into its caller, but then I saw that doing this would be exactly a
revert of those five patches that each individually make sense. 

> Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Thanks,

      Arnd

  parent reply	other threads:[~2026-10-19  8:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 12:59 Arnd Bergmann
2026-10-16 12:59 ` [PATCH 2/2] [v2] serial: 8250: remove obsolete and broken PORT_RSA support Arnd Bergmann
2026-10-16 13:14   ` Arnd Bergmann
2026-10-16 13:28 ` [PATCH 1/2] tty: serial: remove hub6 multiport support Andy Shevchenko
2026-10-16 14:41   ` Arnd Bergmann
2026-10-16 13:32 ` Andy Shevchenko
2026-10-16 14:10 ` Hugo Villeneuve
2026-10-16 15:56 ` Hugo Villeneuve
2026-10-16 16:16   ` Arnd Bergmann
2026-10-16 17:17     ` Hugo Villeneuve
2026-10-16 16:48 ` Hugo Villeneuve
2026-10-16 17:12   ` Arnd Bergmann
2026-10-16 17:16     ` Hugo Villeneuve
2026-10-19  8:12   ` Andy Shevchenko
2026-10-16 18:28 ` Frank Li
2026-10-19  7:51 ` Uwe Kleine-König
2026-10-19  8:38   ` Andy Shevchenko
2026-10-19  8:51   ` Arnd Bergmann [this message]
2026-10-19  8:15 ` Jiri Slaby
2026-10-19  9:09   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0d4182e-342f-4038-ad9f-e6b580c9f2e5@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hvilleneuve@dimonoff.com \
    --cc=imx@lists.linux.dev \
    --cc=jirislaby@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®