* Re: TODO : i3c/master/mipi-i3c-hci/dma.c
[not found] <CADVSkwnC6b3irLx58YRGJayw09AvVUqmN=3_b35vdhJKFpsgog@mail.gmail.com>
@ 2024-09-30 13:02 ` Jarkko Nikula
0 siblings, 0 replies; only message in thread
From: Jarkko Nikula @ 2024-09-30 13:02 UTC (permalink / raw)
To: cvam, alexandre.belloni; +Cc: linux-i3c, linux-kernel, Shuah Khan
Hi
On 9/28/24 9:39 PM, cvam wrote:
> Hello Alexandre
>
> This mail is regarding TODO present in the i3c/master/mipi-i3c-hci/dma.c, i
> would like to work on it, please give some more info what exactly we are
> referring here.
>
>
> dev_err(&hci->master.dev,
> "response tid=%d when expecting
> %d\n",
> tid, xfer->cmd_tid);
> /* TODO: do something about it? */
> }
> if (xfer->completion)
> complete(xfer->completion);
>
Well source code has minimum handling for unexpected but uncertain what
to do about it. In my opinion "TODO" is a fair comment about it.
I'd leave it as it until somebody sees it on real and then we can debug
does it need some steps in HW/SW point of view to recover.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-09-30 13:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CADVSkwnC6b3irLx58YRGJayw09AvVUqmN=3_b35vdhJKFpsgog@mail.gmail.com>
2024-09-30 13:02 ` TODO : i3c/master/mipi-i3c-hci/dma.c Jarkko Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®