From: Johannes Berg <johannes@sipsolutions.net>
To: Aditya Kumar Singh <quic_adisi@quicinc.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: cfg80211: fix WARN_ON during CAC cancelling
Date: Wed, 13 Nov 2024 10:29:04 +0100 [thread overview]
Message-ID: <d0eb18d4a302e4be5251106fbfa8f5e10dd36477.camel@sipsolutions.net> (raw)
In-Reply-To: <20241113-mlo_dfs_fix-v1-1-e4326736347b@quicinc.com>
>
> diff --git a/net/wireless/mlme.c b/net/wireless/mlme.c
> index a5eb92d93074e6ce1e08fcc2790b80cf04ff08f8..2a932a036225a3e0587cf5c18a4e80e91552313b 100644
> --- a/net/wireless/mlme.c
> +++ b/net/wireless/mlme.c
> @@ -1112,10 +1112,6 @@ void cfg80211_cac_event(struct net_device *netdev,
> struct cfg80211_registered_device *rdev = wiphy_to_rdev(wiphy);
> unsigned long timeout;
>
> - if (WARN_ON(wdev->valid_links &&
> - !(wdev->valid_links & BIT(link_id))))
> - return;
> -
> trace_cfg80211_cac_event(netdev, event, link_id);
>
> if (WARN_ON(!wdev->links[link_id].cac_started &&
>
This really doesn't seem right.
Perhaps the order in teardown should be changed?
johannes
next prev parent reply other threads:[~2024-11-13 9:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 6:27 Aditya Kumar Singh
2024-11-13 9:29 ` Johannes Berg [this message]
2024-11-13 14:43 ` Aditya Kumar Singh
2024-11-13 15:48 ` Johannes Berg
2024-11-13 16:20 ` Aditya Kumar Singh
2024-11-15 8:14 ` Johannes Berg
2024-11-19 5:53 ` Aditya Kumar Singh
2024-11-20 8:59 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0eb18d4a302e4be5251106fbfa8f5e10dd36477.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_adisi@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®