[PATCH] crypto: iaa - Fix potential use after free bug

[PATCH] crypto: iaa - Fix potential use after free bug

[Dan Carpenter]

The free_device_compression_mode(iaa_device, device_mode) function frees
"device_mode" but it iss passed to iaa_compression_modes[i]->free() a few
lines later resulting in a use after free.

The good news is that, so far as I can tell, nothing implements the
->free() function and the use after free happens in dead code.  But, with
this fix, when something does implement it, we'll be ready.  :)

Fixes: b190447e0fa3 ("crypto: iaa - Add compression mode management along with fixed mode")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/crypto/intel/iaa/iaa_crypto_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c b/drivers/crypto/intel/iaa/iaa_crypto_main.c
index e810d286ee8c..237f87000070 100644
--- a/drivers/crypto/intel/iaa/iaa_crypto_main.c
+++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c
@@ -495,10 +495,10 @@ static void remove_device_compression_modes(struct iaa_device *iaa_device)
 		if (!device_mode)
 			continue;
 
-		free_device_compression_mode(iaa_device, device_mode);
-		iaa_device->compression_modes[i] = NULL;
 		if (iaa_compression_modes[i]->free)
 			iaa_compression_modes[i]->free(device_mode);
+		free_device_compression_mode(iaa_device, device_mode);
+		iaa_device->compression_modes[i] = NULL;
 	}
 }
 
-- 
2.43.0

Re: [PATCH] crypto: iaa - Fix potential use after free bug

[Tom Zanussi]

Hi Dan,

On Wed, 2024-07-24 at 11:09 -0500, Dan Carpenter wrote:
> The free_device_compression_mode(iaa_device, device_mode) function
> frees
> "device_mode" but it iss passed to iaa_compression_modes[i]->free() a
> few
> lines later resulting in a use after free.
> 
> The good news is that, so far as I can tell, nothing implements the
> ->free() function and the use after free happens in dead code.  But,
> with
> this fix, when something does implement it, we'll be ready.  :)
> 

Good catch, thanks for fixing this.

Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>


> Fixes: b190447e0fa3 ("crypto: iaa - Add compression mode management
> along with fixed mode")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  drivers/crypto/intel/iaa/iaa_crypto_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c
> b/drivers/crypto/intel/iaa/iaa_crypto_main.c
> index e810d286ee8c..237f87000070 100644
> --- a/drivers/crypto/intel/iaa/iaa_crypto_main.c
> +++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c
> @@ -495,10 +495,10 @@ static void
> remove_device_compression_modes(struct iaa_device *iaa_device)
>                 if (!device_mode)
>                         continue;
>  
> -               free_device_compression_mode(iaa_device,
> device_mode);
> -               iaa_device->compression_modes[i] = NULL;
>                 if (iaa_compression_modes[i]->free)
>                         iaa_compression_modes[i]->free(device_mode);
> +               free_device_compression_mode(iaa_device,
> device_mode);
> +               iaa_device->compression_modes[i] = NULL;
>         }
>  }
>  

Re: [PATCH] crypto: iaa - Fix potential use after free bug

[Herbert Xu]

On Wed, Jul 24, 2024 at 11:09:43AM -0500, Dan Carpenter wrote:
> The free_device_compression_mode(iaa_device, device_mode) function frees
> "device_mode" but it iss passed to iaa_compression_modes[i]->free() a few
> lines later resulting in a use after free.
> 
> The good news is that, so far as I can tell, nothing implements the
> ->free() function and the use after free happens in dead code.  But, with
> this fix, when something does implement it, we'll be ready.  :)
> 
> Fixes: b190447e0fa3 ("crypto: iaa - Add compression mode management along with fixed mode")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  drivers/crypto/intel/iaa/iaa_crypto_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt