From: "Dmitry Torokhov" <dtor@insightbb.com>
To: "Alexey Dobriyan" <adobriyan@gmail.com>
Cc: linux-joystick@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: Re: misused local_irq_disable() in analog.c?
Date: Wed, 11 Oct 2006 16:17:33 -0400 [thread overview]
Message-ID: <d120d5000610111317k4e849707rc358fdd4ad5dae5b@mail.gmail.com> (raw)
In-Reply-To: <b6fcc0a0610111208s4dbb7c98xbdd3ceb13fba1503@mail.gmail.com>
On 10/11/06, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> Dmitry, take a look at analog_cooked_read():
>
> do-while loop there contains local_irq_disable()/local_irq_restore(flags);
> which aren't complement.
>
> Should it be
>
> local_irq_save(flags);
> this = gameport_read(gameport) & port->mask;
> GET_TIME(now);
> local_irq_restore(flags);
>
> ?
Yep, I think so. Patch?
--
Dmitry
next prev parent reply other threads:[~2006-10-11 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-11 19:08 Alexey Dobriyan
2006-10-11 20:17 ` Dmitry Torokhov [this message]
2006-10-11 20:33 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000610111317k4e849707rc358fdd4ad5dae5b@mail.gmail.com \
--to=dtor@insightbb.com \
--cc=adobriyan@gmail.com \
--cc=linux-joystick@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®