* misused local_irq_disable() in analog.c?
@ 2006-10-11 19:08 Alexey Dobriyan
2006-10-11 20:17 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Dobriyan @ 2006-10-11 19:08 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-joystick, linux-kernel
Dmitry, take a look at analog_cooked_read():
do-while loop there contains local_irq_disable()/local_irq_restore(flags);
which aren't complement.
Should it be
local_irq_save(flags);
this = gameport_read(gameport) & port->mask;
GET_TIME(now);
local_irq_restore(flags);
?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: misused local_irq_disable() in analog.c?
2006-10-11 19:08 misused local_irq_disable() in analog.c? Alexey Dobriyan
@ 2006-10-11 20:17 ` Dmitry Torokhov
2006-10-11 20:33 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2006-10-11 20:17 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: linux-joystick, linux-kernel
On 10/11/06, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> Dmitry, take a look at analog_cooked_read():
>
> do-while loop there contains local_irq_disable()/local_irq_restore(flags);
> which aren't complement.
>
> Should it be
>
> local_irq_save(flags);
> this = gameport_read(gameport) & port->mask;
> GET_TIME(now);
> local_irq_restore(flags);
>
> ?
Yep, I think so. Patch?
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: misused local_irq_disable() in analog.c?
2006-10-11 20:17 ` Dmitry Torokhov
@ 2006-10-11 20:33 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2006-10-11 20:33 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Alexey Dobriyan, linux-joystick, linux-kernel
On Wed, 11 Oct 2006 16:17:33 -0400 Dmitry Torokhov wrote:
> On 10/11/06, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > Dmitry, take a look at analog_cooked_read():
> >
> > do-while loop there contains local_irq_disable()/local_irq_restore(flags);
> > which aren't complement.
> >
> > Should it be
> >
> > local_irq_save(flags);
> > this = gameport_read(gameport) & port->mask;
> > GET_TIME(now);
> > local_irq_restore(flags);
> >
> > ?
>
> Yep, I think so. Patch?
Alexey replied on another thread (Re: [PATCH] misuse of strstr):
"sorry for absence of patch, I'm on wonders of BY dial-up _and_ Gmail
web interface right now."
---
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-11 20:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-11 19:08 misused local_irq_disable() in analog.c? Alexey Dobriyan
2006-10-11 20:17 ` Dmitry Torokhov
2006-10-11 20:33 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®