Re: [PATCH v10 22/24] x86/resctrl: Update assignments on event configuration changes

["Moger, Babu" <bmoger@amd.com>]

Hi Reinette,

On 12/19/2024 9:12 PM, Reinette Chatre wrote:
> Hi Babu,
> 
> On 12/12/24 12:15 PM, Babu Moger wrote:
>> Resctrl provides option to configure events by writing to the interfaces
>> /sys/fs/resctrl/info/L3_MON/mbm_total_bytes_config or
>> /sys/fs/resctrl/info/L3_MON/mbm_local_bytes_config when BMEC (Bandwidth
>> Monitoring Event Configuration) is supported.
>>
>> Whenever the event configuration is updated, MBM assignments must be
>> revised across all monitor groups within the impacted domains.
> 
> This needs imperative tone description of what this patch does.

Sure.

> 
>   
> ...
> 
>> @@ -1825,6 +1825,54 @@ static int mbm_local_bytes_config_show(struct kernfs_open_file *of,
>>   	return 0;
>>   }
>>   
>> +/*
>> + * Review the cntr_cfg domain configuration. If a matching assignment is found,
>> + * update the counter assignment accordingly. This is within the IPI Context,
> 
> This "Review the cntr_cfg domain configuration. If a matching assignment is found,"
> is too vague for me to make sense of what it is trying to do. Can this be made more specific?

Does this look ok?

Check the counter configuration in the domain. If the specific event is 
configured, then update the assignment with the new event configuration 
value. This is within the IPI Context,  so call 
resctrl_abmc_config_one_amd directly"


Thanks,
Babu