Re: [PATCH v10 24/24] x86/resctrl: Introduce interface to modify assignment states of the groups

["Moger, Babu" <bmoger@amd.com>]

Hi Reinette,

On 12/19/2024 9:23 PM, Reinette Chatre wrote:
> Hi Babu,
> 
> On 12/12/24 12:15 PM, Babu Moger wrote:
>> Introduce the interface to assign MBM events in mbm_cntr_assign mode.
> 
> Seems like something is missing ... there is no mention about what
> MBM events are assigned "to".

Sure. Will add some context.

> 
> ...
> 
>> +	if (assign_state & ASSIGN_LOCAL) {
>> +		ret = rdtgroup_assign_cntr_event(r, rdtgrp, d, QOS_L3_MBM_LOCAL_EVENT_ID);
>> +		if (ret)
>> +			goto out_fail;
>> +	}
>> +
>> +	goto next;
>> +
>> +out_fail:
>> +	sprintf(domain, d ? "%ld" : "*", dom_id);
>> +
> 
> The static checker I tried complains that dom_id can be used uninitialized.

Interesting.
dom_id can be uninitialized. That is why we have check "d ?"

unsigned long dom_id = 0;

This might help.

Thanks
Babu