From: Hamza Mahfooz <hamza.mahfooz@amd.com>
To: "Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>, "Roman Li" <roman.li@amd.com>,
"Qingqing Zhuo" <Qingqing.Zhuo@amd.com>
Cc: dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amd/display: Fix a switch statement in populate_dml_output_cfg_from_stream_state()
Date: Mon, 15 Jan 2024 16:51:52 -0500 [thread overview]
Message-ID: <d12c2a3e-2a66-4624-b5e9-9921f3359036@amd.com> (raw)
In-Reply-To: <e597276a8240329a5ece90762425c7cde2ddd7a2.1705157202.git.christophe.jaillet@wanadoo.fr>
On 1/13/24 09:58, Christophe JAILLET wrote:
> It is likely that the statement related to 'dml_edp' is misplaced. So move
> it in the correct "case SIGNAL_TYPE_EDP".
>
> Fixes: 7966f319c66d ("drm/amd/display: Introduce DML2")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Nice catch! Applied, thanks!
> ---
> drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c b/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
> index fa6a93dd9629..64d01a9cd68c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
> @@ -626,8 +626,8 @@ static void populate_dml_output_cfg_from_stream_state(struct dml_output_cfg_st *
> if (is_dp2p0_output_encoder(pipe))
> out->OutputEncoder[location] = dml_dp2p0;
> break;
> - out->OutputEncoder[location] = dml_edp;
> case SIGNAL_TYPE_EDP:
> + out->OutputEncoder[location] = dml_edp;
> break;
> case SIGNAL_TYPE_HDMI_TYPE_A:
> case SIGNAL_TYPE_DVI_SINGLE_LINK:
--
Hamza
prev parent reply other threads:[~2024-01-15 21:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-13 14:58 Christophe JAILLET
2024-01-15 21:51 ` Hamza Mahfooz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d12c2a3e-2a66-4624-b5e9-9921f3359036@amd.com \
--to=hamza.mahfooz@amd.com \
--cc=Qingqing.Zhuo@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roman.li@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®