* [PATCH] drm/amd/display: Fix a switch statement in populate_dml_output_cfg_from_stream_state()
@ 2024-01-13 14:58 Christophe JAILLET
2024-01-15 21:51 ` Hamza Mahfooz
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2024-01-13 14:58 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
Roman Li, Qingqing Zhuo
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, amd-gfx, dri-devel
It is likely that the statement related to 'dml_edp' is misplaced. So move
it in the correct "case SIGNAL_TYPE_EDP".
Fixes: 7966f319c66d ("drm/amd/display: Introduce DML2")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c b/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
index fa6a93dd9629..64d01a9cd68c 100644
--- a/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
+++ b/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
@@ -626,8 +626,8 @@ static void populate_dml_output_cfg_from_stream_state(struct dml_output_cfg_st *
if (is_dp2p0_output_encoder(pipe))
out->OutputEncoder[location] = dml_dp2p0;
break;
- out->OutputEncoder[location] = dml_edp;
case SIGNAL_TYPE_EDP:
+ out->OutputEncoder[location] = dml_edp;
break;
case SIGNAL_TYPE_HDMI_TYPE_A:
case SIGNAL_TYPE_DVI_SINGLE_LINK:
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: Fix a switch statement in populate_dml_output_cfg_from_stream_state()
2024-01-13 14:58 [PATCH] drm/amd/display: Fix a switch statement in populate_dml_output_cfg_from_stream_state() Christophe JAILLET
@ 2024-01-15 21:51 ` Hamza Mahfooz
0 siblings, 0 replies; 2+ messages in thread
From: Hamza Mahfooz @ 2024-01-15 21:51 UTC (permalink / raw)
To: Christophe JAILLET, Harry Wentland, Leo Li, Rodrigo Siqueira,
Alex Deucher, Christian König, Pan, Xinhui, David Airlie,
Daniel Vetter, Roman Li, Qingqing Zhuo
Cc: dri-devel, kernel-janitors, linux-kernel, amd-gfx
On 1/13/24 09:58, Christophe JAILLET wrote:
> It is likely that the statement related to 'dml_edp' is misplaced. So move
> it in the correct "case SIGNAL_TYPE_EDP".
>
> Fixes: 7966f319c66d ("drm/amd/display: Introduce DML2")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Nice catch! Applied, thanks!
> ---
> drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c b/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
> index fa6a93dd9629..64d01a9cd68c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
> @@ -626,8 +626,8 @@ static void populate_dml_output_cfg_from_stream_state(struct dml_output_cfg_st *
> if (is_dp2p0_output_encoder(pipe))
> out->OutputEncoder[location] = dml_dp2p0;
> break;
> - out->OutputEncoder[location] = dml_edp;
> case SIGNAL_TYPE_EDP:
> + out->OutputEncoder[location] = dml_edp;
> break;
> case SIGNAL_TYPE_HDMI_TYPE_A:
> case SIGNAL_TYPE_DVI_SINGLE_LINK:
--
Hamza
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-15 21:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-13 14:58 [PATCH] drm/amd/display: Fix a switch statement in populate_dml_output_cfg_from_stream_state() Christophe JAILLET
2024-01-15 21:51 ` Hamza Mahfooz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®