From: Andrew Lunn <andrew@lunn.ch>
To: Ciprian Regus <ciprian.regus@analog.com>
Cc: selvamani.rajagopal@onsemi.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, parthiban.veerasooran@microchip.com
Subject: Re: [PATCH net 1/2] net: ethernet: oa_tc6: Interrupt is active low, level triggered.
Date: Wed, 20 May 2026 17:27:30 +0200 [thread overview]
Message-ID: <d17d1c7f-5fd6-41de-b935-83f96acde6d0@lunn.ch> (raw)
In-Reply-To: <20260520151621.405125-1-ciprian.regus@analog.com>
On Wed, May 20, 2026 at 06:16:21PM +0300, Ciprian Regus wrote:
> > ret = devm_request_irq(&tc6->spi->dev, tc6->spi->irq, oa_tc6_macphy_isr,
> >- IRQF_TRIGGER_FALLING, dev_name(&tc6->spi->dev),
> >+ IRQF_TRIGGER_LOW, dev_name(&tc6->spi->dev),
> > tc6);
>
> oa_tc6_macphy_isr() doesn't clear the interrupt condition
Since this is an SPI device, there is no way it can clear the
condition, that needs a blocking operation.
> devm_request_threaded_irq(..., IRQF_TRIGGER_LOW | IRQF_ONESHOT, ...)
>
> (together with some rework to call oa_tc6_try_spi_transfer() from the
> threaded irq part).
Threaded makes sense. Not so sure about ONESHOT. We need it to fire
again when the thread handler exists and the condition is still true.
Andrew
prev parent reply other threads:[~2026-05-20 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 16:13 Selvamani Rajagopal
2026-05-15 16:35 ` Andrew Lunn
2026-05-20 15:16 ` Ciprian Regus
2026-05-20 15:27 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d17d1c7f-5fd6-41de-b935-83f96acde6d0@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=ciprian.regus@analog.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parthiban.veerasooran@microchip.com \
--cc=selvamani.rajagopal@onsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®