mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ofer Heifetz <oferh@marvell.com>
To: Marcin Wojtas <mw@semihalf.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>,
	Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	"arm@kernel.org" <arm@kernel.org>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Omri Itach <omrii@marvell.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Nadav Haklai <nadavh@marvell.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Lior Amsalem <alior@marvell.com>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	Jiri Slaby <jslaby@suse.com>, Tejun Heo <tj@kernel.org>,
	Wilson Ding <dingwei@marvell.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v2 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port
Date: Thu, 4 Feb 2016 03:22:04 +0000	[thread overview]
Message-ID: <d18a261fae544e27b12a56bebf4a7006@IL-EXCH01.marvell.com> (raw)
In-Reply-To: <CAPv3WKe6=705iEtsuo0cUtugofiFa_Zt9xydRsgOV+mZ18H-3Q@mail.gmail.com>

Hi Marcin,

I think it is a partial fix since once QA started to use this patch and found that /proc/interrupts prints serial interrupt string multiple times which is clobbering the print.

/Ofer


-----Original Message-----
From: Marcin Wojtas [mailto:mw@semihalf.com] 
Sent: Thursday, February 04, 2016 12:23 AM
To: Thomas Petazzoni; Ofer Heifetz
Cc: Gregory CLEMENT; Jason Cooper; Andrew Lunn; Sebastian Hesselbarth; arm@kernel.org; Catalin Marinas; Will Deacon; Jonathan Corbet; Mark Rutland; devicetree@vger.kernel.org; linux-ide@vger.kernel.org; Greg Kroah-Hartman; Omri Itach; linux-kernel@vger.kernel.org; Nadav Haklai; Hans de Goede; Lior Amsalem; linux-serial@vger.kernel.org; Jiri Slaby; Tejun Heo; Wilson Ding; linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port

I'm sorry, indeed, I was the one to overlook - there was a lot going on in a thread and I missed it.

Ofer, as you found out that IRQF_SHARED help booting ubuntu - do you think it's a hack or fix?

Best regards,
Marcin

2016-02-03 23:02 GMT+01:00 Thomas Petazzoni
<thomas.petazzoni@free-electrons.com>:
> Dear Marcin Wojtas,
>
> On Wed, 3 Feb 2016 22:41:15 +0100, Marcin Wojtas wrote:
>> Hi Gregory,
>>
>> > +       port->irq        = irq->start;
>> > +       port->irqflags   = 0;
>>
>> Same request as for v1, which you must have overlooked:
>> port->irqflags = IRQF_SHARED;
>
> Gregory didn't overlook this comment you made on v1, he even replied 
> to it. Please check Gregory's reply to your review.
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering 
> http://free-electrons.com

  reply	other threads:[~2016-02-04  3:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 18:41 [PATCH v2 00/12] Add support for the Armada 3700 SoC an mvebu ARM64 based Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 01/12] irqchip: armada-370-xp: add Kconfig option for the driver Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 02/12] irqchip: armada-370-xp: do not enable it by default when ARCH_MVEBU is selected Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port Gregory CLEMENT
2016-02-03 21:41   ` Marcin Wojtas
2016-02-03 22:02     ` Thomas Petazzoni
2016-02-03 22:22       ` Marcin Wojtas
2016-02-04  3:22         ` Ofer Heifetz [this message]
2016-02-07  7:17   ` Greg Kroah-Hartman
2016-02-07 11:16     ` Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 04/12] ata: ahci_mvebu: add support for Armada 3700 variant Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 05/12] arm64: add mvebu architecture entry Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 06/12] Documentation: dt-bindings: Add a new compatible for the Armada 3700 Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 07/12] Documentation: dt: Tidy up the Marvell related files Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 08/12] devicetree: bindings: add DT binding for the Marvell Armada 3700 SoC family Gregory CLEMENT
2016-02-03 20:23   ` Rob Herring
2016-02-03 20:38   ` Thomas Petazzoni
2016-02-05 16:03     ` Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 09/12] arm64: dts: add the Marvell Armada 3700 family and a development board Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 10/12] MAINTAINERS: Extend dts entry for ARM64 mvebu files Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 11/12] Documentation: arm: update supported Marvell EBU processors Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 12/12] arm64: defconfig: enable Armada 3700 related config Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d18a261fae544e27b12a56bebf4a7006@IL-EXCH01.marvell.com \
    --to=oferh@marvell.com \
    --cc=alior@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=arm@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dingwei@marvell.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=hdegoede@redhat.com \
    --cc=jason@lakedaemon.net \
    --cc=jslaby@suse.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=omrii@marvell.com \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=tj@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®