From: Mark Lord <mlord@pobox.com>
To: Hayes Wang <hayeswang@realtek.com>, David Miller <davem@davemloft.net>
Cc: nic_swsd <nic_swsd@realtek.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] r8152: Fix broken RX checksums.
Date: Fri, 4 Nov 2016 09:50:20 -0400 [thread overview]
Message-ID: <d1ac848d-d36d-c81a-e0a2-4cab2d7382cd@pobox.com> (raw)
In-Reply-To: <ddbc14e2-dfb5-01f2-0d5b-5b409a01160f@pobox.com>
Yeah, the device or driver is definitely getting confused with rx_desc structures.
I added code to check for unlikely rx_desc values, and it found this for starters:
rx_desc: 00480801 00480401 00480001 0048fc00 0048f800 0048f400 pkt_len=2045
rx_data: 00 f0 48 00 00 ec 48 00 00 e8 48 00 00 e4 48 00 00 e0 48 00 00 dc 48 00 00 d8 48 00 00 d4 48 00
rx_data: 00 d0 48 00 00 cc 48 00 00 c8 48 00 00 c4 48 00 00 c0 48 00 00 bc 48 00 00 b8 48 00 00 b4 48 00
rx_data: 00 b0 48 00 00 ac 48 00 00 01 00 00 81 ed 00 00 00 01 00 00 00 00 00 00 00 00 00 02 4d ac 00 00
rx_data: 10 00 ff ff ff ff 00 00 01 28 83 d6 ff 6d 00 20 25 b1 58 1b 68 ff 00 05 20 01 56 41 17 35 00 00
...
The MTU/MRU on this link is the standard 1500 bytes, so a pkt_len of 2045 isn't valid here.
And the rx_desc values look an awful lot like the rx_data values that follow it.
There's definitely more broken here than just TCP RX checksums.
-ml
next prev parent reply other threads:[~2016-11-04 13:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 22:36 [PATCH] drivers/net/usb/r8152 fix broken rx checksums Mark Lord
2016-10-26 22:54 ` Mark Lord
2016-10-30 21:22 ` David Miller
2016-10-30 23:48 ` Paul Bolle
2016-10-30 23:28 ` [PATCH net] r8152: Fix broken RX checksums Mark Lord
2016-10-31 0:57 ` David Miller
2016-10-31 2:07 ` Mark Lord
2016-10-31 3:53 ` David Miller
2016-10-31 8:14 ` Hayes Wang
2016-10-31 13:24 ` Mark Lord
2016-11-02 18:29 ` Mark Lord
2016-11-04 12:13 ` Mark Lord
[not found] ` <201611030159.uA31x0np004648@rtits1.realtek.com>
2016-11-03 8:56 ` Hayes Wang
2016-11-03 11:43 ` Mark Lord
2016-11-04 13:50 ` Mark Lord [this message]
2016-11-04 20:13 ` Mark Lord
[not found] ` <201611041425.uA4EPwCw018176@rtits1.realtek.com>
2016-11-09 13:09 ` Hayes Wang
2016-11-09 13:19 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1ac848d-d36d-c81a-e0a2-4cab2d7382cd@pobox.com \
--to=mlord@pobox.com \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome