[PATCH v3] RDMA/srp: Fix error handling in srp_add_port

[PATCH v3] RDMA/srp: Fix error handling in srp_add_port

[Ma Ke]

If device_add() fails, call only put_device() to decrement reference
count for cleanup. Do not call device_del() before put_device().

As comment of device_add() says, 'if device_add() succeeds, you should
call device_del() when you want to get rid of it. If device_add() has
not succeeded, use only put_device() to drop the reference count'.

Found by code review.

Cc: stable@vger.kernel.org
Fixes: c8e4c2397655 ("RDMA/srp: Rework the srp_add_port() error path")
Signed-off-by: Ma Ke <make_ruc2021@163.com>
---
Changes in v3:
- modified the bug description as suggestions;
- added a blank line to separate the description and the tags.
Changes in v2:
- modified the bug description as suggestions.
---
 drivers/infiniband/ulp/srp/ib_srp.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
index 2916e77f589b..7289ae0b83ac 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++ b/drivers/infiniband/ulp/srp/ib_srp.c
@@ -3978,7 +3978,6 @@ static struct srp_host *srp_add_port(struct srp_device *device, u32 port)
 	return host;
 
 put_host:
-	device_del(&host->dev);
 	put_device(&host->dev);
 	return NULL;
 }
-- 
2.25.1

Re: [PATCH v3] RDMA/srp: Fix error handling in srp_add_port()

[Markus Elfring]

> If device_add() fails, call only put_device() to decrement reference
> count for cleanup. Do not call device_del() before put_device().
…
> Found by code review.

Are you looking for possibilities to improve automated source code analyses accordingly?

Regards,
Markus