[PATCH v1 0/2] tty: serial: samsung: Add Exynos8895 compatible

[PATCH v1 0/2] tty: serial: samsung: Add Exynos8895 compatible

[Ivaylo Ivanov]

Hey folks,

This patchset adds serial driver support for Exynos8895 SoC. The main
difference from other exynos platforms is that fifosize is only
specified via the samsung,uart-fifosize DT property.

Newer Exynos platforms also specify fifosize via DT, so in such case
this compatible could be used with oneOf.

Ivaylo Ivanov (2):
  dt-bindings: serial: samsung: Add samsung,exynos8895-uart compatible
  tty: serial: samsung: Add Exynos8895 compatible

 .../bindings/serial/samsung_uart.yaml           | 17 +++++++++++++++++
 drivers/tty/serial/samsung_tty.c                | 13 +++++++++++++
 2 files changed, 30 insertions(+)

-- 
2.43.0

[PATCH v1 1/2] dt-bindings: serial: samsung: Add samsung,exynos8895-uart compatible

[Ivaylo Ivanov]

Add dedicated samsung,exynos8895-uart compatible to the dt-schema for
representing uart of the Exynos8895 SoC.

Like GS101, it has a required DT property samsung,uart-fifosize, but
it does not exhibit the 32 bit register access limit.

Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
---
 .../bindings/serial/samsung_uart.yaml           | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
index 788c80e47..2491b6048 100644
--- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
+++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
@@ -27,6 +27,7 @@ properties:
           - samsung,exynos4210-uart
           - samsung,exynos5433-uart
           - samsung,exynos850-uart
+          - samsung,exynos8895-uart
       - items:
           - enum:
               - samsung,exynos7-uart
@@ -172,6 +173,22 @@ allOf:
         clock-names:
           maxItems: 2
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - samsung,exynos8895-uart
+    then:
+      required:
+        - samsung,uart-fifosize
+      properties:
+        clocks:
+          maxItems: 2
+
+        clock-names:
+          maxItems: 2
+
 unevaluatedProperties: false
 
 examples:
-- 
2.43.0

Re: [PATCH v1 1/2] dt-bindings: serial: samsung: Add samsung,exynos8895-uart compatible

[Krzysztof Kozlowski]

On 20/10/2024 20:02, Ivaylo Ivanov wrote:
> Add dedicated samsung,exynos8895-uart compatible to the dt-schema for
> representing uart of the Exynos8895 SoC.
> 
> Like GS101, it has a required DT property samsung,uart-fifosize, but
> it does not exhibit the 32 bit register access limit.
> 
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> ---
>  .../bindings/serial/samsung_uart.yaml           | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> index 788c80e47..2491b6048 100644
> --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> @@ -27,6 +27,7 @@ properties:
>            - samsung,exynos4210-uart
>            - samsung,exynos5433-uart
>            - samsung,exynos850-uart
> +          - samsung,exynos8895-uart
>        - items:
>            - enum:
>                - samsung,exynos7-uart
> @@ -172,6 +173,22 @@ allOf:
>          clock-names:
>            maxItems: 2
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - samsung,exynos8895-uart

This looks exactly like gs101, so please grow the enum there.

Best regards,
Krzysztof

Re: [PATCH v1 1/2] dt-bindings: serial: samsung: Add samsung,exynos8895-uart compatible

[Ivaylo Ivanov]

On 10/21/24 12:29, Krzysztof Kozlowski wrote:
> On 20/10/2024 20:02, Ivaylo Ivanov wrote:
>> Add dedicated samsung,exynos8895-uart compatible to the dt-schema for
>> representing uart of the Exynos8895 SoC.
>>
>> Like GS101, it has a required DT property samsung,uart-fifosize, but
>> it does not exhibit the 32 bit register access limit.
>>
>> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
>> ---
>>  .../bindings/serial/samsung_uart.yaml           | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
>> index 788c80e47..2491b6048 100644
>> --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
>> +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
>> @@ -27,6 +27,7 @@ properties:
>>            - samsung,exynos4210-uart
>>            - samsung,exynos5433-uart
>>            - samsung,exynos850-uart
>> +          - samsung,exynos8895-uart
>>        - items:
>>            - enum:
>>                - samsung,exynos7-uart
>> @@ -172,6 +173,22 @@ allOf:
>>          clock-names:
>>            maxItems: 2
>>  
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            enum:
>> +              - samsung,exynos8895-uart
> This looks exactly like gs101, so please grow the enum there.

It's missing the reg-io-width property. My initial idea was to add a

completely new entry, so new exynos platforms that don't exhibit

the same issue could grow the enum there.

Although now that I think about it, I could grow the gs101 enum and set

the  reg-io-width property for gs101 after that list.

Best regards, Ivo.

> Best regards,
> Krzysztof
>

[PATCH v1 2/2] tty: serial: samsung: Add Exynos8895 compatible

[Ivaylo Ivanov]

Add serial driver data for Exynos8895 SoC. The main difference from
other platforms is that fifosize is only specified via the
samsung,uart-fifosize DT property.

Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
---
 drivers/tty/serial/samsung_tty.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index 0d184ee2f..ce3c3ec34 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -2498,6 +2498,12 @@ static const struct s3c24xx_serial_drv_data exynos850_serial_drv_data = {
 	.fifosize = { 256, 64, 64, 64 },
 };
 
+static const struct s3c24xx_serial_drv_data exynos8895_serial_drv_data = {
+	EXYNOS_COMMON_SERIAL_DRV_DATA,
+	/* samsung,uart-fifosize must be specified in the device tree. */
+	.fifosize = { 0 },
+};
+
 static const struct s3c24xx_serial_drv_data gs101_serial_drv_data = {
 	.info = {
 		.name		= "Google GS101 UART",
@@ -2528,12 +2534,14 @@ static const struct s3c24xx_serial_drv_data gs101_serial_drv_data = {
 #define EXYNOS4210_SERIAL_DRV_DATA (&exynos4210_serial_drv_data)
 #define EXYNOS5433_SERIAL_DRV_DATA (&exynos5433_serial_drv_data)
 #define EXYNOS850_SERIAL_DRV_DATA (&exynos850_serial_drv_data)
+#define EXYNOS8895_SERIAL_DRV_DATA (&exynos8895_serial_drv_data)
 #define GS101_SERIAL_DRV_DATA (&gs101_serial_drv_data)
 
 #else
 #define EXYNOS4210_SERIAL_DRV_DATA NULL
 #define EXYNOS5433_SERIAL_DRV_DATA NULL
 #define EXYNOS850_SERIAL_DRV_DATA NULL
+#define EXYNOS8895_SERIAL_DRV_DATA NULL
 #define GS101_SERIAL_DRV_DATA NULL
 #endif
 
@@ -2623,6 +2631,9 @@ static const struct platform_device_id s3c24xx_serial_driver_ids[] = {
 	}, {
 		.name		= "gs101-uart",
 		.driver_data	= (kernel_ulong_t)GS101_SERIAL_DRV_DATA,
+	}, {
+		.name		= "exynos8895-uart",
+		.driver_data	= (kernel_ulong_t)EXYNOS8895_SERIAL_DRV_DATA,
 	},
 	{ },
 };
@@ -2646,6 +2657,8 @@ static const struct of_device_id s3c24xx_uart_dt_match[] = {
 		.data = ARTPEC8_SERIAL_DRV_DATA },
 	{ .compatible = "google,gs101-uart",
 		.data = GS101_SERIAL_DRV_DATA },
+	{ .compatible = "samsung,exynos8895-uart",
+		.data = EXYNOS8895_SERIAL_DRV_DATA },
 	{},
 };
 MODULE_DEVICE_TABLE(of, s3c24xx_uart_dt_match);
-- 
2.43.0

Re: [PATCH v1 2/2] tty: serial: samsung: Add Exynos8895 compatible

[Krzysztof Kozlowski]

On 20/10/2024 20:02, Ivaylo Ivanov wrote:
> Add serial driver data for Exynos8895 SoC. The main difference from
> other platforms is that fifosize is only specified via the
> samsung,uart-fifosize DT property.
> 
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> ---
>  drivers/tty/serial/samsung_tty.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof