From: vivek pernamitta <vivek.pernamitta@oss.qualcomm.com>
To: Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
Vivek Pernamitta <vpernami@qti.qualcomm.com>
Subject: Re: [PATCH v7 1/2] net: mhi: Enable Ethernet interface support
Date: Wed, 11 Feb 2026 15:54:59 +0530 [thread overview]
Message-ID: <d24a947d-6b6e-4393-b0b6-1e9281f8a0cb@oss.qualcomm.com> (raw)
In-Reply-To: <59e7518f-65b2-4d97-ab81-bf64af758d00@redhat.com>
On 2/10/2026 4:13 PM, Paolo Abeni wrote:
> On 2/5/26 11:34 AM, Vivek Pernamitta wrote:
>> @@ -4,6 +4,7 @@
>> * Copyright (C) 2020 Linaro Ltd <loic.poulain@linaro.org>
>> */
>>
>> +#include <linux/etherdevice.h>
>> #include <linux/if_arp.h>
>> #include <linux/mhi.h>
>> #include <linux/mod_devicetable.h>
>> @@ -38,10 +39,12 @@ struct mhi_net_dev {
>> u32 rx_queue_sz;
>> int msg_enable;
>> unsigned int mru;
>> + bool ethernet_if;
>
> This is not needed, instead you could check !!dev->header_ops
>
> /P
>
As this driver supports only Ethernet and IP net interface types.
Will remove the ethernet_if member from the mhi_net_dev structure
and use net_device->header_ops for interface-type checks
next prev parent reply other threads:[~2026-02-11 10:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 10:34 [PATCH v7 0/2] net: mhi: Add support to enable ethernet interface Vivek Pernamitta
2026-02-05 10:34 ` [PATCH v7 1/2] net: mhi: Enable Ethernet interface support Vivek Pernamitta
2026-02-05 14:08 ` Loic Poulain
2026-02-11 10:19 ` vivek pernamitta
2026-02-10 10:43 ` Paolo Abeni
2026-02-11 10:24 ` vivek pernamitta [this message]
2026-02-05 10:34 ` [PATCH v7 2/2] bus: mhi: host: pci: Enable IP_SW1, IP_ETH0 and IP_ETH1 channels for QDU100 Vivek Pernamitta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d24a947d-6b6e-4393-b0b6-1e9281f8a0cb@oss.qualcomm.com \
--to=vivek.pernamitta@oss.qualcomm.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vpernami@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®