From: Paolo Abeni <pabeni@redhat.com>
To: Raju Rangoju <Raju.Rangoju@amd.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kuba@kernel.org,
edumazet@google.com, davem@davemloft.net, andrew+netdev@lunn.ch
Subject: Re: [PATCH net-next] amd-xgbe: add robust link-down TX queue handling
Date: Tue, 17 Mar 2026 13:20:55 +0100 [thread overview]
Message-ID: <d2900f79-f481-418b-986e-7b86ab20c803@redhat.com> (raw)
In-Reply-To: <20260313134628.3827338-1-Raju.Rangoju@amd.com>
On 3/13/26 2:46 PM, Raju Rangoju wrote:
> Add comprehensive link-down handling to improve driver robustness and
> enable fast recovery from link failures. Currently, the driver lacks
> proper cleanup mechanisms when the physical link goes down with
> packets in-flight, which can impact network stability and failover
> performance.
>
> This enhancement adds intelligent TX queue management during link state
> transitions:
>
> Link-down detection improvements:
> - Adaptive polling: 100ms intervals when carrier is up for fast
> link-down detection, vs 1000ms when down to conserve CPU
> - Enables ~100-200ms link-down response time (10x improvement)
>
> Smart TX queue handling:
> - Immediate TX queue stop on link-down to halt new submissions
> - Skip futile hardware drain attempts when link is already down
> - Force-cleanup abandoned TX descriptors that hardware won't complete
> - Proper descriptor and skb resource reclamation
It looks like this one should be split in multiple patches, to better
isolate each specific improvements.
/P
prev parent reply other threads:[~2026-03-17 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 13:46 Raju Rangoju
2026-03-17 12:20 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2900f79-f481-418b-986e-7b86ab20c803@redhat.com \
--to=pabeni@redhat.com \
--cc=Raju.Rangoju@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®